Page MenuHomeFreeBSD

Build tests-dbg.txz distfile
AcceptedPublic

Authored by lwhsu on Nov 7 2019, 6:22 AM.
Tags
None
Referenced Files
F82209443: D22272.diff
Fri, Apr 26, 1:09 PM
Unknown Object (File)
Dec 22 2023, 10:49 PM
Unknown Object (File)
Jul 6 2023, 2:34 PM
Unknown Object (File)
Mar 21 2023, 8:32 PM
Unknown Object (File)
Mar 4 2023, 10:42 AM
F5835094: tests-dbg.txt
Nov 8 2019, 2:53 PM
Subscribers

Details

Reviewers
bapt
bdrewery
cem
emaste
ngie
asomers
Group Reviewers
releng
Summary

Build tests-dbg.txz distfile which contains the test binaries with
debug symble. It is useful for debugging failing test cases.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27385
Build 25632: arc lint + arc unit

Event Timeline

With the caveat that I am unfamiliar with this part of the build, looks reasonable to me. (And I am supportive of the objective.)

This revision is now accepted and ready to land.Nov 7 2019, 3:57 PM

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

The changes are great!

Minor request: please fix the spelling errors in the proposed commit message before committing.

In D22272#486919, @gjb wrote:

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

Hmmmm... if so, that needs to be fixed :(.

In D22272#486919, @gjb wrote:

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

Yes, I have tested before and reconfirmed again. I didn't check which revision makes it contains right files, but I did a clean build and test-dbg.txz contains files as https://gist.github.com/lwhsu/daa0fca8c3ff59127e0632ade3e0523a

I suspect you will also want to include this for bsdinstall(8) then.