Page MenuHomeFreeBSD

Build tests-dbg.txz distfile
AcceptedPublic

Authored by lwhsu on Thu, Nov 7, 6:22 AM.

Details

Reviewers
bapt
bdrewery
cem
emaste
ngie
asomers
Group Reviewers
releng
Summary

Build tests-dbg.txz distfile which contains the test binaries with
debug symble. It is useful for debugging failing test cases.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 27385
Build 25632: arc lint + arc unit

Event Timeline

lwhsu created this revision.Thu, Nov 7, 6:22 AM
lwhsu added a reviewer: releng.Thu, Nov 7, 1:39 PM
cem accepted this revision.Thu, Nov 7, 3:57 PM

With the caveat that I am unfamiliar with this part of the build, looks reasonable to me. (And I am supportive of the objective.)

This revision is now accepted and ready to land.Thu, Nov 7, 3:57 PM
gjb added a subscriber: gjb.Thu, Nov 7, 5:01 PM

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

ngie accepted this revision.Thu, Nov 7, 5:10 PM

The changes are great!

Minor request: please fix the spelling errors in the proposed commit message before committing.

ngie added a comment.Thu, Nov 7, 5:11 PM
In D22272#486919, @gjb wrote:

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

Hmmmm... if so, that needs to be fixed :(.

lwhsu added a comment.Fri, Nov 8, 10:01 AM
In D22272#486919, @gjb wrote:

Has it been confirmed that the tests-dbg.txz file in fact contains files? I removed it from the list of EXTRA_DISTRIBUTIONS in r278486 because it resulted in an archive that did not have any content.

Yes, I have tested before and reconfirmed again. I didn't check which revision makes it contains right files, but I did a clean build and test-dbg.txz contains files as https://gist.github.com/lwhsu/daa0fca8c3ff59127e0632ade3e0523a

gjb added a comment.Fri, Nov 8, 2:53 PM

I suspect you will also want to include this for bsdinstall(8) then.