Page MenuHomeFreeBSD

Add hardware breakpoint support to ddb
Needs ReviewPublic

Authored by andrew on Wed, Oct 30, 12:17 PM.

Details

Reviewers
manu
Summary

As with hardware watchpoints support hardware breakpoints. Currently only
arm64 is supported, however other architectures with precise hardware
breakpoints could be added.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 27273
Build 25536: arc lint + arc unit

Event Timeline

andrew created this revision.Wed, Oct 30, 12:17 PM
bz added a subscriber: bz.Wed, Oct 30, 1:23 PM

All your "stub functions" return (0), when in fact they probably should return an error? Or what happens if someone tries to set a (hw)breakpoint on these architectures?

In D22191#484972, @bz wrote:

All your "stub functions" return (0), when in fact they probably should return an error? Or what happens if someone tries to set a (hw)breakpoint on these architectures?

They are identical to the equivalent watchpoint functions, these also return 0 when not implementing hardware watchpoints.

imp added a subscriber: imp.Wed, Oct 30, 7:43 PM
imp added inline comments.
sys/arm/arm/db_trace.c
141

Shouldn't the stubs return failure?

andrew added inline comments.Thu, Oct 31, 3:23 PM
sys/arm/arm/db_trace.c
141

I copied the hardware watchpoint stubs. These all return 0 when not implemented.