Waiting for: https://reviews.freebsd.org/D17971
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| contrib/elftoolchain/strings/strings.c | ||
|---|---|---|
| 200 ↗ | (On Diff #50564) | I would maybe print "unable to initialize casper fileargs." I expect emaste will say, "what do we expect a user to do differently?", and from that perspective, sure, the two failures are essentially the same problem. But as a developer who may occasionally debug capsicumized programs, I greatly prefer that error messages are unique in code, so it is clear where the fault occurred. I do not feel strongly about it. |
| 204 ↗ | (On Diff #50564) | Why free before err() exit? |
| 218 ↗ | (On Diff #50564) | Why free before return exit? :-) |
| usr.bin/strings/Makefile | ||
| 13–17 ↗ | (On Diff #50564) | If !defined(WITH_CASPER), does caph_enter_casper() not enter the capsicum sandbox? (It seems that this program will be totally broken if the sandbox is entered with MK_CASPER=no.) |
Comment Actions
As with the other strings reviews, adding @kaiw and @jkoshy_users.sourceforge.net to CC
I think we want to rework this change slightly so that it could be changed upstream and still buid out of the box on Linux and older FreeBSD.
| contrib/elftoolchain/strings/strings.c | ||
|---|---|---|
| 200 ↗ | (On Diff #50564) | That is what I might say, but I don't feel strongly either. |
| contrib/elftoolchain/strings/strings.c | ||
|---|---|---|
| 202–203 ↗ | (On Diff #50564) | @jkoshy_users.sourceforge.net this is the "sandbox setup & enter" entry; for OpenBSD this would be a pledge() call. The fileargs_init() and fileargs_fopen() are the magic bits that perform the privilege separated file opening and fd shuffling that do not have an equivalent on !FreeBSD. |
| contrib/elftoolchain/strings/strings.c | ||
|---|---|---|
| 200 ↗ | (On Diff #50564) | Ok I will address that. |
| 204 ↗ | (On Diff #50564) | It's just nice to clean up after yourself, and I wanted to do another good example just to fallow. |
| 218 ↗ | (On Diff #50564) | It's just nice to clean up after yourself, and I wanted to do another good example just to fallow. |
| usr.bin/strings/Makefile | ||
| 13–17 ↗ | (On Diff #50564) | Yes. |
Comment Actions
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238511
regression broken build emulators/i386-wine-devel
| head/contrib/elftoolchain/strings/strings.c | ||
|---|---|---|
| 203 | This should be ||. | |