400G media types
ClosedPublic
Actions

Authored by erj on Aug 15 2018, 6:59 PM.

Details

Reviewers

sbruno
• hselasky
jhb
np

Group Reviewers

Intel Networking

Commits

rS338208: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types

Summary

The driver to support upcoming hardware from Intel supports more media types than what are in the kernel already, so this commit adds the missing media types.

These mostly include new 25/50/100G media types, as well as some for the brand new 200G/400G speeds.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18823
Build 18487: arc lint + arc unit

Event Timeline

erj created this revision.Aug 15 2018, 6:59 PM

Herald added subscribers: ae, imp. · View Herald TranscriptAug 15 2018, 6:59 PM

Harbormaster completed remote builds in B18823: Diff 46727.Aug 15 2018, 6:59 PM

gallatin added a reviewer: np.Aug 15 2018, 7:03 PM

Looks good.

This revision is now accepted and ready to land.Aug 16 2018, 7:08 AM

In terms of adding new entries this looks fine. I don't know the media types to validate the entries themselves.

I see IFM_40G_ER4 is missing from the table. There is only IFM_40G_LR4 currently.

Can you add IFM_40G_ER4 as part of this patch aswell?

• hselasky added subscribers: menyy_mellanox.com, slavash.Aug 20 2018, 9:24 AM

In D16731#357695, @hselasky wrote:

I see IFM_40G_ER4 is missing from the table. There is only IFM_40G_LR4 currently.

Can you add IFM_40G_ER4 as part of this patch aswell?

Yeah, I'll update the patch with it.

if_media: Add 40Gbase-ER4 media type.

This revision now requires review to proceed.Aug 20 2018, 6:37 PM

Harbormaster completed remote builds in B18980: Diff 46991.Aug 20 2018, 6:38 PM

Can I get this patch re-reviewed before committing it?

• hselasky accepted this revision.Aug 21 2018, 5:47 PM

This revision is now accepted and ready to land.Aug 21 2018, 5:47 PM

• hselasky added inline comments.Aug 21 2018, 5:48 PM

sys/net/if_media.h
502	Small typo: Gbase -> GBase

Fix typo (from @hselasky)

However, I now notice that all of the new media types use "Base" instead of "base". Should
they all be changed to use one or the other? Or should the "new/IFM_X()" types continue
to use "Base"?

This revision now requires review to proceed.Aug 22 2018, 12:51 AM

Harbormaster completed remote builds in B19028: Diff 47075.Aug 22 2018, 12:52 AM

I think "GBase" was the common before this change aswell.

• hselasky accepted this revision.Aug 22 2018, 7:35 AM

This revision is now accepted and ready to land.Aug 22 2018, 7:35 AM

Closed by commit rS338208: if_media: Add new 2.5G/5G/25G/40G/50G/100G/200G/400G media types (authored by erj). · Explain WhyAug 22 2018, 6:20 PM

This revision was automatically updated to reflect the committed changes.