Details

sys/conf/kern.post.mk
188	Yes. See the _KBI functions in epoch.h. Much like locks and atomics there's no provision for in-tree modules to use the inline variants. I hope to address that at some point.

mmacy added a reviewer: jhb.Jun 29 2018, 7:36 PM

fix rack / LINT build

Harbormaster completed remote builds in B17737: Diff 44668.Jun 29 2018, 9:54 PM

fix cast
add dumponfail option to in_epoch

Harbormaster completed remote builds in B17738: Diff 44669.Jun 29 2018, 10:21 PM

use dynamically generated thread_global to eliminate proc.h dependencies

Harbormaster completed remote builds in B17746: Diff 44689.Jun 30 2018, 7:21 PM

mmacy added inline comments.Jun 30 2018, 7:23 PM

sys/conf/kern.post.mk
188	Modules wanting inline atomics, locks, and epoch sections can define KLD_BASE. So far I've only done it for rack and fastpath but it may make sense for ZFS and the 100G drivers.

rack fixes
eliminate redundant acquisitions

Harbormaster completed remote builds in B17756: Diff 44701.Jul 1 2018, 1:15 AM

eliminate ti_locked branchfest in do_segment, rack, and fastpath
replace all INP_INFO_{RLOCK, RUNLOCK} with explicit epoch_tracker usage
restore TIMEWAIT checks at close

Harbormaster completed remote builds in B17780: Diff 44748.Jul 2 2018, 8:05 AM

don't drop reference in lock del as we're no longer adding a ref prior
rebase
cleanups

Harbormaster completed remote builds in B17800: Diff 44779.Jul 2 2018, 11:25 PM

j-nitrology.com added a subscriber: j-nitrology.com.Jul 3 2018, 1:22 AM

rebase to inline critical

Harbormaster completed remote builds in B17806: Diff 44788.Jul 3 2018, 4:06 AM

rebase

Harbormaster completed remote builds in B17828: Diff 44836.Jul 4 2018, 12:16 AM

We've tested this in synthetic stress testing and production load at LLNW. This is a wide reaching change and has higher chance for fallout, but I think getting additional public testing in HEAD will be the most prudent use of time to stabilize the KPI and implementation for 12.0-RELEASE.

@jtl for NF there are some minor mechanical changes that will be needed for your out of tree stacks.

This revision is now accepted and ready to land.Jul 4 2018, 2:30 AM

mmacy closed this revision.Jul 4 2018, 3:34 AM

allow epochs to composeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44701

sys/amd64/include/atomic.h

sys/conf/kern.post.mk

sys/conf/kern.pre.mk

sys/dev/cxgbe/tom/t4_connect.c

sys/dev/hwpmc/hwpmc_mod.c

sys/kern/genoffset.c

sys/kern/genoffset.sh

sys/kern/kern_switch.c

sys/kern/subr_epoch.c

sys/modules/tcp/fastpath/Makefile

sys/modules/tcp/rack/Makefile

sys/net/if.c

sys/net/if_gif.h

sys/net/if_gre.h

sys/net/if_lagg.c

sys/net/if_me.c

sys/net/if_var.h

sys/net/route.c

sys/net/rtsock.c

sys/netinet/in_gif.c

sys/netinet/in_pcb.h

sys/netinet/in_pcb.c

sys/netinet/ip_divert.c

sys/netinet/ip_encap.c

sys/netinet/ip_gre.c

sys/netinet/raw_ip.c

sys/netinet/tcp_hpts.c

sys/netinet/tcp_input.c

sys/netinet/tcp_stacks/fastpath.c

sys/netinet/tcp_stacks/rack.c

sys/netinet/tcp_timer.h

sys/netinet/tcp_timer.c

sys/netinet/tcp_usrreq.c

sys/netinet/udp_usrreq.c

sys/netinet6/in6_gif.c

sys/netinet6/ip6_gre.c

sys/netinet6/udp6_usrreq.c

sys/sys/assym.h

sys/sys/epoch.h

sys/sys/epoch_private.h

sys/sys/lock.h

sys/sys/mutex.h

sys/sys/pmckern.h

sys/sys/proc.h

sys/sys/systm.h

allow epochs to compose
ClosedPublic
Actions

Revision Contents
Changeset List