Convert if_afdata read lock path to epoch
AbandonedPublic
Actions

Authored by mmacy on May 13 2018, 5:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 21, 2:52 PM

	Unknown Object (File)
	Sat, Mar 21, 9:06 AM

	Unknown Object (File)
	Fri, Mar 20, 11:34 PM

	Unknown Object (File)
	Fri, Mar 20, 7:52 PM

	Unknown Object (File)
	Thu, Mar 19, 4:08 AM

	Unknown Object (File)
	Thu, Mar 19, 4:05 AM

	Unknown Object (File)
	Tue, Mar 17, 2:09 PM

	Unknown Object (File)
	Mon, Mar 16, 11:52 PM

Subscribers

Details

Reviewers

ae
jeff
gallatin
shurd
sbruno
olivier
melifaro

Summary

Convert write lock to mutex
Convert read lock to epoch
Do destroy / free of llentrys after grace period has elapsed

For the impact see flame graph 4 -> 5 at:
https://github.com/ScaleBSD/scalebsd.github.io/blob/master/_drafts/2018-05-12-UDP-On-FreeBSD-is-anyone-using-this-at-scale.md

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mmacy created this revision.May 13 2018, 5:13 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 13 2018, 5:13 AM

ae added reviewers: olivier, melifaro.May 14 2018, 3:06 PM

mmacy abandoned this revision.May 18 2018, 9:49 PM

mmacy mentioned this in D15409: Protect global ifnet list and short lived ifaddr references with epoch.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_llatbl.h

2 lines

if_llatbl.c

16 lines

if_var.h

24 lines

netinet/

in.c

10 lines

netinet6/

in6.c

10 lines

Diff 42468

View Options

sys/net/if_llatbl.h

View Options

sys/net/if_llatbl.c

View Options

sys/net/if_var.h

View Options

sys/netinet/in.c

View Options

Convert if_afdata read lock path to epochAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42468

sys/net/if_llatbl.h

sys/net/if_llatbl.c

sys/net/if_var.h

sys/netinet/in.c

sys/netinet6/in6.c

Convert if_afdata read lock path to epoch
AbandonedPublic
Actions

Revision Contents
Changeset List