As a result, expand coverage of tests using breakpoint() to more
architectures.
Details
Details
- I have not tested any of these, so testing by others and/or review would be welcome. I would probably commit these separately, but they are glummed together in the branch this is part of so it's a bit easier to solicit review/testing with a combined patch.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/arm/include/cpufunc.h | ||
|---|---|---|
| 503 ↗ | (On Diff #41829) | What instruction is this? You might also be able to use the .inst directive here. |
| sys/arm/include/cpufunc.h | ||
|---|---|---|
| 503 ↗ | (On Diff #41829) | This matches GDB5_BREAKPOINT from sys/arm/include/trap.h and it is what GDB uses as the default breakpoint instructions for non-thumb arm: https://github.com/bsdjhb/gdb/blob/master/gdb/arm-tdep.c#L7761 The in-kernel breakpoint() uses .word with the value of KERNEL_BREAKPOINT and I just used that as my template. |
| sys/arm/include/cpufunc.h | ||
|---|---|---|
| 503 ↗ | (On Diff #41829) | It seems to be udf 0xfdee. udf is an instruction that raises the undefined instruction exception. |
| sys/arm/include/cpufunc.h | ||
|---|---|---|
| 503 ↗ | (On Diff #41829) | Perhaps a comment with that reference? |
Comment Actions
- Updated to use 'udf' on 32-bit arm and tested on 32-bit arm.
- Still need to verify arm64.
Comment Actions
Have verified via ptrace_test on arm64 as well now, so both arm and arm64 have been runtime tested.