Paths

Table of Contentst

Differential D15191

Export a breakpoint() function to userland.
ClosedPublic
Actions

Authored by jhb on Apr 25 2018, 2:43 AM.

Tags

None

Referenced Files

	F167534671: D15191.id44667.diff
	Sat, Aug 22, 1:26 PM

	F167528060: D15191.id44979.diff
	Sat, Aug 22, 12:25 PM

	F167501803: D15191.id41829.diff
	Sat, Aug 22, 8:20 AM

	F167432001: D15191.id42636.diff
	Fri, Aug 21, 5:04 PM

	F167430745: D15191.id41829.diff
	Fri, Aug 21, 4:50 PM

	F167430654: D15191.id44667.diff
	Fri, Aug 21, 4:49 PM

	Unknown Object (File)
	Fri, Aug 21, 2:21 PM

	Unknown Object (File)
	Fri, Aug 21, 1:31 PM

Subscribers

Details

Reviewers

br
manu
andrew

Group Reviewers

ARM
arm64

Commits

rS336053: Export a breakpoint() function to userland for arm and arm64.
rS333679: Export a breakpoint() function to userland for riscv.

Summary

As a result, expand coverage of tests using breakpoint() to more
architectures.

Test Plan

I have not tested any of these, so testing by others and/or review would be welcome. I would probably commit these separately, but they are glummed together in the branch this is part of so it's a bit easier to solicit review/testing with a combined patch.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17736
Build 17536: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 25 2018, 2:43 AM

Herald added subscribers: emaste, andrew. · View Herald TranscriptApr 25 2018, 2:43 AM

Harbormaster completed remote builds in B16292: Diff 41829.Apr 25 2018, 2:43 AM

andrew added inline comments.Apr 25 2018, 9:50 AM

sys/arm/include/cpufunc.h
516	What instruction is this? You might also be able to use the `.inst` directive here.

jhb added inline comments.Apr 25 2018, 4:34 PM

sys/arm/include/cpufunc.h
516	This matches GDB5_BREAKPOINT from sys/arm/include/trap.h and it is what GDB uses as the default breakpoint instructions for non-thumb arm: https://github.com/bsdjhb/gdb/blob/master/gdb/arm-tdep.c#L7761 The in-kernel breakpoint() uses .word with the value of KERNEL_BREAKPOINT and I just used that as my template.

andrew added inline comments.Apr 25 2018, 5:09 PM

sys/arm/include/cpufunc.h
516	It seems to be `udf 0xfdee`. `udf` is an instruction that raises the undefined instruction exception.

emaste added inline comments.May 1 2018, 1:55 PM

sys/arm/include/cpufunc.h
516	Perhaps a comment with that reference?

br accepted this revision as: br.May 1 2018, 3:29 PM

This revision is now accepted and ready to land.May 1 2018, 3:29 PM

Closed by commit rS333679: Export a breakpoint() function to userland for riscv. (authored by jhb). · Explain WhyMay 16 2018, 4:57 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 16 2018, 4:57 PM

jhb reopened this revision.May 16 2018, 6:43 PM

Updated to use 'udf' on 32-bit arm and tested on 32-bit arm.
Still need to verify arm64.

Herald added a reviewer: manu. · View Herald TranscriptJun 29 2018, 9:23 PM

Harbormaster completed remote builds in B17736: Diff 44667.Jun 29 2018, 9:23 PM

Have verified via ptrace_test on arm64 as well now, so both arm and arm64 have been runtime tested.

andrew accepted this revision.Jul 6 2018, 11:40 AM

This revision is now accepted and ready to land.Jul 6 2018, 11:40 AM

Closed by commit rS336053: Export a breakpoint() function to userland for arm and arm64. (authored by jhb). · Explain WhyJul 6 2018, 11:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm/

include/

15 lines

arm64/

include/

12 lines

tests/

sys/

kern/

11 lines

Diff 44667

sys/arm/include/cpufunc.h

Loading...

sys/arm64/include/cpufunc.h

Loading...

tests/sys/kern/ptrace_test.c

Loading...