Page MenuHomeFreeBSD
Differential D14380

Remove unused error return from API that cannot fail
ClosedPublic
Actions

Authored by cem on Feb 15 2018, 1:08 AM.
Tags
None
Referenced Files
F103563390: D14380.diff
Tue, Nov 26, 1:46 PM
Unknown Object (File)
Oct 23 2024, 7:38 PM
Unknown Object (File)
Oct 1 2024, 5:25 AM
Unknown Object (File)
Sep 18 2024, 6:02 AM
Unknown Object (File)
Sep 13 2024, 12:28 AM
Unknown Object (File)
Sep 8 2024, 1:41 PM
Unknown Object (File)
Sep 8 2024, 11:11 AM
Unknown Object (File)
Sep 7 2024, 7:57 PM
View All 30 Files
Subscribers
andrew
emaste
imp
kevans
rang_acm.org

Details

Reviewers
kib
delphij
jmg
Group Reviewers
O3: Kernel Random Numbers Generator(Owns No Changed Paths)
secteam
Commits
rS329878: Remove unused error return from API that cannot fail
Summary

No implementation of fpu_kern_enter() can fail, and it was causing needless
error checking boilerplate and confusion. Change the return code to void to
match reality.

Reported by: Lachlan Mcilroy <Lachlan.McIlroy AT isilon.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15056
Build 15154: arc lint + arc unit

Event Timeline

cem created this revision.Feb 15 2018, 1:08 AM
Owners added a reviewer: O3: Kernel Random Numbers Generator.Feb 15 2018, 1:08 AM
Herald added a reviewer: jmg. · View Herald TranscriptFeb 15 2018, 1:08 AM
Herald added a reviewer: jmg. · View Herald Transcript
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
Harbormaster completed remote builds in B15056: Diff 39328.Feb 15 2018, 1:08 AM
cem edited reviewers, added: secteam; removed: jmg.Feb 15 2018, 1:10 AM
Herald added a reviewer: jmg. · View Herald TranscriptFeb 15 2018, 1:10 AM
Herald added a reviewer: jmg. · View Herald Transcript
cem added a comment.Feb 15 2018, 7:29 AM

(Secteam blessing needed only for trivial dev/random change.)

rang_acm.org added a subscriber: rang_acm.org.Feb 15 2018, 5:39 PM
cem added a comment.Feb 20 2018, 8:41 PM

Ping @secteam, it's been about a week. This change is pretty trivially correct. I'm ready to "Approved by: secteam (timeout)". Thanks.

kevans added a subscriber: kevans.Feb 22 2018, 5:45 PM
delphij accepted this revision.Feb 23 2018, 7:30 AM

LGTM.

This revision is now accepted and ready to land.Feb 23 2018, 7:30 AM
Closed by commit rS329878: Remove unused error return from API that cannot fail (authored by cem). · Explain WhyFeb 23 2018, 8:15 PM
This revision was automatically updated to reflect the committed changes.
delphij added a comment.Mar 7 2018, 5:27 PM

You have not updated manual page, but the change looks otherwise fine to me.

cem added a comment.Mar 7 2018, 6:32 PM
In D14380#306839, @delphij wrote:

You have not updated manual page, but the change looks otherwise fine to me.

Good point. Fixed in r330619.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
8 lines
include/
2 lines
arm64/
arm64/
8 lines
include/
2 lines
crypto/
aesni/
10 lines
armv8/
11 lines
via/
8 lines
10 lines
5 lines
dev/
efidev/
8 lines
random/
17 lines
i386/
i386/
6 lines
include/
2 lines

Diff 39328

View Options

sys/amd64/amd64/fpu.c

Loading...
View Options

sys/amd64/include/fpu.h

Loading...
View Options

sys/arm64/arm64/vfp.c

Loading...
View Options

sys/arm64/include/vfp.h

Loading...
View Options

sys/crypto/aesni/aesni.c

Loading...
View Options

sys/crypto/armv8/armv8_crypto.c

Loading...
View Options

sys/crypto/via/padlock.c

Loading...
View Options

sys/crypto/via/padlock_cipher.c

Loading...
View Options

sys/crypto/via/padlock_hash.c

Loading...
View Options

sys/dev/efidev/efirt.c

Loading...
View Options

sys/dev/random/nehemiah.c

Loading...
View Options

sys/i386/i386/npx.c

Loading...
View Options

sys/i386/include/npx.h

Loading...