By convention .s is assembled by ${AS} while .S is assembled by ${CC}. Consistently use the compiler driver across all platforms, including those that do not have an in-tree standalone assembler, like arm64.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
this looks good to my eye.
A couple of caveats... Years ago I tried a cleanup of things rebuilding too much and ran into issues with assym.s being in modules not for assym.s itself, but because other things got generated as a side effect. Be wary of these and be sure to test on all architectures... I don't have notes from the time, so I can't be less vague...
Comment Actions
I wonder if we should rename it assym.inc instead, since we shouldn't be trying to assemble it with either as or Clang IAS.
sys/modules/hyperv/vmbus/Makefile | ||
---|---|---|
27 ↗ | (On Diff #40343) | Accidentally left behind by a rebase, will be removed. |