Page MenuHomeFreeBSD

Fix harmless locking bug in tcp_fastopen_check_cookie()
ClosedPublic

Authored by pkelsey on Jan 25 2018, 6:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 21 2024, 8:51 AM
Unknown Object (File)
Sep 28 2024, 11:21 AM
Unknown Object (File)
Sep 28 2024, 3:12 AM
Unknown Object (File)
Sep 19 2024, 10:48 AM
Unknown Object (File)
Sep 19 2024, 9:12 AM
Unknown Object (File)
Sep 9 2024, 3:07 AM
Unknown Object (File)
Sep 5 2024, 12:24 PM
Unknown Object (File)
Aug 24 2024, 8:18 AM
Subscribers

Details

Summary

The keylist lock was not being acquired early enough in tcp_fastopen_check_cookie().

This opens a potential race between keylist updates and generating a cookie to give to a client who has not supplied a valid one, which can result in the effective add time of a new key being slightly later that it would have been otherwise, as viewed by the client. There is no danger here, but it should be fixed.

Test Plan

Found by inspection.

Continued correct TFO server operation can be verified using the tools at https://people.freebsd.org/~pkelsey/tfo-tools/

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 14570