Remove rcmds from the base system.
ClosedPublic
Actions

Authored by jlh on Oct 3 2017, 9:26 AM.

Details

Reviewers

bapt
jhb
allanjude
brooks
bcr

Group Reviewers

Src Committers
manpages

Commits

rS324351: Remove rcmds.

Summary

We decided to remove rcmds in after stack-clash:
https://lists.freebsd.org/pipermail/freebsd-arch/2017-June/018239.html

They have been disabled for a couple of month now and there is a port
(net/bsdrcmds) which contains those tools.

This is the last step, which removes this code from FreeBSD base system.

Test Plan

buildworld

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11901
Build 12236: arc lint + arc unit

Event Timeline

jlh created this revision.Oct 3 2017, 9:26 AM

Herald added a reviewer: manpages. · View Herald TranscriptOct 3 2017, 9:26 AM

Herald added subscribers: emaste, imp, bdrewery. · View Herald Transcript

jlh edited reviewers, added: Src Committers; removed: manpages.Oct 3 2017, 9:27 AM

bapt accepted this revision.Oct 3 2017, 9:34 AM

This revision is now accepted and ready to land.Oct 3 2017, 9:34 AM

Small missing bit: etc/mtree/BSD.tests.dist contains a rcp directory. There are presumably missing ObsoleteFiles.inc entries for tests as well. Otherwise looks good to me.

This revision now requires changes to proceed.Oct 4 2017, 3:21 PM

Removed rcp from etc/mtree/BSD.tests.dist.

Herald added a reviewer: manpages. · View Herald TranscriptOct 5 2017, 9:32 AM

I've updated etc/mtree/BSD.tests.dists but I checked on various boxes I own, there's nothing related to rcp in /usr/tests/.

I'm confused as to how the rcp directory doesn't end up /usr/test/bin/, but can confirm that it doesn't in a VM with the test suite installed.

This revision is now accepted and ready to land.Oct 5 2017, 11:45 PM

cy mentioned this in D12607: Remove redundant pam_rhosts.Oct 6 2017, 3:08 PM

OK from manpages.

cy@, I checked pam_rhosts(8) and it's not obvious to me that it's strictly related to rcmds, although I can totally understand they were used alongside.

emaste mentioned this in D23335: retire rmt(8), the remote magtape protocol module.Jan 23 2020, 3:50 PM