Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
I'll update the .Dd when committing to have the date at the commit moment, and not at the submit moment :)
Other than the manpage, LGTM, I can fix the small manpage issues while committing.
Waiting on other review before committing
usr.sbin/sesutil/sesutil.8 | ||
---|---|---|
127 | Order is not right, shoult be sorted by category mandoc -Tlint sesutil.8 should help figuring out those |
This has been on my TODO list for a long time, thank you.
usr.sbin/sesutil/sesutil.c | ||
---|---|---|
344 | I don't think the q: is required here, but it doesn't hurt anything | |
351 | rpm should be marked up as units in libxo, like so: the 'w' will add a space before rpm, but it will be marked up as being the units for the previous value. | |
356 | units | |
363 | units |
Fixed bapt and allanjude comments.
I'm keeping .Dd as is because bapt seems to prefer to update it at commit time.
The 'q' in {q:led/locate} is necessary for the json output at least, without that we have : "led":locate instead of "led":"locate"
Looks good, thank you.
the requirement for q: for the 'locate' thing is likely a bug in libxo, and might need to be investigated separately.