Page MenuHomeFreeBSD

usr.sbin/sesutil: Introduce libxo support to sesutil(8)
ClosedPublic

Authored by nikita_elyzion.net on Jun 26 2017, 8:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 5:16 PM
Unknown Object (File)
Mar 24 2024, 4:23 AM
Unknown Object (File)
Dec 23 2023, 4:49 AM
Unknown Object (File)
Dec 21 2023, 10:57 PM
Unknown Object (File)
Dec 12 2023, 7:51 AM
Unknown Object (File)
Nov 10 2023, 8:17 PM
Unknown Object (File)
Nov 10 2023, 5:09 PM
Unknown Object (File)
Nov 9 2023, 3:03 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Please remember to update .Dd in the man page when committing.

You need to bump the .Dd in the man page for the content change.

bapt edited edge metadata.

I'll update the .Dd when committing to have the date at the commit moment, and not at the submit moment :)

Other than the manpage, LGTM, I can fix the small manpage issues while committing.

Waiting on other review before committing

usr.sbin/sesutil/sesutil.8
127

Order is not right, shoult be sorted by category

mandoc -Tlint sesutil.8 should help figuring out those

This revision is now accepted and ready to land.Jun 27 2017, 8:29 AM

This has been on my TODO list for a long time, thank you.

usr.sbin/sesutil/sesutil.c
344

I don't think the q: is required here, but it doesn't hurt anything

351

rpm should be marked up as units in libxo, like so:
sesutil_print(&title, "\t\t- Speed: {:speed/%d}{Uw:rpm}\n",

the 'w' will add a space before rpm, but it will be marked up as being the units for the previous value.

356

units

363

units

This revision now requires changes to proceed.Jun 27 2017, 3:30 PM
nikita_elyzion.net edited edge metadata.

Fixed bapt and allanjude comments.
I'm keeping .Dd as is because bapt seems to prefer to update it at commit time.

The 'q' in {q:led/locate} is necessary for the json output at least, without that we have : "led":locate instead of "led":"locate"

goatforit

Looks good, thank you.

the requirement for q: for the 'locate' thing is likely a bug in libxo, and might need to be investigated separately.

This revision is now accepted and ready to land.Jun 29 2017, 5:20 PM