Someone with a doc-commit bit, which excludes me :) -- please go ahead.

Who's going to commit this?

Looks good to me

apply comments from @tcberner for SDDM

Thanks for working on this update of the handbook chapter.
Can you run textproc/igor over your changes and fix the issues that are reported (alignment of sections, tabs vs. spaces, etc.)?

Re-fixing.

Actually, I was in doubt about that but portlint said "looks fine". :)

I think I was doing it wrong just bringing the diff of the later modified files instead of everything related.

Updating "LICENSE_FILE" to reflect the current absence of the doc folder.

• I downgraded from the v1.0.1 (what is dead now) to v1.0 since I could not find a way to use the "COPYTREE" builtin find feature to avoid directories but just its files. The v1.0 does not have the doc directory.

Submitting a new diff.

Removing the x11-fonts/ohsnap update from the diff, what was accidentally included.

Closed by rP417968

Closed by rP417968

Committed in r416916:
https://svnweb.freebsd.org/ports?view=revision&revision=416916

Oh, and if the maintainer is ok with it, I'm ok too.

As suggested by Tobias, INSTALLS_ICONS=yes is not required as this is a QT
application (not GTK/GNOME).

In D6843#143671, @woodsb02 wrote:

I have decided to go with those options which are enabled by default in the
CMakeLists.txt file. This adds the following options to the default build:

I'm not quite sure still whether "INSTALLS_ICONS" is actually needed.

As per comment from mat, make sure that options which are enabled by default
are sufficient such that the vast majority of people will not need to rebuild
with more options enabled to be able to use it.

Looks good, as with all ports with many options, but very few enabled by default, make sure that the vast majority of people will not need to rebuild with more options enabled to be able to use it.

ship it!

Closing now that PyQt5 has landed.

Accept revision for it to be closed.