Page MenuHomeFreeBSD

x11-wm/plasma5-kwin: add option PIPEWIRE to allow build without pipewire
ClosedPublic

Authored by vvd on Sep 15 2023, 1:43 AM.
Tags
Referenced Files
Unknown Object (File)
Fri, Apr 26, 7:17 PM
Unknown Object (File)
Fri, Apr 26, 7:17 PM
Unknown Object (File)
Fri, Apr 26, 7:17 PM
Unknown Object (File)
Fri, Apr 26, 3:32 PM
Unknown Object (File)
Fri, Apr 26, 1:45 AM
Unknown Object (File)
Mar 13 2024, 12:23 PM
Unknown Object (File)
Mar 13 2024, 12:20 PM
Unknown Object (File)
Mar 10 2024, 6:18 AM
Subscribers
None

Details

Summary

Add option PIPEWIRE to allow build without pipewire.
Default ON - same as was before.

Tested on 13.2 amd64 in poudriere and live system.

P.S. Without patches it build and work fine if pipewire is not installed in system.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vvd requested review of this revision.Sep 15 2023, 1:43 AM
vvd created this revision.

Can't this be done via CMAKE_DISABLE_FIND_PACKAGE... too?

Can't this be done via CMAKE_DISABLE_FIND_PACKAGE... too?

Tried:

PEWIRE_CMAKE_BOOL_OFF= CMAKE_DISABLE_FIND_PACKAGE_PipeWire CMAKE_DISABLE_FIND_PACKAGE_libpipewire CMAKE_DISABLE_FIND_PACKAGE_libpipewire-0.3

But it still search libpipewire during make configure:

-- Checking for module 'libpipewire-0.3>=0.3.29'
--   Package 'libpipewire-0.3', required by 'virtual:world', not found

So plasma5-kwin will grab libpipewire silently during build if it installed even if user turn off option PIPEWIRE.

Does just passing -DPipeWire_FOUND=NO to CMake work?

Does just passing -DPipeWire_FOUND=NO to CMake work?

Added:
CMAKE_ARGS= -DPipeWire_FOUND=NO
make configure:

<cut>
-- Checking for module 'libpipewire-0.3>=0.3.29'
--   Package 'libpipewire-0.3', required by 'virtual:world', not found
<cut>
-- The following features have been disabled:

 * SCHED_RESET_ON_FORK, Required for running kwin_wayland with real-time scheduling
 * PipeWire, Required for Wayland screencasting
<cut>

If the -DPipeWire_FOUND=NO approach worked, update the diff

If the -DPipeWire_FOUND=NO approach worked, update the diff

Not worked - it still search for pipewire and grab it silently if find.

Patch for CMakeLists.txt is for prevent silently grab pipewire if in installed, but user don't want use it (turned off option PIPEWIRE).

This revision is now accepted and ready to land.Jan 9 2024, 11:59 AM