User Details
- User Since
- Jan 13 2015, 10:58 PM (560 w, 6 d)
Yesterday
Sun, Oct 12
Looks ok to me. I'll leave min vs MIN up to you.
Fri, Oct 10
Looks ok to me. You can decide whether or not to add the
KASSERT for x_op != XDR_FREE?
Wed, Oct 8
Looks fine to me. Feel free to ignore the minor comments.
Tue, Oct 7
Looks fine to me. Is there somewhere that we can stick
examples for krb5.conf, kdc.conf and kadm5.acl?
Sun, Oct 5
Wed, Oct 1
Sun, Sep 28
Sat, Sep 27
Just fyi. Unless I hear otherwise I am going to commit
this patch Monday, so that it can be MFC'd to stable/15.
It stops rpcbind from crashing. If others don't like the
choice of address string for netlink, that can be changed
later.
Thu, Sep 25
Sat, Sep 20
Sep 9 2025
Sep 7 2025
Sep 4 2025
Sep 3 2025
Sep 2 2025
I made a few comments, but stopped there.
You seem to be confusing the 16 which is
a hardwired RPC constant with what happens
to be defined elsewhere.
(Even if XU_NGROUPS == 16 there is nothing
stopping someone from changing that someday.)
Aug 29 2025
I'll admit I do not understand what your recent gid
changes are, so I will resign as a reviewer.
Aug 27 2025
Looks fine to me.
Aug 26 2025
Aug 24 2025
Aug 23 2025
Aug 22 2025
Made changes suggested by kib@.
Aug 18 2025
Aug 17 2025
Thanks for the feedback. I'm off doing other things for
a few days, but will update this next weekend.
Aug 16 2025
Aug 15 2025
Aug 13 2025
Aug 12 2025
Reworded to mention copy_file_range.
Aug 11 2025
Looks good to me. Thanks for doing this, rick
Aug 10 2025
Aug 9 2025
The bug is in vn_copy_file_range() and not in the ZFS function.
For the case where the offset arguments are being passed in,
it doesn't update them properly.
I'll work on it, but it is not a bug in the ZFS code.
Aug 8 2025
Thanks for doing this. I was going to start looking at this
to-day, but I'm glad to see you've done it.
Aug 7 2025
Added check to fuse_copy_file_range() as pointed
out by asomers@.