Page MenuHomeFreeBSD
People rmacklem

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (574 w, 12 h)

Recent Activity
View All

Today

rmacklem requested review of D54679: linux_file.c: Fix handling of NFS getdents() emulation.
Wed, Jan 14, 12:49 AM

Fri, Jan 9

rmacklem committed rGa6d57f312f18: nfsd: Fix handling of hidden/system during Open/Create (authored by rmacklem).
nfsd: Fix handling of hidden/system during Open/Create
Fri, Jan 9, 12:34 AM

Wed, Dec 31

rmacklem committed rGe8567de718a4: nfscl: Fix handling of POSIX draft default ACLs (authored by rmacklem).
nfscl: Fix handling of POSIX draft default ACLs
Wed, Dec 31, 2:45 AM
rmacklem committed rGab5ec8ccbcf0: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup (authored by rmacklem).
nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup
Wed, Dec 31, 1:33 AM
rmacklem committed rG785d429c2b93: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup (authored by rmacklem).
nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup
Wed, Dec 31, 1:25 AM

Wed, Dec 24

rmacklem committed rG4f184fd35d81: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup (authored by rmacklem).
nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup
Wed, Dec 24, 4:31 PM
rmacklem closed D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.
Wed, Dec 24, 4:31 PM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Did formatting changes suggested by Ziaee.

Wed, Dec 24, 3:41 PM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Made formatting changes suggested by kib@.

Wed, Dec 24, 3:11 AM
rmacklem added a comment to D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Updated as suggested by kib@.

Wed, Dec 24, 1:28 AM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Add words similar to what was in the email,
as requested by kib@.

Wed, Dec 24, 1:26 AM

Tue, Dec 23

rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Add ziaee@'s suggested change.

Tue, Dec 23, 10:58 PM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Added a short description of the rc.conf
variables, as suggested by kib@.

Tue, Dec 23, 10:53 PM
rmacklem committed rGb94e4c7037b0: RELNOTES: Add an entry for 8e3fd450cc53 and friends (authored by rmacklem).
RELNOTES: Add an entry for 8e3fd450cc53 and friends
Tue, Dec 23, 2:54 AM

Mon, Dec 22

rmacklem committed rG60eb371c2b9a: UPDATING: Add an entry for commit 9f49f436a9ec (authored by rmacklem).
UPDATING: Add an entry for commit 9f49f436a9ec
Mon, Dec 22, 11:31 PM
rmacklem committed rGe35191ccf3b3: nfs: Add some support for POSIX draft ACLs (authored by rmacklem).
nfs: Add some support for POSIX draft ACLs
Mon, Dec 22, 11:25 PM
rmacklem committed rG9f49f436a9ec: nfs: Add some support for POSIX draft ACLs (authored by rmacklem).
nfs: Add some support for POSIX draft ACLs
Mon, Dec 22, 9:53 PM
rmacklem committed rG0e724de9ed6f: nfscl: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscl: Add some support for POSIX draft ACLs
Mon, Dec 22, 2:07 AM
rmacklem committed rG949cff4dceff: nfscommon: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscommon: Add some support for POSIX draft ACLs
Mon, Dec 22, 1:09 AM
rmacklem committed rG8e3fd450cc53: nfsd: Add some support for POSIX draft ACLs (authored by rmacklem).
nfsd: Add some support for POSIX draft ACLs
Mon, Dec 22, 12:11 AM

Sun, Dec 21

rmacklem committed rGa35bbd5d9f5f: nfscommon: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscommon: Add some support for POSIX draft ACLs
Sun, Dec 21, 10:30 PM

Thu, Dec 18

rmacklem requested review of D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.
Thu, Dec 18, 12:56 AM

Dec 10 2025

rmacklem committed rGc8180893d7fe: nfs_nfsdstate.c: Add sanity checks for lock stateids (authored by rmacklem).
nfs_nfsdstate.c: Add sanity checks for lock stateids
Dec 10 2025, 3:42 AM
rmacklem committed rGffd47a4bc671: nfs_nfsdstate.c: Add sanity checks for lock stateids (authored by rmacklem).
nfs_nfsdstate.c: Add sanity checks for lock stateids
Dec 10 2025, 3:38 AM

Dec 6 2025

rmacklem closed D45814: Allow ZFS sharenfs to generate multiple export(5) lines.

Commit to OpenZFS was done in August 2024.

Dec 6 2025, 3:08 PM

Nov 27 2025

rmacklem accepted D53949: kgssapi: Remove broken MOD_UNLOAD code.

Looks fine to me.

Nov 27 2025, 9:12 PM

Nov 26 2025

rmacklem committed rGaa1cf240887d: nfs_nfsdstate.c: Add sanity checks for lock stateids (authored by rmacklem).
nfs_nfsdstate.c: Add sanity checks for lock stateids
Nov 26 2025, 7:22 PM

Nov 23 2025

rmacklem committed rGbac4d3fd6cf8: UPDATING: Add an entry for f27afc476551 (authored by rmacklem).
UPDATING: Add an entry for f27afc476551
Nov 23 2025, 8:42 PM
rmacklem committed rG33d15245f9be: param.h: Bump __FreeBSD_version to 1500502 (authored by rmacklem).
param.h: Bump __FreeBSD_version to 1500502
Nov 23 2025, 8:36 PM
rmacklem committed rGf27afc476551: nfs: Add support for the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
nfs: Add support for the new _PC_CASE_INSENSITIVE name
Nov 23 2025, 8:29 PM
rmacklem committed rG52159dd73fe7: pathconf.2: Document the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
pathconf.2: Document the new _PC_CASE_INSENSITIVE name
Nov 23 2025, 8:26 PM
rmacklem committed rGd5335bdee715: nfs_clvfsops.c: Allow long directory mount paths (authored by rmacklem).
nfs_clvfsops.c: Allow long directory mount paths
Nov 23 2025, 1:26 PM

Nov 22 2025

rmacklem committed rGa36c71acb6e9: nfs_commonsubs.c: Get rid of variable used as a constant (authored by rmacklem).
nfs_commonsubs.c: Get rid of variable used as a constant
Nov 22 2025, 11:55 PM

Nov 8 2025

rmacklem committed rGfdd30e0670d1: pathconf: Define a new name called _PC_CASE_INSENSITIVE (authored by rmacklem).
pathconf: Define a new name called _PC_CASE_INSENSITIVE
Nov 8 2025, 1:17 AM

Nov 5 2025

rmacklem committed rG3a64c667f16f: nfs: Add support for the NFSv4 archive attribute (authored by rmacklem).
nfs: Add support for the NFSv4 archive attribute
Nov 5 2025, 1:34 AM

Nov 2 2025

rmacklem committed rG088ced14a69b: UPDATING: Add an entry for e5aa60d06958 (authored by rmacklem).
UPDATING: Add an entry for e5aa60d06958
Nov 2 2025, 11:23 PM
rmacklem committed rGb3de3c2dea57: param.h: Bump __FreeBSD_version for e5aa60d06958 (authored by rmacklem).
param.h: Bump __FreeBSD_version for e5aa60d06958
Nov 2 2025, 11:19 PM
rmacklem committed rGe5aa60d06958: nfs: Add support for the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
nfs: Add support for the new _PC_CASE_INSENSITIVE name
Nov 2 2025, 8:43 PM
rmacklem committed rG26a9d67f6fbb: nfscommon: Update the nfs_bigreply array (authored by ehem_freebsd_m5p.com).
nfscommon: Update the nfs_bigreply array
Nov 2 2025, 8:25 PM
rmacklem accepted D53536: nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2).
Nov 2 2025, 3:40 PM

Nov 1 2025

rmacklem committed rGb473bb274cef: pathconf.2: Document the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
pathconf.2: Document the new _PC_CASE_INSENSITIVE name
Nov 1 2025, 10:24 PM
rmacklem closed D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.
Nov 1 2025, 10:24 PM

Oct 31 2025

rmacklem updated the diff for D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.

Reword the line to say "performs case insensitive lookups,"
as suggested by kib@.

Oct 31 2025, 11:25 PM
rmacklem added inline comments to D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.
Oct 31 2025, 10:50 PM
rmacklem added inline comments to D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.
Oct 31 2025, 10:45 PM
rmacklem requested review of D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.
Oct 31 2025, 9:15 PM
rmacklem committed rG7a5208998bc9: nfs_clrpcops.c: NFSM_DISSECT() reply for each dir separately (authored by rmacklem).
nfs_clrpcops.c: NFSM_DISSECT() reply for each dir separately
Oct 31 2025, 1:16 AM
rmacklem committed rGc02fa3f085c6: nfs_clrpcops.c: NFSM_DISSECT() reply for each dir separately (authored by rmacklem).
nfs_clrpcops.c: NFSM_DISSECT() reply for each dir separately
Oct 31 2025, 1:06 AM

Oct 30 2025

rmacklem committed rG9a4da735ca97: nfs_commonsubs.c: Add a sanity check for nid_ngroup (authored by rmacklem).
nfs_commonsubs.c: Add a sanity check for nid_ngroup
Oct 30 2025, 2:26 PM
rmacklem committed rG83a0732a4cfe: nfs_commonsubs.c: Add a sanity check for nid_ngroup (authored by rmacklem).
nfs_commonsubs.c: Add a sanity check for nid_ngroup
Oct 30 2025, 2:06 PM
rmacklem committed rGf262601ebaff: nfs_clrpcops.c: Check for too large a write reply (authored by rmacklem).
nfs_clrpcops.c: Check for too large a write reply
Oct 30 2025, 1:24 AM
rmacklem committed rG4f7bd8c77981: nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s (authored by rmacklem).
nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s
Oct 30 2025, 1:23 AM
rmacklem committed rG1d37ea5e58e8: nfs_clrpcops.c: Add sanity checks for the slot cnts (authored by rmacklem).
nfs_clrpcops.c: Add sanity checks for the slot cnts
Oct 30 2025, 1:23 AM
rmacklem committed rG7c9d801ed278: nfs_nfsdserv.c: Add a sanity check for layout commit cnt (authored by rmacklem).
nfs_nfsdserv.c: Add a sanity check for layout commit cnt
Oct 30 2025, 1:22 AM
rmacklem committed rGb5b6ddfc9981: nfs_clrpcops.c: Check for too large a write reply (authored by rmacklem).
nfs_clrpcops.c: Check for too large a write reply
Oct 30 2025, 1:05 AM
rmacklem committed rG609c4eb70afe: nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s (authored by rmacklem).
nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s
Oct 30 2025, 1:04 AM
rmacklem committed rG14148591b951: nfs_clrpcops.c: Add sanity checks for the slot cnts (authored by rmacklem).
nfs_clrpcops.c: Add sanity checks for the slot cnts
Oct 30 2025, 1:02 AM
rmacklem committed rGc69e0be70f46: nfs_nfsdserv.c: Add a sanity check for layout commit cnt (authored by rmacklem).
nfs_nfsdserv.c: Add a sanity check for layout commit cnt
Oct 30 2025, 1:01 AM

Oct 29 2025

rmacklem committed rG8d5a88ac95b2: nfs_clvfsops.c: Allow long directory mount paths (authored by rmacklem).
nfs_clvfsops.c: Allow long directory mount paths
Oct 29 2025, 9:45 PM
rmacklem committed rG73551cd6eac2: nfs_commonsubs.c: Get rid of variable used as a constant (authored by rmacklem).
nfs_commonsubs.c: Get rid of variable used as a constant
Oct 29 2025, 12:31 AM

Oct 28 2025

rmacklem committed rG9d13c87afdb3: nfs_clrpcops.c: NFSM_DISSECT() reply for each dir separately (authored by rmacklem).
nfs_clrpcops.c: NFSM_DISSECT() reply for each dir separately
Oct 28 2025, 9:35 PM
rmacklem committed rG4672adcea4cf: nfs_commonsubs.c: Add a sanity check for nid_ngroup (authored by rmacklem).
nfs_commonsubs.c: Add a sanity check for nid_ngroup
Oct 28 2025, 2:48 PM
rmacklem closed D53389: nfs_commonsubs.c: Add a sanity check for nid_ngroup.
Oct 28 2025, 2:47 PM
rmacklem requested review of D53389: nfs_commonsubs.c: Add a sanity check for nid_ngroup.
Oct 28 2025, 12:29 AM

Oct 27 2025

rmacklem committed rG2c82cdd2e29f: nfs_clrpcops.c: Check for too large a write reply (authored by rmacklem).
nfs_clrpcops.c: Check for too large a write reply
Oct 27 2025, 2:53 PM
rmacklem closed D53368: nfs_clrpcops.c: Check for too large a write reply.
Oct 27 2025, 2:52 PM
rmacklem committed rGb9e6206f5933: nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s (authored by rmacklem).
nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s
Oct 27 2025, 2:46 PM
rmacklem closed D53367: nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s.
Oct 27 2025, 2:46 PM
rmacklem committed rG3053b2a3dcab: nfs_clrpcops.c: Add sanity checks for the slot cnts (authored by rmacklem).
nfs_clrpcops.c: Add sanity checks for the slot cnts
Oct 27 2025, 2:39 PM
rmacklem closed D53363: nfs_clrpcops.c: Add sanity checks for the slot cnt.
Oct 27 2025, 2:38 PM
rmacklem committed rG1a679fb90796: nfs_nfsdserv.c: Add a sanity check for layout commit cnt (authored by rmacklem).
nfs_nfsdserv.c: Add a sanity check for layout commit cnt
Oct 27 2025, 2:28 PM
rmacklem closed D53354: nfs_nfsdserv.c: Add sanity check for layout commit cnt.
Oct 27 2025, 2:28 PM
rmacklem added a comment to D53368: nfs_clrpcops.c: Check for too large a write reply.
In D53368#1218929, @markj wrote:

There is a similar pattern in nfsrpc_writeds(). Does that need to be fixed too?

Oct 27 2025, 2:08 PM
rmacklem updated the diff for D53368: nfs_clrpcops.c: Check for too large a write reply.

Add the same fix to nfsrpc_writeds().

Oct 27 2025, 2:07 PM
rmacklem added inline comments to D53367: nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s.
Oct 27 2025, 1:55 PM
rmacklem added inline comments to D53354: nfs_nfsdserv.c: Add sanity check for layout commit cnt.
Oct 27 2025, 1:39 PM

Oct 26 2025

rmacklem requested review of D53368: nfs_clrpcops.c: Check for too large a write reply.
Oct 26 2025, 8:52 PM
rmacklem requested review of D53367: nfs_clrpcops.c: Fix two possible large NFSM_DISSECT()s.
Oct 26 2025, 8:48 PM
rmacklem added a comment to D53361: write.2: explain the atomicity guarantees of the writes.

Oh, and it needs the date to be updated.

Oct 26 2025, 3:30 PM
rmacklem accepted D53361: write.2: explain the atomicity guarantees of the writes.
Oct 26 2025, 3:15 PM
rmacklem requested review of D53363: nfs_clrpcops.c: Add sanity checks for the slot cnt.
Oct 26 2025, 3:05 PM

Oct 25 2025

rmacklem committed rGd6864221d884: pathconf: Define a new name called _PC_CASE_INSENSITIVE (authored by rmacklem).
pathconf: Define a new name called _PC_CASE_INSENSITIVE
Oct 25 2025, 8:42 PM
rmacklem closed D53349: pathconf: Define a new name called _PC_CASE_INSENSITIVE.
Oct 25 2025, 8:41 PM
rmacklem requested review of D53354: nfs_nfsdserv.c: Add sanity check for layout commit cnt.
Oct 25 2025, 8:17 PM
rmacklem requested review of D53349: pathconf: Define a new name called _PC_CASE_INSENSITIVE.
Oct 25 2025, 1:55 AM

Oct 22 2025

rmacklem committed rG3b6d4c6cdffd: nfs: Add support for the NFSv4 archive attribute (authored by rmacklem).
nfs: Add support for the NFSv4 archive attribute
Oct 22 2025, 9:20 PM

Oct 19 2025

rmacklem committed rGa6369fb9e4b4: nfscommon: Update the nfs_bigreply array (authored by ehem_freebsd_m5p.com).
nfscommon: Update the nfs_bigreply array
Oct 19 2025, 8:34 PM

Oct 13 2025

rmacklem accepted D52961: sys/rpc: Define AUTH_SYS_MAX_{GROUPS,HOSTNAME}.
Oct 13 2025, 10:41 PM
rmacklem accepted D52963: sys/rpc: UNIX auth: Use AUTH_SYS_MAX_{GROUPS,HOSTNAME} as limits (2/2).
Oct 13 2025, 10:40 PM
rmacklem committed rG4fc1e7546f12: RELNOTES: Fix a typo in the 5000d023a446 entry (authored by rmacklem).
RELNOTES: Fix a typo in the 5000d023a446 entry
Oct 13 2025, 10:08 PM
rmacklem added inline comments to D52962: sys/rpc: UNIX auth: Use AUTH_SYS_MAX_{GROUPS,HOSTNAME} as limits (1/2).
Oct 13 2025, 1:57 PM
rmacklem committed rGa7fc4e326c8d: rpc.tlsservd.c: Pin max threads at 1 for now (authored by rmacklem).
rpc.tlsservd.c: Pin max threads at 1 for now
Oct 13 2025, 12:33 AM

Oct 12 2025

rmacklem accepted D52960: sys/rpc: UNIX auth: Fix OOB accesses, notably writes on decode.

Looks ok to me. I'll leave min vs MIN up to you.

Oct 12 2025, 11:50 PM
rmacklem committed rG1129bf441e99: RELNOTES: Fix up the entry for 5000d023a446 (authored by rmacklem).
RELNOTES: Fix up the entry for 5000d023a446
Oct 12 2025, 12:48 AM
rmacklem committed rG9504e956c508: RELNOTES: Add an entry for commit 5000d023a446 (authored by rmacklem).
RELNOTES: Add an entry for commit 5000d023a446
Oct 12 2025, 12:41 AM

Oct 10 2025

rmacklem committed rG7a289fe3cd5c: rpc.tlsservd.c: Pin max threads at 1 for now (authored by rmacklem).
rpc.tlsservd.c: Pin max threads at 1 for now
Oct 10 2025, 11:33 PM
rmacklem accepted D52962: sys/rpc: UNIX auth: Use AUTH_SYS_MAX_{GROUPS,HOSTNAME} as limits (1/2).

Looks ok to me. You can decide whether or not to add the
KASSERT for x_op != XDR_FREE?

Oct 10 2025, 10:29 PM

Oct 8 2025

rmacklem accepted D52964: sys/rpc: UNIX auth: Fix OOB reads on too short message.

Looks fine to me. Feel free to ignore the minor comments.

Oct 8 2025, 2:04 PM
rmacklem committed rG23fbea8cf2f3: kadmin.8: Document the new dump -f flag (authored by rmacklem).
kadmin.8: Document the new dump -f flag
Oct 8 2025, 1:54 AM
rmacklem committed rG9fd3b28d4e0d: heimdal-kadmin: Add support for the -f dump option (authored by rmacklem).
heimdal-kadmin: Add support for the -f dump option
Oct 8 2025, 1:53 AM