Page MenuHomeFreeBSD

rmacklem (Rick Macklem)
User

Projects

User Details

User Since
Jan 13 2015, 10:58 PM (582 w, 2 d)

Recent Activity

Sun, Mar 8

rmacklem committed rG016570c4463d: nfs_clstate.c: Handle the same stateid case correctly (authored by rmacklem).
nfs_clstate.c: Handle the same stateid case correctly
Sun, Mar 8, 10:12 PM

Sat, Mar 7

rmacklem accepted D55681: vn_delayed_setsize(): post-commit review' changes.

Thanks for the atomic_load_short explanation.

Sat, Mar 7, 2:47 PM
rmacklem added inline comments to D55681: vn_delayed_setsize(): post-commit review' changes.
Sat, Mar 7, 2:32 AM

Fri, Mar 6

rmacklem accepted D55681: vn_delayed_setsize(): post-commit review' changes.
Fri, Mar 6, 1:18 AM
rmacklem accepted D55681: vn_delayed_setsize(): post-commit review' changes.
Fri, Mar 6, 1:09 AM

Mon, Mar 2

rmacklem accepted D55595: vn_delayed_setsize().

It all looks good to me, although I won't claim to
understand all the required semantics in
vn_lock_delayed_setsize().

Mon, Mar 2, 10:30 PM

Tue, Feb 24

rmacklem committed rG5153ca331b44: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated (authored by rmacklem).
vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated
Tue, Feb 24, 10:08 PM
rmacklem committed rG7ae432e6fbb2: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated (authored by rmacklem).
vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated
Tue, Feb 24, 1:45 AM

Sat, Feb 21

rmacklem committed rG86a6407d028d: linux_file.c: Fix handling of NFS getdents() emulation (authored by rmacklem).
linux_file.c: Fix handling of NFS getdents() emulation
Sat, Feb 21, 5:05 PM

Tue, Feb 17

rmacklem committed rG935cf3284f52: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated (authored by rmacklem).
vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated
Tue, Feb 17, 11:01 PM
rmacklem closed D55318: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated.
Tue, Feb 17, 11:01 PM
rmacklem updated the diff for D55318: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated.

Changed the variable name has_export to only_export,
as suggested by kib@. I also changed the comment
related to this vaiable.

Tue, Feb 17, 2:16 PM
rmacklem accepted D55286: find: add -xattr and -xttrname.
Tue, Feb 17, 1:43 PM
rmacklem accepted D55323: <sys/extattr.h>: use designated initializers for EXTATTR_NAMESPACE_NAMES.

Thanks for doing this. I think it does clarify
the relationship between EXTATTR_NAMESPACE_EMPTY
and EXTATTR_NAMESPACE_EMPTY_STRING for your
other patch.

Tue, Feb 17, 1:41 PM
rmacklem requested review of D55318: vfs_mount.c: Don't call VFS_MOUNT() if only exports are being updated.
Tue, Feb 17, 12:47 AM

Mon, Feb 16

rmacklem accepted D55302: open.2: stop making impression that fd must be directory.
Mon, Feb 16, 1:58 PM
rmacklem committed rGb45447c6cc21: runat: Add -h to manipulate a symlink's named attribute dir (authored by rmacklem).
runat: Add -h to manipulate a symlink's named attribute dir
Mon, Feb 16, 12:52 AM

Sat, Feb 14

rmacklem accepted D55286: find: add -xattr and -xttrname.

It looks ok to me, although I do not know
anything about the atf testing part.

Sat, Feb 14, 10:50 PM

Thu, Feb 12

rmacklem resigned from D55247: rpc: Improve socket locking in svc_vc_accept().

I probably should resign, since I don't understand
when/if ACCEPT4_INHERIT might be specified
as an argument for solisten_dequeue()?

Thu, Feb 12, 1:26 AM

Feb 11 2026

rmacklem added inline comments to D55203: svc_vc.c: Add support for an xp_extpg boolean.
Feb 11 2026, 2:16 AM
rmacklem accepted D55247: rpc: Improve socket locking in svc_vc_accept().

This looks fine to me.
I will note that the NFS server never uses svc_vc_accept().
(The accept() is done in userspace.)

Feb 11 2026, 12:55 AM
rmacklem added inline comments to D55203: svc_vc.c: Add support for an xp_extpg boolean.
Feb 11 2026, 12:37 AM
rmacklem updated the diff for D55203: svc_vc.c: Add support for an xp_extpg boolean.

Added NET_EPOCH_ENTER()/NET_EPOCH_EXIT() and
cleaned up the code a bit.

Feb 11 2026, 12:35 AM

Feb 10 2026

rmacklem added inline comments to D55203: svc_vc.c: Add support for an xp_extpg boolean.
Feb 10 2026, 11:15 PM

Feb 9 2026

rmacklem requested review of D55203: svc_vc.c: Add support for an xp_extpg boolean.
Feb 9 2026, 10:58 PM

Feb 7 2026

rmacklem committed rG110f2567cb51: linux_file.c: Fix handling of NFS getdents() emulation (authored by rmacklem).
linux_file.c: Fix handling of NFS getdents() emulation
Feb 7 2026, 10:15 PM
rmacklem closed D54679: linux_file.c: Fix handling of NFS getdents() emulation.
Feb 7 2026, 10:15 PM

Feb 5 2026

rmacklem committed rG79b28bc8d1b4: nfscl: Fix the build (authored by rmacklem).
nfscl: Fix the build
Feb 5 2026, 7:57 PM
rmacklem committed rG406c98d2ca1d: nfscl: Fix handling of case insensitive file systems (authored by rmacklem).
nfscl: Fix handling of case insensitive file systems
Feb 5 2026, 7:56 PM
rmacklem committed rG2e665ce547b5: nfsd: Fix handling of attributes during Open/Create/Exclusive_41 (authored by rmacklem).
nfsd: Fix handling of attributes during Open/Create/Exclusive_41
Feb 5 2026, 7:54 PM
rmacklem committed rG144c1eda3973: nfs: Add some support for POSIX draft ACLs (authored by rmacklem).
nfs: Add some support for POSIX draft ACLs
Feb 5 2026, 1:30 AM
rmacklem committed rGdccf41dd1834: nfs: Add some support for POSIX draft ACLs (authored by rmacklem).
nfs: Add some support for POSIX draft ACLs
Feb 5 2026, 1:29 AM
rmacklem committed rGd842c511d84c: nfscl: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscl: Add some support for POSIX draft ACLs
Feb 5 2026, 1:28 AM
rmacklem committed rG2eddaeb3e505: nfscommon: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscommon: Add some support for POSIX draft ACLs
Feb 5 2026, 1:27 AM
rmacklem committed rG20bfa56c514b: nfsd: Add some support for POSIX draft ACLs (authored by rmacklem).
nfsd: Add some support for POSIX draft ACLs
Feb 5 2026, 1:26 AM
rmacklem committed rGe00ce2fe6536: nfscommon: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscommon: Add some support for POSIX draft ACLs
Feb 5 2026, 1:23 AM

Feb 2 2026

rmacklem committed rG4bfb7cfb70e6: runat: Add -h to manipulate a symlink's named attribute dir (authored by rmacklem).
runat: Add -h to manipulate a symlink's named attribute dir
Feb 2 2026, 10:41 PM
rmacklem closed D55023: runat: Add -h to manipulate a symbolic link's named attribute dir.
Feb 2 2026, 10:40 PM

Feb 1 2026

rmacklem added inline comments to D55023: runat: Add -h to manipulate a symbolic link's named attribute dir.
Feb 1 2026, 10:08 PM
rmacklem updated the diff for D55023: runat: Add -h to manipulate a symbolic link's named attribute dir.

As suggested by jilles@ and to be more consistent
with rmextattr(8), change "-S/--symlink" to "-h/--nofollow".

Feb 1 2026, 10:05 PM
rmacklem retitled D55023: runat: Add -h to manipulate a symbolic link's named attribute dir from runat: Add -S to manipulate a symbolic link's named attribute dir to runat: Add -h to manipulate a symbolic link's named attribute dir.
Feb 1 2026, 10:01 PM

Jan 31 2026

rmacklem added a comment to D55023: runat: Add -h to manipulate a symbolic link's named attribute dir.
In D55023#1257715, @kib wrote:

BTW, chmod(1), chflags(1), ls(1) and find(1) consistently use -P for the same functionality. ls(1) does not fail if the argument is not a symbolic link.

I can switch it to "-P". It was Lionel Cons that suggested "-S".

Jan 31 2026, 10:28 PM
rmacklem added a comment to D55023: runat: Add -h to manipulate a symbolic link's named attribute dir.
In D55023#1257715, @kib wrote:

BTW, chmod(1), chflags(1), ls(1) and find(1) consistently use -P for the same functionality. ls(1) does not fail if the argument is not a symbolic link.

Jan 31 2026, 10:09 PM
rmacklem requested review of D55023: runat: Add -h to manipulate a symbolic link's named attribute dir.
Jan 31 2026, 9:20 PM
rmacklem accepted D54933: heimdal: Pass the correct pointer to realloc when growing a string buffer.
Jan 31 2026, 9:07 PM
rmacklem abandoned D54994: runat: Add -S for handling the named attribute dir for a symlink.

I'm going to redo this using getopt().
I didn't bother for one option, but I
now think that's silly.

Jan 31 2026, 5:06 AM
rmacklem requested review of D54994: runat: Add -S for handling the named attribute dir for a symlink.
Jan 31 2026, 4:47 AM
rmacklem accepted D54931: heimdal: Add missing function prototypes.

Looks fine to me. I'll admit I didn't bother to look
to see if/where they get called.

Jan 31 2026, 4:41 AM
rmacklem accepted D54932: heimdal: Pass the correct pointer to free in an error case.
Jan 31 2026, 4:39 AM
rmacklem accepted D54933: heimdal: Pass the correct pointer to realloc when growing a string buffer.

I know nothing about gcc flags, but if it gets
rid of the error, that seems fine to me.

Jan 31 2026, 4:38 AM

Jan 24 2026

rmacklem committed rG6fd7e55c9413: nfsd: Fix handling of hidden/system during Open/Create (authored by rmacklem).
nfsd: Fix handling of hidden/system during Open/Create
Jan 24 2026, 12:48 AM

Jan 21 2026

rmacklem committed rG053449fa5c6c: nfscl: Fix the build (authored by rmacklem).
nfscl: Fix the build
Jan 21 2026, 1:35 AM
rmacklem committed rGf2155a6fb568: nfscl: Fix handling of case insensitive file systems (authored by rmacklem).
nfscl: Fix handling of case insensitive file systems
Jan 21 2026, 12:24 AM

Jan 15 2026

rmacklem committed rG4fc11c92d324: nfsd: Fix handling of attributes during Open/Create/Exclusive_41 (authored by rmacklem).
nfsd: Fix handling of attributes during Open/Create/Exclusive_41
Jan 15 2026, 11:31 PM
rmacklem updated the diff for D54679: linux_file.c: Fix handling of NFS getdents() emulation.

Do roundup2() after the min(args->count, MAXBSIZE)
as suggsted by markj@.

Jan 15 2026, 12:13 AM

Jan 14 2026

rmacklem requested review of D54679: linux_file.c: Fix handling of NFS getdents() emulation.
Jan 14 2026, 12:49 AM

Jan 9 2026

rmacklem committed rGa6d57f312f18: nfsd: Fix handling of hidden/system during Open/Create (authored by rmacklem).
nfsd: Fix handling of hidden/system during Open/Create
Jan 9 2026, 12:34 AM

Dec 31 2025

rmacklem committed rGe8567de718a4: nfscl: Fix handling of POSIX draft default ACLs (authored by rmacklem).
nfscl: Fix handling of POSIX draft default ACLs
Dec 31 2025, 2:45 AM
rmacklem committed rGab5ec8ccbcf0: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup (authored by rmacklem).
nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup
Dec 31 2025, 1:33 AM
rmacklem committed rG785d429c2b93: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup (authored by rmacklem).
nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup
Dec 31 2025, 1:25 AM

Dec 24 2025

rmacklem committed rG4f184fd35d81: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup (authored by rmacklem).
nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup
Dec 24 2025, 4:31 PM
rmacklem closed D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.
Dec 24 2025, 4:31 PM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Did formatting changes suggested by Ziaee.

Dec 24 2025, 3:41 PM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Made formatting changes suggested by kib@.

Dec 24 2025, 3:11 AM
rmacklem added a comment to D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Updated as suggested by kib@.

Dec 24 2025, 1:28 AM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Add words similar to what was in the email,
as requested by kib@.

Dec 24 2025, 1:26 AM

Dec 23 2025

rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Add ziaee@'s suggested change.

Dec 23 2025, 10:58 PM
rmacklem updated the diff for D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.

Added a short description of the rc.conf
variables, as suggested by kib@.

Dec 23 2025, 10:53 PM
rmacklem committed rGb94e4c7037b0: RELNOTES: Add an entry for 8e3fd450cc53 and friends (authored by rmacklem).
RELNOTES: Add an entry for 8e3fd450cc53 and friends
Dec 23 2025, 2:54 AM

Dec 22 2025

rmacklem committed rG60eb371c2b9a: UPDATING: Add an entry for commit 9f49f436a9ec (authored by rmacklem).
UPDATING: Add an entry for commit 9f49f436a9ec
Dec 22 2025, 11:31 PM
rmacklem committed rGe35191ccf3b3: nfs: Add some support for POSIX draft ACLs (authored by rmacklem).
nfs: Add some support for POSIX draft ACLs
Dec 22 2025, 11:25 PM
rmacklem committed rG9f49f436a9ec: nfs: Add some support for POSIX draft ACLs (authored by rmacklem).
nfs: Add some support for POSIX draft ACLs
Dec 22 2025, 9:53 PM
rmacklem committed rG0e724de9ed6f: nfscl: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscl: Add some support for POSIX draft ACLs
Dec 22 2025, 2:07 AM
rmacklem committed rG949cff4dceff: nfscommon: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscommon: Add some support for POSIX draft ACLs
Dec 22 2025, 1:09 AM
rmacklem committed rG8e3fd450cc53: nfsd: Add some support for POSIX draft ACLs (authored by rmacklem).
nfsd: Add some support for POSIX draft ACLs
Dec 22 2025, 12:11 AM

Dec 21 2025

rmacklem committed rGa35bbd5d9f5f: nfscommon: Add some support for POSIX draft ACLs (authored by rmacklem).
nfscommon: Add some support for POSIX draft ACLs
Dec 21 2025, 10:30 PM

Dec 18 2025

rmacklem requested review of D54279: nfsd.8: Add a short paragraph w.r.t. NFSv3 vs NFSv4 setup.
Dec 18 2025, 12:56 AM

Dec 10 2025

rmacklem committed rGc8180893d7fe: nfs_nfsdstate.c: Add sanity checks for lock stateids (authored by rmacklem).
nfs_nfsdstate.c: Add sanity checks for lock stateids
Dec 10 2025, 3:42 AM
rmacklem committed rGffd47a4bc671: nfs_nfsdstate.c: Add sanity checks for lock stateids (authored by rmacklem).
nfs_nfsdstate.c: Add sanity checks for lock stateids
Dec 10 2025, 3:38 AM

Dec 6 2025

rmacklem closed D45814: Allow ZFS sharenfs to generate multiple export(5) lines.

Commit to OpenZFS was done in August 2024.

Dec 6 2025, 3:08 PM

Nov 27 2025

rmacklem accepted D53949: kgssapi: Remove broken MOD_UNLOAD code.

Looks fine to me.

Nov 27 2025, 9:12 PM

Nov 26 2025

rmacklem committed rGaa1cf240887d: nfs_nfsdstate.c: Add sanity checks for lock stateids (authored by rmacklem).
nfs_nfsdstate.c: Add sanity checks for lock stateids
Nov 26 2025, 7:22 PM

Nov 23 2025

rmacklem committed rGbac4d3fd6cf8: UPDATING: Add an entry for f27afc476551 (authored by rmacklem).
UPDATING: Add an entry for f27afc476551
Nov 23 2025, 8:42 PM
rmacklem committed rG33d15245f9be: param.h: Bump __FreeBSD_version to 1500502 (authored by rmacklem).
param.h: Bump __FreeBSD_version to 1500502
Nov 23 2025, 8:36 PM
rmacklem committed rGf27afc476551: nfs: Add support for the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
nfs: Add support for the new _PC_CASE_INSENSITIVE name
Nov 23 2025, 8:29 PM
rmacklem committed rG52159dd73fe7: pathconf.2: Document the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
pathconf.2: Document the new _PC_CASE_INSENSITIVE name
Nov 23 2025, 8:26 PM
rmacklem committed rGd5335bdee715: nfs_clvfsops.c: Allow long directory mount paths (authored by rmacklem).
nfs_clvfsops.c: Allow long directory mount paths
Nov 23 2025, 1:26 PM

Nov 22 2025

rmacklem committed rGa36c71acb6e9: nfs_commonsubs.c: Get rid of variable used as a constant (authored by rmacklem).
nfs_commonsubs.c: Get rid of variable used as a constant
Nov 22 2025, 11:55 PM

Nov 8 2025

rmacklem committed rGfdd30e0670d1: pathconf: Define a new name called _PC_CASE_INSENSITIVE (authored by rmacklem).
pathconf: Define a new name called _PC_CASE_INSENSITIVE
Nov 8 2025, 1:17 AM

Nov 5 2025

rmacklem committed rG3a64c667f16f: nfs: Add support for the NFSv4 archive attribute (authored by rmacklem).
nfs: Add support for the NFSv4 archive attribute
Nov 5 2025, 1:34 AM

Nov 2 2025

rmacklem committed rG088ced14a69b: UPDATING: Add an entry for e5aa60d06958 (authored by rmacklem).
UPDATING: Add an entry for e5aa60d06958
Nov 2 2025, 11:23 PM
rmacklem committed rGb3de3c2dea57: param.h: Bump __FreeBSD_version for e5aa60d06958 (authored by rmacklem).
param.h: Bump __FreeBSD_version for e5aa60d06958
Nov 2 2025, 11:19 PM
rmacklem committed rGe5aa60d06958: nfs: Add support for the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
nfs: Add support for the new _PC_CASE_INSENSITIVE name
Nov 2 2025, 8:43 PM
rmacklem committed rG26a9d67f6fbb: nfscommon: Update the nfs_bigreply array (authored by ehem_freebsd_m5p.com).
nfscommon: Update the nfs_bigreply array
Nov 2 2025, 8:25 PM
rmacklem accepted D53536: nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2).
Nov 2 2025, 3:40 PM

Nov 1 2025

rmacklem committed rGb473bb274cef: pathconf.2: Document the new _PC_CASE_INSENSITIVE name (authored by rmacklem).
pathconf.2: Document the new _PC_CASE_INSENSITIVE name
Nov 1 2025, 10:24 PM
rmacklem closed D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.
Nov 1 2025, 10:24 PM

Oct 31 2025

rmacklem updated the diff for D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.

Reword the line to say "performs case insensitive lookups,"
as suggested by kib@.

Oct 31 2025, 11:25 PM
rmacklem added inline comments to D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.
Oct 31 2025, 10:50 PM
rmacklem added inline comments to D53508: pathconf.2: Document the new _PC_CASE_INSENSITIVE name.
Oct 31 2025, 10:45 PM