krb5: create the KDC database directory
ClosedPublic
Actions

Authored by glebius on Tue, Oct 7, 9:07 PM.

Details

Reviewers

cy
rmacklem

Commits

rG4e5964d6e2d6: krb5: create the KDC database directory
rGe7e7bf757ace: krb5: create the KDC database directory

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Tue, Oct 7, 9:07 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 7, 9:07 PM

glebius requested review of this revision.Tue, Oct 7, 9:07 PM

Harbormaster completed remote builds in B67627: Diff 163725.Tue, Oct 7, 9:07 PM

Looks fine to me. Is there somewhere that we can stick
examples for krb5.conf, kdc.conf and kadm5.acl?

This revision is now accepted and ready to land.Tue, Oct 7, 9:13 PM

In D52970#1210136, @rmacklem wrote:

Looks fine to me. Is there somewhere that we can stick
examples for krb5.conf, kdc.conf and kadm5.acl?

In share/examples/krb5 maybe?

This commit is obvious.

In D52970#1210155, @cy wrote:

In D52970#1210136, @rmacklem wrote:

Looks fine to me. Is there somewhere that we can stick
examples for krb5.conf, kdc.conf and kadm5.acl?

In share/examples/krb5 maybe?

Fine with me. For Heimdal, krb5.conf is in crypto/heimdal,
so crypto/krb5 might be more consistent?

However, I have no real opinion w.r.t. where. I just think
having an example of each somewhere makes setup
easier.

Closed by commit rGe7e7bf757ace: krb5: create the KDC database directory (authored by glebius). · Explain WhyTue, Oct 7, 9:50 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGe7e7bf757ace: krb5: create the KDC database directory.

In D52970#1210158, @rmacklem wrote:

In D52970#1210155, @cy wrote:

In D52970#1210136, @rmacklem wrote:

Looks fine to me. Is there somewhere that we can stick
examples for krb5.conf, kdc.conf and kadm5.acl?

In share/examples/krb5 maybe?

Fine with me. For Heimdal, krb5.conf is in crypto/heimdal,
so crypto/krb5 might be more consistent?

However, I have no real opinion w.r.t. where. I just think
having an example of each somewhere makes setup
easier.

I'd prefer not to put it in crypto/krb5. That could be construed not do belong there during a vendor import. If we are to create our own examples we should put them were people might intuitively look. Like /usr/share/examples/krb5 or a similar location. Remember src/crypto is the same as src/contrib except that it contains crypto. src/crypto are vendor imports. We should leave src/crypo for that purpose only.

ivy added a commit: rG4e5964d6e2d6: krb5: create the KDC database directory.Fri, Oct 10, 1:41 PM

Herald added a subscriber: ivy. · View Herald TranscriptFri, Oct 10, 1:41 PM