nfs_clrpcops.c: Add sanity checks for the slot cnt
ClosedPublic
Actions

Authored by rmacklem on Sun, Oct 26, 3:05 PM.

Details

Reviewers

emaste
markj

Commits

rG3053b2a3dcab: nfs_clrpcops.c: Add sanity checks for the slot cnts

Summary

The reply to CreateSession includes the slot cnt for
both fore and back slots. It should never be larger
than the argument specified and the fore slot cnt
should always be at least 1.

Without this patch, the replied slot cnts were not
being sanity checked.

While here, replace 64 with NFSV4_SLOTS (which is 64).

Test Plan

Tested for an NFSv4.2 mount with debug logging
enabled, so see that the replied slot cnts were
reasonable.
(Invalid slot cnts were not tested.)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rmacklem created this revision.Sun, Oct 26, 3:05 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Oct 26, 3:05 PM

rmacklem requested review of this revision.Sun, Oct 26, 3:05 PM

markj accepted this revision.Mon, Oct 27, 1:51 PM

This revision is now accepted and ready to land.Mon, Oct 27, 1:51 PM

emaste accepted this revision.Mon, Oct 27, 1:58 PM

Closed by commit rG3053b2a3dcab: nfs_clrpcops.c: Add sanity checks for the slot cnts (authored by rmacklem). · Explain WhyMon, Oct 27, 2:38 PM

This revision was automatically updated to reflect the committed changes.

rmacklem added a commit: rG3053b2a3dcab: nfs_clrpcops.c: Add sanity checks for the slot cnts.

Revision Contents
Changeset List

Path

Size

sys/

fs/

nfsclient/

nfs_clrpcops.c

9 lines

Diff 165143

View Options

sys/fs/nfsclient/nfs_clrpcops.c

nfs_clrpcops.c: Add sanity checks for the slot cntClosedPublicActions