User Details
- User Since
- Feb 26 2021, 3:47 PM (241 w, 5 d)
Yesterday
For the changes in unionfs_lock(), there is indeed a window after the interlock drop and before lock acquire and drop where the "root" reference unionfs holds (through unionfs_node; the one that allows to call vholdnz() above) could be dropped (it's the same window described in the big comment about checking the proper target vnode (lower or upper) was locked).
Tue, Oct 14
This change is an improvement without drawbacks, so should be committed.
We have indeed several problems with VOP_OPEN()/VOP_CLOSE(), e.g., they are not always called in pairs, and even if they are the passed td may not match between an open and close. These interfaces need serious revision, in particular determining which exact info the filesystems would like to use and if there are better ways to obtain them.
Mon, Oct 13
Please don't forget to exclude the changes in sys/netinet/ip_carp.c as they are completely unrelated.
Fri, Oct 10
Seems good (disclaimer: I only did manual code analysis, but didn't test).
Thu, Oct 9
Wed, Oct 8
Update after discussion and fixing the last use of vm_domainset_iter_page_init() with an object not write-locked in D52982.
Indeed, that is the only problem in UMA.
Please add Reported by: olce at commit, thanks!
It seems good indeed that not all man pages related to libraries go into separate packages, as some are targeted at administrators.
Tue, Oct 7
Mon, Oct 6
- Amend in the direction of feedbacks.
- Move the whole block of text at the send of the section (but still before the recent C++ section).
Fri, Oct 3
Looks good (but please see suggested changes). I've not tested the patch though.