Page MenuHomeFreeBSD
People minsoochoo0122_proton.me

minsoochoo0122_proton.me (Minsoo Choo)
Minsoo

Projects

User Details

User Since
May 6 2021, 12:00 AM (184 w, 3 d)

Recent Activity
View All

Sep 12 2024

minsoochoo0122_proton.me closed D44145: Disable C standards under C99 from kernel build.

This revision has landed

Sep 12 2024, 9:28 PM · Contributor Reviews (src)

Apr 13 2024

minsoochoo0122_proton.me updated the diff for D44769: mysql81-*: Fix mysql80 legacy lines.

update

Apr 13 2024, 3:53 AM
minsoochoo0122_proton.me updated the diff for D44769: mysql81-*: Fix mysql80 legacy lines.

Fix commit log and pkg-descr

Apr 13 2024, 2:37 AM
minsoochoo0122_proton.me added a reviewer for D44769: mysql81-*: Fix mysql80 legacy lines: Contributor Reviewers (ports).
Apr 13 2024, 2:26 AM
minsoochoo0122_proton.me requested review of D44769: mysql81-*: Fix mysql80 legacy lines.
Apr 13 2024, 2:25 AM

Apr 12 2024

minsoochoo0122_proton.me added inline comments to D44145: Disable C standards under C99 from kernel build.
Apr 12 2024, 11:03 PM · Contributor Reviews (src)

Apr 9 2024

minsoochoo0122_proton.me added a comment to D41421: Update jemalloc to version 5.3.0.

Build Success

Apr 9 2024, 11:33 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D41421: Update jemalloc to version 5.3.0.
Apr 9 2024, 11:30 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D41421: Update jemalloc to version 5.3.0.

git rebase main

Apr 9 2024, 10:13 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44665: stddef.h: Update for C23.
Apr 9 2024, 8:49 PM · Contributor Reviews (src)

Apr 7 2024

minsoochoo0122_proton.me added a comment to D44667: vm_reserv_reclaim_contig: Return NULL not false.

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

Apr 7 2024, 5:51 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 7 2024, 5:45 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 7 2024, 5:44 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Removed redundant macros

Apr 7 2024, 4:27 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44664: stdbool.h: Update for C23.
Apr 7 2024, 4:23 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44665: stddef.h: Update for C23.
Apr 7 2024, 4:20 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44666: sys/types.h: Do not define bool macros for C23 and later: Contributor Reviews (src).
Apr 7 2024, 3:15 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44666: sys/types.h: Do not define bool macros for C23 and later.
Apr 7 2024, 3:15 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44665: stddef.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 3:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44665: stddef.h: Update for C23.
Apr 7 2024, 3:09 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Add __STDC_VERSION_STDBOOL_H__ as the header file now conforms C23.

Apr 7 2024, 2:21 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44664: stdbool.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 2:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44664: stdbool.h: Update for C23.
Apr 7 2024, 2:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44663: stdalign.h: Disable for C23.

Fix grammar in the commit message

Apr 7 2024, 1:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44663: stdalign.h: Disable for C23: Contributor Reviews (src).
Apr 7 2024, 1:01 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44663: stdalign.h: Disable for C23.
Apr 7 2024, 1:01 AM · Contributor Reviews (src)

Apr 6 2024

minsoochoo0122_proton.me abandoned D44660: llvm-project: Fix build on devel/llvm18.

Fixed by 5f757f3ff9144b609b3c433dfd370cc6bdc191ad and cb14a3fe5122c879eae1fb480ed7ce82a699ddb6

Apr 6 2024, 11:29 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D44660: llvm-project: Fix build on devel/llvm18.

When will we merge the upstream llvm-project to freebsd-src? Are there any issues blocking the merge?

Apr 6 2024, 9:54 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D44660: llvm-project: Fix build on devel/llvm18.
Apr 6 2024, 7:56 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44660: llvm-project: Fix build on devel/llvm18: Contributor Reviews (src).
Apr 6 2024, 7:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44660: llvm-project: Fix build on devel/llvm18.
Apr 6 2024, 7:54 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.

Fixed macro

Apr 6 2024, 3:16 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43254: libc: Remove support for pre-C11 C standards.

@jrtc27 Can you review the changes?

Apr 6 2024, 12:40 AM · Contributor Reviews (src)

Mar 29 2024

minsoochoo0122_proton.me abandoned D43274: devel/autoconf-archive: update to 2023.02.20.

Closed by 51738fb7bd8f8f28abeeac6e4630f92822e2af42

Mar 29 2024, 6:51 PM

Mar 11 2024

minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.

Are there any more changes required?

Mar 11 2024, 5:42 AM · Contributor Reviews (src)

Feb 28 2024

minsoochoo0122_proton.me added inline comments to D43254: libc: Remove support for pre-C11 C standards.
Feb 28 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D44145: Disable C standards under C99 from kernel build.
Feb 28 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44145: Disable C standards under C99 from kernel build.
Feb 28 2024, 11:45 PM · Contributor Reviews (src)
minsoochoo0122_proton.me retitled D43254: libc: Remove support for pre-C11 C standards from Remove support for pre-C11 C standards to libc: Remove support for pre-C11 C standards.
Feb 28 2024, 11:43 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43254: libc: Remove support for pre-C11 C standards.

Separate commit

Feb 28 2024, 11:43 PM · Contributor Reviews (src)

Feb 18 2024

minsoochoo0122_proton.me removed a watcher for linuxkpi: minsoochoo0122_proton.me.
Feb 18 2024, 11:54 PM

Feb 4 2024

minsoochoo0122_proton.me added a reviewer for D43730: vm: Convert boolean_t to bool: Contributor Reviews (src).
Feb 4 2024, 9:50 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43742: rpcsvc/yp_prot.h: remove redundant definition of bool: Contributor Reviews (src).
Feb 4 2024, 9:49 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43742: rpcsvc/yp_prot.h: remove redundant definition of bool.
Feb 4 2024, 9:49 PM · Contributor Reviews (src)

Feb 3 2024

minsoochoo0122_proton.me retitled D43726: libc: Specify parameter types for function pointer from libc: Specify paremeter types for function pointer to libc: Specify parameter types for function pointer.
Feb 3 2024, 11:49 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43726: libc: Specify parameter types for function pointer.

Fixed typo in commit message

Feb 3 2024, 11:49 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43730: vm: Convert boolean_t to bool.

Convert vm_reserv_t->inpartpopq from char to bool

Feb 3 2024, 11:46 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D43730: vm: Convert boolean_t to bool.
Feb 3 2024, 11:28 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43730: vm: Convert boolean_t to bool.
Feb 3 2024, 11:26 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43729: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 11:24 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43729: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 11:24 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43726: libc: Specify parameter types for function pointer: Contributor Reviews (src).
Feb 3 2024, 9:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43726: libc: Specify parameter types for function pointer.
Feb 3 2024, 9:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 6:07 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43722: pmap: Reflect 1f1b228 in man page.
Feb 3 2024, 6:06 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43715: ctfmerge: remove function cast of strcompare() for qsort().

Updated commit message

Feb 3 2024, 2:57 AM · Contributor Reviews (src)
minsoochoo0122_proton.me retitled D43715: ctfmerge: remove function cast of strcompare() for qsort() from ctfmerge: specify parameter types of strcompare() for qsort() to ctfmerge: remove function cast of strcompare() for qsort().
Feb 3 2024, 2:55 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43715: ctfmerge: remove function cast of strcompare() for qsort().

Remove cast to function pointer

Feb 3 2024, 2:51 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43715: ctfmerge: remove function cast of strcompare() for qsort(): Contributor Reviews (src).
Feb 3 2024, 2:13 AM · Contributor Reviews (src)

Feb 2 2024

minsoochoo0122_proton.me updated the summary of D43715: ctfmerge: remove function cast of strcompare() for qsort().
Feb 2 2024, 10:12 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43715: ctfmerge: remove function cast of strcompare() for qsort().
Feb 2 2024, 10:12 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43239: Use gnu17 for buildkernel.
Feb 2 2024, 5:58 AM · Contributor Reviews (src)

Jan 30 2024

minsoochoo0122_proton.me planned changes to D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 30 2024, 1:34 PM · Contributor Reviews (src)
minsoochoo0122_proton.me abandoned D43660: Replace boolean_t with bool.
Jan 30 2024, 6:13 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:12 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D43660: Replace boolean_t with bool.
Jan 30 2024, 5:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:09 AM · Contributor Reviews (src)
minsoochoo0122_proton.me planned changes to D43660: Replace boolean_t with bool.
Jan 30 2024, 5:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43660: Replace boolean_t with bool.
Jan 30 2024, 5:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43237: Use gnu17 for buildworld.
Jan 30 2024, 12:48 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43254: libc: Remove support for pre-C11 C standards.
In D43254#995739, @arichardson wrote:

Commit message should probably be qualified with "for kernel compilation"?

Jan 30 2024, 12:46 AM · Contributor Reviews (src)

Jan 29 2024

minsoochoo0122_proton.me updated the diff for D43254: libc: Remove support for pre-C11 C standards.

Restored changes in usr.bin/lex

Jan 29 2024, 9:19 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43641: style(9): Remove subversion keyword.

Do I need to update the date of this man page?

Jan 29 2024, 9:03 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.

Move the definition of static_assert in <sys/systm.h>
Previous definition for linux compatibility is removed due to type definition conflict

Jan 29 2024, 8:31 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D43641: style(9): Remove subversion keyword: Contributor Reviews (src).
Jan 29 2024, 2:31 AM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43641: style(9): Remove subversion keyword.
Jan 29 2024, 2:31 AM · Contributor Reviews (src)

Jan 28 2024

minsoochoo0122_proton.me retitled D43624: [2/2] [WIP] Import heimdal 7.8.0 from [WIP] Import heimdal 7.8.0 to [2/2] [WIP] Import heimdal 7.8.0.
Jan 28 2024, 5:33 AM · Contributor Reviews (src)
minsoochoo0122_proton.me retitled D43625: [1/2] [WIP] Import Heimdal 7.8.0 from Import Heimdal 7.8.0 to [1/2] [WIP] Import Heimdal 7.8.0.
Jan 28 2024, 5:33 AM · Contributor Reviews (src)

Jan 27 2024

minsoochoo0122_proton.me updated the diff for D43624: [2/2] [WIP] Import heimdal 7.8.0.

Update

Jan 27 2024, 10:40 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43624: [2/2] [WIP] Import heimdal 7.8.0.

Remove man page for heimdal's gssapi

Jan 27 2024, 5:52 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43624: [2/2] [WIP] Import heimdal 7.8.0.

Restore libgssapi

Jan 27 2024, 4:42 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43624: [2/2] [WIP] Import heimdal 7.8.0.
In D43624#994816, @freebsd_igalic.co wrote:

not to be a total buzzkill, but, have you seen @cy's post on arch about this https://lists.freebsd.org/archives/freebsd-arch/2023-December/000580.html

Jan 27 2024, 12:51 AM · Contributor Reviews (src)

Jan 26 2024

minsoochoo0122_proton.me added inline comments to D43239: Use gnu17 for buildkernel.
Jan 26 2024, 11:05 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43624: [2/2] [WIP] Import heimdal 7.8.0.

Only uploads FreeBSD-side changes

Jan 26 2024, 10:39 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 26 2024, 10:37 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43625: [1/2] [WIP] Import Heimdal 7.8.0.
Jan 26 2024, 10:37 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43625: [1/2] [WIP] Import Heimdal 7.8.0.
Jan 26 2024, 10:35 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 26 2024, 10:33 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43624: [2/2] [WIP] Import heimdal 7.8.0.

Fix wrong commit range

Jan 26 2024, 10:33 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43624: [2/2] [WIP] Import heimdal 7.8.0.

Separate import and other changes

Jan 26 2024, 10:31 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43624: [2/2] [WIP] Import heimdal 7.8.0.

I have difficulty with creating gssapi_asn1.h with asn_compile. I have figured out that Makefiles in kerberos5/lib/libgssapi_[krb5|ntlm|spnego] and lib/libgssapi/Makefile` need to be change, but I could not make it since I'm not very skilled in Makefiles. Any advice would be greatly appreciated.

Jan 26 2024, 10:29 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43624: [2/2] [WIP] Import heimdal 7.8.0.

Use upstream sources for libgssapi

Jan 26 2024, 10:26 PM · Contributor Reviews (src)
minsoochoo0122_proton.me planned changes to D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 26 2024, 10:16 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 26 2024, 10:16 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 26 2024, 10:16 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D43624: [2/2] [WIP] Import heimdal 7.8.0.
Jan 26 2024, 10:13 PM · Contributor Reviews (src)

Jan 25 2024

minsoochoo0122_proton.me abandoned D43610: motd: Update faq link and remove broken link to questions lists.

Sorry. I was confused.

Jan 25 2024, 11:33 PM
minsoochoo0122_proton.me requested review of D43610: motd: Update faq link and remove broken link to questions lists.
Jan 25 2024, 11:32 PM

Jan 24 2024

minsoochoo0122_proton.me added a comment to D43548: Remove unnecessary promgramlisting.
In D43548#993576, @pauamma_gundo.com wrote:

Not sure what you mean by "unrelated to the content", but this is the output of the command above with kern.securelevel having its initial value.

Jan 24 2024, 1:22 AM · docs