Update comment concerning testing using Steve Kargl's code. This code
needs GNU libraries, so cannot be committed to the source tree.

Remove comment with low signal content.

Take Andy's very good advice and avoid the wrapper function by
#define/#include magic.

Update reviewer list.

Shorten boilerplate in response to review.

Add phab URI.

Give this commit message a proper title

Address review comments.

Fix minor spello in the commit message.

Incomplete change.

LGTM.

I don't have a major objection to this, but I'm nervous of the lower-numbered pools being favoured. I'm not formally requesting changes yet, as I could be persuaded that I'm wrong.

Seems sensible.

About time!

I'd be happy to green-light this, but I also wonder if there is not a better way. For now, I'm at "no objection" for a merge, but with a request for further exploration of e.g. cached boot-time entropy stashing. (Could a VM do that?)

Who is going to do the actual commit? I'm happy to do it if no-one else wants to? Whoever does it has csprng@ green-light.

Accepting in retrospect. Thanks!

In D20780#766778, @greg_unrelenting.technology wrote:

err, I have not addressed the "isUEFIBoot" thing and the "This file needs a copyright / license at the top" thing…

In D20780#766643, @cperciva wrote:

Is this waiting for anything else before it gets committed?

I missed the move of imprecise.c to its new, temporary home in ld128.

This is two git commits - see the commit message.

This looks safe enough to me.

Clean off file added in error.

Testing this on an RPi4 would be nice, but it's not a dealbreaker.

Obvious technical debt removal. Please do this.

Obvious technical debt removal. Please do this!

I'm keen on having this - a build is under way. DHYB, it may take a while.

I'm happy to see this landed in disabled form.

I'm happy to see this landed in disabled form.

LGTM.

I like this general idea very much! I'm a bit leery of the critical regions, but I admit that I don't understand them properly. I presume that in a PCPU environment they are fine.

OK to close again.

That works, thanks! I'm at latest CURRENT, no backouts, my console works and so do my PCI ethernet port.

ECAM hacks? When are those likely to appear? :-)

With this patch in, AND the flashe given above, I get my console back!

Worse. Previously working console now broken. Current with this change backed out now broken.

Trying now. In the meanwhile, is there some place where the Collected Wisdom™ of all current mcbin firmware statusses, hints, binaries etc are kept?

Yup - my flash is a couple of months old, and a hand-rolled debug-version (not by me). The image you pointed to fails with checksum errors at boot, but it may have something to do with the way I made it. With the same MBR as the old one, I did:

This change breaks my MacchiattoBin DoubleShot. I've bisected to get to commit r362574, which is this. The symptoms are a hang right at the beginning of the boot, at this point:

Happy with this.

If a committer is needed, I'm happy to oblige, but I'll need testing time, and for that I need to build and boot. If Someone Else(™) can assure me that this works, I'll speed it up a bit.