Did this end up being EN'd for currently supported RELEASE's ?

Do any other lang/python* ports need similar treatment?

@dereks_lifeofadishwasher.com Can we the/an existing version format that upstream uses (vX.Y.Z), optionally suffixed appropriately with relevent git tag if its 'in between versions' ?

Could you list deprecation/removal here please: https://wiki.freebsd.org/DeprecationPlan

Apart from inline review items to address:

• the noflavors was copied. I though this meant just one package using the default Python version so upgrades automatically each time a new Python is made as default. unlike Ansible which has to be deleted and reinstalled each time Python changes

In D35506#805709, @hsw_bitmark.com wrote:

my understanding is:

• that V1.x support will continue and be available PyPi
• V2.x will not be available on PyPI but via a binary download from Amazon Currently only Mac/Win/Linux Installers are available
• V2.x uses different auth API which is why I chose awscli2 to avoid confusion if someone upgraded an existing awscli then they would be get authentication failures
• the noflavors was copied. I though this meant just one package using the default Python version so upgrades automatically each time a new Python is made as default. unlike Ansible which has to be deleted and reinstalled each time Python changes

Would you look at my revisions and let me know where improvements can be made.
Thanks

LGTM mate, nice work!

As expected. I do USES -> USE_* -> *_FOO, but wont block review on that.

• Minor categories update
• Does this pass QA? I've added TEST PLAN items

Alexey, This diff is not not a ports commit proposal, as should be clear from the diff summary (WIP) and description:

Add previous reviewers to ... Reviewers: as this ... needs review :)

Thanks for this Piotr.

LGTM ship and merge it!

Upstream PR closed in favour of chasing LSP support:

What is the impact on those remaining port without Django 3.2 support after this change lands?

LGTM

After *_DEPENDS change, re-QA via poudriere to confirm dependency availability at build and run time.

Add changelog link to commit log message.

LGTM 👍

Loop in folks involved in the recent text update

Pending QA confirm on Python.

Include a note in commit log message that you're bumping dependent ports PORTREVISIONS due to shared library major version increase

Loop in people involved in recent text update

Looks fine, add <Reason> to MFH

Missing: Reviewed_by, Differential Revision and MFH attributes in SUMMARY

Add (reason) to MFH line, so its clear to committers why

I don't understand the why/description in commit log message.

• Add TEST_DEPENDS and (do-)test target
• Confirm QA (Added to TEST PLAN section)

• Add TEST_DEPENDS and (do-)test target for QA
• Need confirmation of QA in TEST PLAN

In D34390#779207, @dereks_lifeofadishwasher.com wrote:

You're correct the tests dir is not included in the sdist. However, those test are just to import the module. Maybe to test future absolute_import? I don't know how much value this would add. If you still think this is a good idea I can ask to include tests.

In D34390#779207, @dereks_lifeofadishwasher.com wrote:

You're correct the tests dir is not included in the sdist. However, those test are just to import the module. Maybe to test future absolute_import? I don't know how much value this would add. If you still think this is a good idea I can ask to include tests.

• Upstream has a test suite. Add TEST_DEPENDS and (do-)test target for comprehensive and easy QA. If the PyPI sdist doesnt ship the tests, use github and ask upstream to package tests and test files for downstreams to use and reference. Don't depend or use tox, just run pytest directly. See existing ports for invocations. Add test results to maketest: in TEST PLAN section of this diff
• Upstream declares python_requires = >=3.6 but also Programming Language :: Python :: 3.9. 3.10 is in the tree, and USES=python:<version-spec> should be capped to the versions it supports (and works and is tested with). Upstream (tox.ini) only CI's with envlist = py{36,37,38,39}. Ask upstream to add 3.10 and run tests with it. If it passes, leave <version-spec> uncapped, otherwise, cap it at 3.6-3.9

Refresh patch after git rm files, diff against origin/main

Link to versioned (tagged) version of relevent changelog files, rather than commits (ive updated this review summary)

Pending commit log message update

Can you add a changelog link to the commit log message and set MFH depending on whether or not its a bugfix/security update (yes) or feature only (no)

Thanks for tagging @kevans. The *SAN link failures and environment/build configuration are here: https://lists.freebsd.org/archives/freebsd-current/2021-September/000488.html

Also, explain files/patch-* removal (upstreamed? something else?) in the differential SUMMARY

1. as this change doesn't affect them to my understandings,

Acceptance pending QA confirmation (portlint, poudriere)