User Details
- User Since
- Apr 10 2016, 5:00 PM (465 w, 1 d)
Today
Yesterday
Do we want to go from installing man pages by default to not installing them by default?
Sat, Mar 8
Fri, Mar 7
Thu, Mar 6
I don't plan on committing this without a better understanding of why it's happening. Adding yuri, since he made a similar change recently.
For some reason, the upstream mod file changed. https://pkg.ftfl.ca/data/15amd64-default/2025-03-06_10h57m00s/logs/errors/termshot-0.2.12_1.log
Wed, Mar 5
It fails to build. Do you need a dependency on multimedia/v4l_compat?
Tue, Mar 4
Sun, Mar 2
Sat, Mar 1
Thu, Feb 27
Tue, Feb 25
Mon, Feb 24
Update Canna patches
Also bump japanese/mozc-server.
Emacs 30.1 is released. I will put the PORTREVISION bumps in a separate review. Minor changes will be required when HIROSE yuuji updates the canna patch.
Sun, Feb 23
There are a few other instances of HTTP/2.0 in the tree.
Sat, Feb 22
This can't build because there is no distinfo file.
Looks like I didn't need to commandeer the review to make changes.
Minor tweaks mostly to improve formatting.
Fri, Feb 21
Mk/Uses: Update EMACS_VER to 30.1
Thu, Feb 20
Sun, Feb 16
Fri, Feb 14
Yes, this information is in other report entries, so this can be closed.
Wed, Feb 12
Mon, Feb 10
Could you confirm that it also builds fine on 14 and that all reverse dependencies also build fine? My grep shows these ports as the reverse dependencies:
audio/owntone audio/umurmur dns/bind9-devel dns/bind918 dns/bind920 dns/knot-resolver dns/knot3 dns/nsd databases/postgis31 databases/postgis33 databases/postgis34 databases/postgis35 databases/postgresql-cstore_fdw dns/unbound graphics/mapserver net/frr10 net/frr9 net-im/purple-googlechat net-mgmt/collectd5 net/nmsg net/ocserv polish/libgadu net-mgmt/riemann-c-client science/py-tensorflow net/sie-nmsg net/teddycloud x11-toolkits/libshumate
Feb 6 2025
Feb 3 2025
Sounds good. You also need to bump PORTREVSION.
Should the patch be removed from other JDK ports as well?
Jan 29 2025
Jan 28 2025
Looks good. Ideally, we would confirm that the reverse dependencies [0] are good.
Jan 25 2025
Jan 24 2025
Looks good, but we should also hear from @sunpoet. (That's always implied when I approve changes to a port someone else maintains.)
In the commit log, you say,
List also the Python version limitation since none is documented.
Jan 23 2025
Jan 21 2025
Jan 20 2025
If you're feeling motivated:
- it might be helpful (at some point) to upstream the patch
- see if portfmt -D Makefile has anything useful to say about the formatting.
Jan 18 2025
It's not such a big deal in these particular cases, but as a matter of principle, I felt it was worth mentioning that pushing another committer's review without first discussing it with the committer can lead to problems. Is the commit really ready? Is the commit log ready? (Without using something like git arc Phabricator can mess with the commit log.) Are there any other commits that must be committed first?
Rather than have a messy commit log, it's best (from my perspective) to leave things as they are now.
@carlavilla, in the future, could you please not commit my work without discussing it with me first?
Jan 17 2025
Incorporate correction spotted by Pau Amma