I just typed lgtm, and Phabricator inserted the image. All such marcos can be seen at https://reviews.freebsd.org/macro/.

Since some ports are currently broken, I'll commit this change now to address the issue. If any problems come up, we can address them in a follow-up commit.

Great. Thanks both. I'll commit now.

On second thought, I'm not sure we want a section for FreeBSD 14.2-STABLE when 14.2-BETA2 is available. Let's see what re@ as to say.

On second thought, I'm not sure we want a section for FreeBSD 14.2-STABLE when 14.2-BETA2 is available. Let's see what re@ as to say.

It looks like the PORTREVISION bumps were missed in/after 2715f16944541b6b27d121a57133347574a51ff1. Please let me know if these changes look good to you, and I will commit.

Looking at the doc commit logs, there doesn't seem to be a convention about how to prefix the component as described in the Committer's Guide. In the ports tree, when we update a port, we use category/port, which is the path in the tree. This adds a slight convenience when doing something like git log --oneline because the location of the change can be seen without showing the commit. With that, how do you feel about this commit log?

website/shared/releases: Add missing version macro

This seems to do well to address @emaste's concern (in bug 279503) about generic names by including concrete examples such as

(where N is the major release number, i.e. up to 14 as of 2024)

Looks good to me. Thank you.

In D47142#1080572, @bz wrote:

In D47142#1080548, @jrm wrote:

lgtm now.

Great. To me too. Thanks a lot for all your patience and pointing me in the right directions. Can I get formal accepts as well?

lgtm now.

In D47142#1080193, @bz wrote:

BTW. likely not this one needs revision but D47068 actually does. This one does not touch ath12k and others.

On systems built after the change to allow direct loading of firmware files, there are plist errors with:

net/wifi-firmware-ath10k-kmod@ath10k
net/wifi-firmware-ath11k-kmod@ath11k
net/wifi-firmware-ath12k-kmod@ath12k
net/wifi-firmware-mt76-kmod@mt76
net/wifi-firmware-rtw88-kmod@rtw88
net/wifi-firmware-rtw89-kmod@rtw89

In D47086#1074862, @2khramtsov_gmail.com wrote:

• elfctl.mk currently executes post-build not post-stage

Assuming @kevans or @des don't chime in to say something is missing in the base certificate store, lgtm.

In D47068#1075044, @bz wrote:

Is that with the other change on top already or just with this one?

I built the wifi ports on a CURRENT system built after the February changes using poudriere bulk -t -C -i -j 15amd64 -f ~/wifi_ports.txt. Based on your changes, I expected the files to be installed under /boot/firmware. However this is what I see.

Looks good to me. I'll update the Foundation's main entry to remove this content and point here.

In D46966#1070659, @mikael wrote:

Sorry, this was fixed in https://cgit.freebsd.org/ports/commit/net-im/libsignal-node/Makefile?id=858d32fac8f9ab1d211abaa8fed7d3f1c443f7c4 and reintroduce in
https://cgit.freebsd.org/ports/commit/net-im/libsignal-node/Makefile?id=57741b0aa4123a69b1fd223fde4a70ca82283edb.

Thank you Jose and Tom.

FYI, when I was testing, I set WITH_SUBVERSION_VER to lts instead of LTS and it wasn't handled as would be expected after a look in devel/subversion/Makefile.addons.

This work was incorporated into Bjoern's 8f79c11c717126a42a6f17f30a193cf1da866831.

In D46643#1064092, @diizzy wrote:

Autogenerated archives changes over time which will break any kind of checksum verification and aren't necessarily reproducable so that doesn't add much if any value.

In D46643#1063864, @diizzy wrote:

Any reason as to why we're not using upstream release archive?
https://github.com/msktutil/msktutil/releases/download/1.2.2/msktutil-1.2.2.tar.bz2

As you say, this shouldn't hurt anything and we'll see if it eliminates the sporadic 503 errors on the official package builders.

Fix commit log header

Remove unintended changes

lgtm assuming all the necessary poudriere runs pass and @pi has no objections.

Build succeeds.