Address comments from gerald

In D50052#1141939, @jrm wrote:

This fixes a build problem, so you can commit with implicit maintainer approval.

This fixes a build problem, so you can commit with implicit maintainer approval.

Poudriere builds look good. Harald, please let me know if you're satisfied with all your run-time tests, and I'll commit.

Harold, did you run it through poudriere? If not, I have some builds running now and can report back soon.

In D49489#1135680, @michaelo wrote:

In D49489#1135667, @ziaee wrote:

@michaelo, src/tools/tools/git/git-arc.sh will do this for you. Use git arc patch -c D49489. But first, Jim is a recurring contributor, let me work with him on commit messages.

Just tried, works like a charm, but I need approval from my mentors first: @jrm, @otis

The description looks good. There are a couple of spelling mistakes: pakages > packages, fimrware > firmware, maintainance > maintenance, and solutions > solution.

It's indeed running in a chroot.

% sudo procstat -f $(pgrep local-unbound)
  PID COMM                FD T V FLAGS    REF  OFFSET PRO NAME
 3763 local-unbound     text v r r-------   -       - -   /usr/sbin/local-unbound
 3763 local-unbound      cwd v d r-------   -       - -   /var/unbound
 3763 local-unbound     root v d r-------   -       - -   /var/unbound
 3763 local-unbound     jail v d r-------   -       - -   /var/unbound
 3763 local-unbound        0 v c rw------   3       0 -   /dev/null
 3763 local-unbound        1 v c rw------   3       0 -   /dev/null
 3763 local-unbound        2 v c rw------   3       0 -   /dev/null
 3763 local-unbound        3 s - rw---n--   1       0 UDP ::1.53 ::.0
 3763 local-unbound        4 s - rw---n--   1       0 TCP 0 0 ::1.53 ::.0
 3763 local-unbound        5 s - rw---n--   1       0 UDP 127.0.0.1:53 *:0
 3763 local-unbound        6 s - rw---n--   1       0 TCP 0 0 127.0.0.1:53 *:0
 3763 local-unbound        7 s - rw---n--   1       0 UDS 0 0 /var/run/local_unbound.ctl
 3763 local-unbound        8 s - rw------   1       0 UDD /var/run/log
 3763 local-unbound        9 s - rw---n--   1       0 UDS 0 0 -
 3763 local-unbound       10 s - rw---n--   1       0 UDS 0 0 -

Sorry. I'm struggling to keep up with a lot of requests these days.

@haraldei_anduin.net, are you good with this commit message?

It looks good to me.

I accepted solely based on the positive run-time tests.

In D49402#1126472, @michaelo wrote:

@jrm, yes of course, it simply worked in poudriere. Did forget to bump the revision.

If this changes the package, please bump PORTREVISION.

In D49130#1124947, @michaelo wrote:

In D49130#1124932, @jrm wrote:

Thanks for this. I still had ca_root_nss installed because local_unbound configured with TLS required a certificate bundle. Unbound with TLS is now working without ca_root_nss.

Regarding unbound, if you set tls-system-cert to true you will have the default truststore enabled: https://github.com/NLnetLabs/unbound/blob/5c84bb573f9728c10bcb3592dbd12be403d362de/util/net_help.c#L1593-L1601

Only chroot requires a bundle which sitll can use tls-system-cert.

In my opinion the unbound in base should have this option set to true by default to reduce the user headache.

Thanks for this. I still had ca_root_nss installed because local_unbound configured with TLS required a certificate bundle. Unbound with TLS is now working without ca_root_nss.

Do we want to go from installing man pages by default to not installing them by default?

I don't plan on committing this without a better understanding of why it's happening. Adding @yuri, since he made a similar change recently.

For some reason, the upstream mod file changed. https://pkg.ftfl.ca/data/15amd64-default/2025-03-06_10h57m00s/logs/errors/termshot-0.2.12_1.log

It fails to build. Do you need a dependency on multimedia/v4l_compat?

Committed.

Update Canna patches