Great, thanks.

Yes, this is fine too. At some point both gcc and clang switched to gnu++17 by default, but it's better to be explicit.

Kludge approved :)

Yeah, go for it. :)

Thanks, I will commit this.

In D45409#1112419, @jrtc27 wrote:

This should be fixed by 4015ff43cbbe

In D45409#1111300, @pho wrote:

FYI: I came across this i386 problem after commit 0078df5f0258.

Trying to mount root from ufs:/dev/vtbd0p1 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
WARNING: 32-bit kernels are deprecated and may be removed in FreeBSD 15.0.
panic: vm_page_t 0x5d49be0 phys_addr mismatch ffffffffb8779000 00000000b8779405
cpuid = 3
time = 1738177579
KDB: stack backtrace:
db_trace_self_wrapper(7,114beb40,5d49be0,ffffffff,ffffffff,...) at db_trace_self_wrapper+0x28/frame 0x113f6744
vpanic(148badd,113f6780,113f6780,113f67f0,13a54e9,...) at vpanic+0xf4/frame 0x113f6760
panic(148badd,5d49be0,b8779000,ffffffff,b8779405,...) at panic+0x14/frame 0x113f6774
pmap_pae_remove_pages(114128e8) at pmap_pae_remove_pages+0x599/frame 0x113f67f0
exec_new_vmspace(113f6994,188247c) at exec_new_vmspace+0x1cb/frame 0x113f6810
exec_elf32_imgact(113f6994,16d4801,113f6984,0,0,...) at exec_elf32_imgact+0x5e4/frame 0x113f6874
kern_execve(114beb40,113f6a8c,0,1141284c) at kern_execve+0x72c/frame 0x113f6a74
sys_execve(114beb40,114bedf0,114beb40,13ae913,114bede4,...) at sys_execve+0x4e/frame 0x113f6ac8
syscall(113f6ba8,3b,3b,3b,402aaf,...) at syscall+0x1e6/frame 0x113f6b9c
Xint0x80_syscall() at 0xffc03479/frame 0x113f6b9c
--- syscall (59, FreeBSD ELF32, execve), eip = 0x47e53f, esp = 0xffbfe848, ebp = 0xffbfe858 ---
KDB: enter: panic
[ thread pid 17 tid 100080 ]
Stopped at      kdb_enter+0x34: movl    $0,kdb_why
db> x/s version
version:        FreeBSD 15.0-CURRENT #0 main-n275068-0078df5f0258-dirty: Wed Jan 29 18:44:45 CET 2025\012    pho@mercat1.netperf.freebsd.org:/mnt25/obj/usr/src/i386.i386/sys/PHO\012
db>

LGTM

Maybe you can just avoid arc, and do a regular commit on top of main, rebasing whatever you have now. Just ensure the Differential Revision: https://reviews.freebsd.org/D47478 line is in there, then Phabricator can close this review.

In D47478#1098395, @leres wrote:

In D47478#1098383, @dim wrote:

Oh actually @leres can commit this :)

Happy to.

I'm a ports, not a src committer. Looking at the last src commit I made (c4cbf1fb) I'll need these headers, right?

PR: 282745
Approved by: jhb
Differential Revision: https://reviews.freebsd.org/D47478

Oh actually @leres can commit this :)

If nobody has any other objections, I will commit this later today.

In D47478#1097191, @leres wrote:

In D47478#1097126, @jhb wrote:

It might nice if this showed the current options or is that potentially too large?

Do you mean the entire command line, all command arguments, or all options/flags? The current version does all the options/flags (see attached).

I think this is a handy feature, and can't really find any problems with it. I know that I personally prefer zstd compression, and currently I have to start the bsdinstaller myself using: