dim (Dimitry Andric)
User

Projects

committers
Organization
Src Committers
Organization

User Details

User Since: Jan 7 2014, 10:13 PM (597 w, 1 d)

Recent Activity
View All

Tue, Jun 17

dim committed R11:15734f35f92c: games/openmw: fix patch line terminators after 13a36f14c8a5 (authored by dim).

games/openmw: fix patch line terminators after 13a36f14c8a5

Tue, Jun 17, 9:42 AM

Tue, Jun 10

dim accepted D50766: libclang_rt: Descend into libclang_rt to clean.

I think this makes sense, thanks. Proves how often I run cleanworld, which is almost never :)

Tue, Jun 10, 11:21 AM

Sat, May 31

dim accepted D50388: src.opts.mk: Default LLVM_ASSERTIONS off.

Okay, let's change the default then. It would be nice if you can put a reminder in the commit message that says you have to turn on LLVM_ASSERTIONS whenever you want to report an issue with the toolchain itself.

Sat, May 31, 1:38 PM

Fri, May 30

dim added a comment to D50388: src.opts.mk: Default LLVM_ASSERTIONS off.

The idea behind this being on in -CURRENT is to catch more errors. The same really holds for WITNESS and other assertions, but you could argue that those are more for the core of the system, while llvm-project is contributed software. Note that we caught many assertions since they are enabled by default, so they definitely have value.

Fri, May 30, 7:20 PM

Wed, May 28

dim committed rGa0d22d7934c6: libc++: fix compiling <locale> with -fmodules (authored by Jordan Gordeev <jgopensource@proton.me>).

libc++: fix compiling <locale> with -fmodules

Wed, May 28, 4:27 PM

Sun, May 25

dim committed rGcab029073dc6: libc++: fix compiling <locale> with -fmodules (authored by Jordan Gordeev <jgopensource@proton.me>).

libc++: fix compiling <locale> with -fmodules

Sun, May 25, 9:21 AM

dim committed rG1c12934eba86: libc++: fix compiling <locale> with -fmodules (authored by Jordan Gordeev <jgopensource@proton.me>).

libc++: fix compiling <locale> with -fmodules

Sun, May 25, 9:21 AM

Thu, May 22

dim added a comment to D50463: bsd.suffixes-extra.mk: rewrap long lines.

Maybe a silly question, but when make unwraps these command lines and then prints them for the user, will the output become longer due extra spaces? Could be bad for my OCD... :)

Thu, May 22, 3:23 PM

May 18 2025

dim committed rGc809b0184d0a: libc++: fix compiling <locale> with -fmodules (authored by Jordan Gordeev <jgopensource@proton.me>).

libc++: fix compiling <locale> with -fmodules

May 18 2025, 8:05 PM

May 9 2025

dim committed rGb2bd1781fe56: depend-cleanup: ensure clang and llvm binaries are rebuilt (authored by dim).

depend-cleanup: ensure clang and llvm binaries are rebuilt

May 9 2025, 8:33 PM

dim committed rGae60fcd40fc6: Convert libllvm, libclang and liblldb into private shared libraries (authored by dim).

Convert libllvm, libclang and liblldb into private shared libraries

May 9 2025, 8:33 PM

dim committed rGe925d6c2e739: depend-cleanup: ensure clang and llvm binaries are rebuilt (authored by dim).

depend-cleanup: ensure clang and llvm binaries are rebuilt

May 9 2025, 8:33 PM

dim committed rGa743b3f1a4c5: Convert libllvm, libclang and liblldb into private shared libraries (authored by dim).

Convert libllvm, libclang and liblldb into private shared libraries

May 9 2025, 8:33 PM

May 8 2025

dim accepted D50252: loader: i386: use -z nostart-stop-gc for bfd as well.

Sure.

May 8 2025, 6:55 AM

May 5 2025

dim accepted D50084: strings: Unconditionally install ELF Tool Chain's strings.

May 5 2025, 7:36 PM

dim committed rG979864eef41b: Use .pieo extension for WITH_PIE bsd.prog.mk output (authored by dim).

Use .pieo extension for WITH_PIE bsd.prog.mk output

May 5 2025, 9:39 AM

dim committed rG4939a4a9cd14: Use .pieo extension for WITH_PIE bsd.prog.mk output (authored by dim).

Use .pieo extension for WITH_PIE bsd.prog.mk output

May 5 2025, 9:39 AM

May 2 2025

dim accepted D50100: libgcc_s: export integer and floating point __aeabi_ symbols .

Are you planning on MFC'ing this? But LGTM for the rest.

May 2 2025, 4:21 PM

Apr 30 2025

dim accepted D50089: Don't define NULL to nullptr in C++11 mode.

It's a bit unfortunate, but better to do the same thing as most other systems.

Apr 30 2025, 6:10 PM

Apr 26 2025

dim committed rG061ce1c392f0: Move extra suffix-transformation rules into bsd.suffixes-extra.mk (authored by dim).

Move extra suffix-transformation rules into bsd.suffixes-extra.mk

Apr 26 2025, 11:32 AM

dim committed rGb03ee8687e94: libllvm: remove duplicated SRCS_MIN line (authored by dim).

libllvm: remove duplicated SRCS_MIN line

Apr 26 2025, 11:32 AM

dim committed rGb93ad617555c: Move extra suffix-transformation rules into bsd.suffixes-extra.mk (authored by dim).

Move extra suffix-transformation rules into bsd.suffixes-extra.mk

Apr 26 2025, 11:32 AM

dim committed rG7f671b6f4675: libllvm: remove duplicated SRCS_MIN line (authored by dim).

libllvm: remove duplicated SRCS_MIN line

Apr 26 2025, 11:32 AM

Apr 25 2025

dim committed rGd4dab32448ce: depend-cleanup: ensure clang and llvm binaries are rebuilt (authored by dim).

depend-cleanup: ensure clang and llvm binaries are rebuilt

Apr 25 2025, 6:00 PM

dim committed rG2e47f35be5dc: Convert libllvm, libclang and liblldb into private shared libraries (authored by dim).

Convert libllvm, libclang and liblldb into private shared libraries

Apr 25 2025, 6:00 PM

dim closed D49967: Convert libllvm, libclang and liblldb into private shared libraries.

Apr 25 2025, 6:00 PM

dim committed rG245bb0110639: Use .pieo extension for WITH_PIE bsd.prog.mk output (authored by dim).

Use .pieo extension for WITH_PIE bsd.prog.mk output

Apr 25 2025, 5:53 PM

dim closed D49966: Use .pieo extension for WITH_PIE bsd.prog.mk output.

Apr 25 2025, 5:53 PM

dim updated the diff for D49967: Convert libllvm, libclang and liblldb into private shared libraries.

Add OptionalObsoleteFiles.inc entries.

Apr 25 2025, 11:08 AM

dim updated the diff for D49967: Convert libllvm, libclang and liblldb into private shared libraries.

Add workaround for powerpc "relocation R_PPC_GOT16 out of range" errors.

Apr 25 2025, 10:13 AM

Apr 24 2025

dim added a reverting change for D49223: src: Use gnu++17 as the default C++ standard: rGa34d2231fa38: Partially revert 6527682ab705 for llvm-based projects.

Apr 24 2025, 2:38 PM

dim added a reverting change for rG6527682ab705: src: Use gnu++17 as the default C++ standard: rGa34d2231fa38: Partially revert 6527682ab705 for llvm-based projects.

Apr 24 2025, 2:37 PM

dim committed rGa34d2231fa38: Partially revert 6527682ab705 for llvm-based projects (authored by dim).

Partially revert 6527682ab705 for llvm-based projects

Apr 24 2025, 2:37 PM

dim accepted D49960: Makefile.inc1: Let the buildetc target run outside of etc.

I tried this out, and it solved my issue of etcupdate leaving around a /usr/src/lib/libc/nsswitch.conf file.

Apr 24 2025, 2:29 PM

Apr 23 2025

dim committed rG5195ff613fca: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG (authored by dim).

Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG

Apr 23 2025, 7:39 PM

dim committed rG3f68c3e9c138: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG (authored by dim).

Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG

Apr 23 2025, 7:38 PM

dim closed D49965: Move extra suffix-transformation rules into bsd.suffixes-extra.mk.

Apr 23 2025, 3:45 PM

dim committed rG9c4f1497dae7: Move extra suffix-transformation rules into bsd.suffixes-extra.mk (authored by dim).

Move extra suffix-transformation rules into bsd.suffixes-extra.mk

Apr 23 2025, 3:45 PM

Apr 22 2025

dim accepted D49951: Move mntopts(3) suppport into libutil.

Apr 22 2025, 7:13 PM

dim added inline comments to D49966: Use .pieo extension for WITH_PIE bsd.prog.mk output.

Apr 22 2025, 7:10 PM

dim added a comment to D49965: Move extra suffix-transformation rules into bsd.suffixes-extra.mk.

In D49965#1139483, @emaste wrote:

I got my bikeshedding out of the way on other reviews so will reserve comment on the filename :)

Apr 22 2025, 7:03 PM

dim requested review of D49967: Convert libllvm, libclang and liblldb into private shared libraries.

Apr 22 2025, 6:50 PM

dim requested review of D49966: Use .pieo extension for WITH_PIE bsd.prog.mk output.

Apr 22 2025, 6:40 PM

dim abandoned D49962: Use .pieo extension for WITH_PIE bsd.prog.mk output.

Abandoning, arc diff totally messed this up.

Apr 22 2025, 6:36 PM

dim updated the diff for D49962: Use .pieo extension for WITH_PIE bsd.prog.mk output.

Split off the bsd.suffixes-extra.mk part to D49965.

Apr 22 2025, 6:35 PM

dim requested review of D49965: Move extra suffix-transformation rules into bsd.suffixes-extra.mk.

Apr 22 2025, 6:31 PM

dim accepted D49951: Move mntopts(3) suppport into libutil.

Apr 22 2025, 6:25 PM

dim added a comment to D49962: Use .pieo extension for WITH_PIE bsd.prog.mk output.

In D49962#1139420, @emaste wrote:

Are you up for splitting bsd.suffixes-extra.mk out first, without any functional changes?

Apr 22 2025, 6:22 PM

dim added a comment to D49962: Use .pieo extension for WITH_PIE bsd.prog.mk output.

Note this requires D49951 to be committed first, since otherwise tests/sys/fs/fusefs falls over due to it picking sbin/mount.c over tests/sys/fs/fusefs/mount..cc for targeting mount.pieo. This has to do with some internal ordering in make that I haven't been able to fully figure out.

Apr 22 2025, 5:38 PM

dim requested review of D49962: Use .pieo extension for WITH_PIE bsd.prog.mk output.

Apr 22 2025, 5:33 PM

dim accepted D49952: Search for mntopts.h globally, not locally.

LGTM, as long as there are include guards in mntopts.h :)

Apr 22 2025, 5:28 PM

dim added a comment to D49951: Move mntopts(3) suppport into libutil.

Another minor remark, in D49958 I added include guards to mntopts.h. Since the header is now actually installed, I think it would be proper to do so here too.

Apr 22 2025, 5:27 PM

dim accepted D49951: Move mntopts(3) suppport into libutil.

Apart from the nits, LGTM!

Apr 22 2025, 5:25 PM

dim abandoned D49958: Move mount related functions into libmount.

Abandoning in favor of D49951 and D49952.

Apr 22 2025, 5:20 PM

dim added a comment to D49958: Move mount related functions into libmount.

In D49958#1139282, @brooks wrote:

Sorry, I should have added you to D49951 and D49952 which this duplicates. I don't think a new library is warranted and if it is, it should probably be libmntopts or the like not something as generic as libmount.

Apr 22 2025, 4:39 PM

dim requested review of D49958: Move mount related functions into libmount.

Apr 22 2025, 10:03 AM

Apr 19 2025

dim committed rG160a2ba80497: libllvm: remove duplicated SRCS_MIN line (authored by dim).

libllvm: remove duplicated SRCS_MIN line

Apr 19 2025, 7:27 PM

Apr 18 2025

dim committed rGea231471d024: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG (authored by dim).

Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG

Apr 18 2025, 6:33 PM

dim closed D49886: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG.

Apr 18 2025, 6:33 PM

dim requested review of D49886: Fix build with WITH_CLANG_BOOTSTRAP and WITHOUT_CLANG.

Apr 18 2025, 10:56 AM

Mar 30 2025

dim accepted D49577: zoneinfo: also install tzdata.zi and version.

Great, thanks.

Mar 30 2025, 10:57 PM

Mar 29 2025

dim accepted D49223: src: Use gnu++17 as the default C++ standard.

Yes, this is fine too. At some point both gcc and clang switched to gnu++17 by default, but it's better to be explicit.

Mar 29 2025, 8:40 AM

Mar 28 2025

dim accepted D49561: tests: xfail readelf phdr count test w/LLVM binutils.

Kludge approved :)

Mar 28 2025, 8:33 PM

Mar 26 2025

dim committed R11:dc3c414bcb9f: editors/abiword: fix build with libc++ 19 (authored by dim).

editors/abiword: fix build with libc++ 19

Mar 26 2025, 6:39 PM

dim committed R11:e6daa211c609: editors/abiword: fix build with libc++ 19 (authored by dim).

editors/abiword: fix build with libc++ 19

Mar 26 2025, 6:38 PM

Mar 3 2025

dim accepted D49223: src: Use gnu++17 as the default C++ standard.

Yeah, go for it. :)

Mar 3 2025, 11:13 PM

Feb 26 2025

dim committed R11:0d47e63e74ee: www/py-qh3: fix build with LLVM_DEFAULT=19 (authored by dim).

www/py-qh3: fix build with LLVM_DEFAULT=19

Feb 26 2025, 7:03 PM

dim committed R11:11eeb7ba46b1: bsd.default-versions.mk: bump LLVM_DEFAULT to 19. (authored by dim).

bsd.default-versions.mk: bump LLVM_DEFAULT to 19.

Feb 26 2025, 7:03 PM

dim committed R11:691352633a8b: bsd.default-versions.mk: bump LLVM_DEFAULT to 19. (authored by dim).

bsd.default-versions.mk: bump LLVM_DEFAULT to 19.

Feb 26 2025, 7:02 PM

dim committed R11:9cccbd8cf048: www/py-qh3: fix build with LLVM_DEFAULT=19 (authored by dim).

www/py-qh3: fix build with LLVM_DEFAULT=19

Feb 26 2025, 7:02 PM

Feb 16 2025

dim committed R11:2fe842ab5f78: devel/ccls: fix build with LLVM_DEFAULT=19 (authored by dim).

devel/ccls: fix build with LLVM_DEFAULT=19

Feb 16 2025, 4:51 PM

dim committed R11:1f592d5d75ec: math/openturns: unbreak on 15 (authored by dim).

math/openturns: unbreak on 15

Feb 16 2025, 4:50 PM

dim committed R11:9025f32b1592: devel/ccls: fix build with LLVM_DEFAULT=19 (authored by dim).

devel/ccls: fix build with LLVM_DEFAULT=19

Feb 16 2025, 4:50 PM

dim committed R11:6806aac5c2a7: math/openturns: unbreak on 15 (authored by dim).

math/openturns: unbreak on 15

Feb 16 2025, 4:50 PM

Feb 13 2025

dim committed rGe375421e243a: Remove obsolete clang18 files for aarch64 (authored by ronald_klop.ws).

Remove obsolete clang18 files for aarch64

Feb 13 2025, 4:01 PM

dim committed rG9370c2c33125: Remove obsolete clang18 files for aarch64 (authored by ronald_klop.ws).

Remove obsolete clang18 files for aarch64

Feb 13 2025, 8:26 AM

dim committed rGf564bcc766d5: Remove obsolete clang18 files for aarch64 (authored by ronald_klop.ws).

Remove obsolete clang18 files for aarch64

Feb 13 2025, 8:25 AM

Feb 10 2025

dim committed rG09b435d3dc2a: Remove obsolete clang18 files for aarch64 (authored by ronald_klop.ws).

Remove obsolete clang18 files for aarch64

Feb 10 2025, 6:45 PM

dim closed D48904: Remove obsolete clang18 files for aarch64.

Feb 10 2025, 6:45 PM

dim accepted D48904: Remove obsolete clang18 files for aarch64.

Thanks, I will commit this.

Feb 10 2025, 6:41 PM

Feb 3 2025

dim committed rG32a711e1c447: Vendor import of llvm-project main llvmorg-20-init-19504-g8c2574832ed2, (authored by dim).

Vendor import of llvm-project main llvmorg-20-init-19504-g8c2574832ed2,

Feb 3 2025, 6:54 PM

Jan 31 2025

dim committed R11:9083fa424c08: lang/ldc: fix build with LLVM_DEFAULT=19 (authored by dim).

lang/ldc: fix build with LLVM_DEFAULT=19

Jan 31 2025, 11:04 PM

dim committed R11:c580801b319f: lang/ldc: fix build with LLVM_DEFAULT=19 (authored by dim).

lang/ldc: fix build with LLVM_DEFAULT=19

Jan 31 2025, 11:04 PM

dim added a comment to D45409: vm_phys: reduce touching of page->pool fields.

In D45409#1112419, @jrtc27 wrote:

This should be fixed by 4015ff43cbbe

Jan 31 2025, 7:02 PM

dim added a comment to D45409: vm_phys: reduce touching of page->pool fields.

In D45409#1111300, @pho wrote:

FYI: I came across this i386 problem after commit 0078df5f0258.

Trying to mount root from ufs:/dev/vtbd0p1 [rw]...
WARNING: WITNESS option enabled, expect reduced performance.
WARNING: DIAGNOSTIC option enabled, expect reduced performance.
WARNING: 32-bit kernels are deprecated and may be removed in FreeBSD 15.0.
panic: vm_page_t 0x5d49be0 phys_addr mismatch ffffffffb8779000 00000000b8779405
cpuid = 3
time = 1738177579
KDB: stack backtrace:
db_trace_self_wrapper(7,114beb40,5d49be0,ffffffff,ffffffff,...) at db_trace_self_wrapper+0x28/frame 0x113f6744
vpanic(148badd,113f6780,113f6780,113f67f0,13a54e9,...) at vpanic+0xf4/frame 0x113f6760
panic(148badd,5d49be0,b8779000,ffffffff,b8779405,...) at panic+0x14/frame 0x113f6774
pmap_pae_remove_pages(114128e8) at pmap_pae_remove_pages+0x599/frame 0x113f67f0
exec_new_vmspace(113f6994,188247c) at exec_new_vmspace+0x1cb/frame 0x113f6810
exec_elf32_imgact(113f6994,16d4801,113f6984,0,0,...) at exec_elf32_imgact+0x5e4/frame 0x113f6874
kern_execve(114beb40,113f6a8c,0,1141284c) at kern_execve+0x72c/frame 0x113f6a74
sys_execve(114beb40,114bedf0,114beb40,13ae913,114bede4,...) at sys_execve+0x4e/frame 0x113f6ac8
syscall(113f6ba8,3b,3b,3b,402aaf,...) at syscall+0x1e6/frame 0x113f6b9c
Xint0x80_syscall() at 0xffc03479/frame 0x113f6b9c
--- syscall (59, FreeBSD ELF32, execve), eip = 0x47e53f, esp = 0xffbfe848, ebp = 0xffbfe858 ---
KDB: enter: panic
[ thread pid 17 tid 100080 ]
Stopped at      kdb_enter+0x34: movl    $0,kdb_why
db> x/s version
version:        FreeBSD 15.0-CURRENT #0 main-n275068-0078df5f0258-dirty: Wed Jan 29 18:44:45 CET 2025\012    pho@mercat1.netperf.freebsd.org:/mnt25/obj/usr/src/i386.i386/sys/PHO\012
db>

Jan 31 2025, 6:28 PM