User Details
- User Since
- Jan 7 2014, 10:13 PM (636 w, 4 d)
Fri, Mar 20
Thu, Mar 19
Yeah, this looks fine to me. (Though I got confused initially by the _int suffix, until I understood that it's shorthand for internal... I was mislead by the int argument)
Hm, at first I was confused because TOOLS_PREFIX seems to be tested in the first .if statement, but that is only for the tblgen tools. But LGTM.
Mon, Mar 16
LGTM, if there is any ports fallout it is easy to revert.
Fri, Mar 13
Thu, Mar 12
Fri, Mar 6
LGTM
I'm fine with this, but what is the motivation? Easier packaging?
Wed, Mar 4
Wed, Feb 25
Sounds reasonable to me, but I'm not a ports committer. :)
Mon, Feb 23
Feb 16 2026
Feb 15 2026
Feb 12 2026
Feb 10 2026
Feb 7 2026
LGTM
Feb 2 2026
Feb 1 2026
Jan 31 2026
Jan 29 2026
Jan 26 2026
Jan 25 2026
Indeed, the libc++ headers are extremely noisy with g++. Upstream does not care about compiling with -Wsystem-headers, so it's extremely unlikely these warnings will ever be fixed.
LGTM. Weird that I didn't see this one with clang 21, which also has the same warnings about __nonstring. But maybe I just didn't run this test?
LGTM (this will give a minor conflict in my llvm-21-update branch, but I'll fix that there :)
Jan 23 2026
Jan 16 2026
Initialize sum to zero instead, otherwise we get a "unused variable
'sum'" warning, which also breaks the build.