Add in diff-extensions = -r -N -u30 -p -x -U9999 to .subversion/config so I don't forget to add more context.

This patch adds GTK2/GTK3 as radio options instead of a possible checking of both.

PR opened for this 207822
Stop using reviews as it's getting confusing reviews -> pr's and vice versa so submit PRs instead.

Seems fine now PR is opened for this as 207674

I forgot I submitted a PR for this and asked vg@ if he could take care of it.

Commited.

In D5575#119189, @mat wrote:

Also, I have to ask, are you using code reviews in place of bugzilla ? Do you assume a committer will commit this when it's ok ?

Fixes in formatting and suggestions from mat

• Update patch remove @comment from pkg-plist
• svn diff from home port rather than testing port
• svn diff using pdiff alias for ports which does diff -x -U9999

Lack of interest.

Ah thanks.

Updated patch as per jgh comment on igor
ignor now passes without any issues.

Update REGEX to not be plural as suggested by koobs

% find /backup/ports/ -name "Makefile" -exec grep REGEX_DESC {} + | wc -l

5

%

would this not break every port now that has a REGEX_DESCR= listed ?

Update bsd.options.desc.mk to include REGEX and make changes to suite.

Can I tell the commiter to commit this ?

Does phabricator do any formating? cause it looks fine on

Update formating and closing of </indexterm>

In D5527#118390, @mat wrote:

no problem, I'm the one stupid enough to have asked phabricator to subscribe me to every ports review, might as well do something with it :-)

Thank you mat for taking the time to help me update irc/scrollz ..

Update patch to remove PLIST= .. DATADIR.. tested with make check-plist.

Fix typo --with-ssil --with-ssl pointed out by Barnerd on IRC

Remove m0n0

In D5528#118354, @wblock wrote:

The m0n0wall section ought to mention that the project has ended.

Sorry got caught on irc/scrollz

I need to mention that the Options things and the pkg-desc edit was originally taken from Barnerd's review.
https://reviews.freebsd.org/D4847

http://pkgs.bsdjunk.com/data/10amd64-cpet/2016-03-03_17h31m56s/logs/ScrollZ-2.3.log

Hopefully this is the last one :)

Sorry I understand now,

I fixed it by re adding the older bits:

I'll do it give me a sec.

however that shouldn't matter as %%DATADIR%% =PREFIX/share/PORTNAME.

that's fine, kinda why I created this review rather than create a PR.

Update with options from Barnerd and pkg-plist update. however I am unsure why it fails now
http://pkgs.bsdjunk.com/data/10amd64-cpet/2016-03-03_10h49m25s/logs/errors/ScrollZ-2.3.log

comments

Update patch to change orientation of DISTVERSIONPREFIX

Update patch to diff -x -U9999 as I didn't see the - in -U

scrollz-2.3 depends on file: /usr/local/sbin/pkg - found
ScrollZ-scrollz-ScrollZ-2.3_GH0.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
Attempting to fetch https://codeload.github.com/ScrollZ/scrollz/tar.gz/ScrollZ-2.3?dummy=/ScrollZ-scrollz-ScrollZ-2.3_GH0.tar.gz
ScrollZ-scrollz-ScrollZ-2.3_GH0.tar.gz 100% of 958 kB 922 kBps 00m01s
Fetching all distfiles required by scrollz-2.3 for building

No one seems interested.

No one seems interested.

n/a

PR: 206845

Could we try and rework this a bit or does everyone feel it doesn't need to be changed?

Abandon as having a chat with a friend mentions Proximos is correct however I will create a new revision with the proper punctuation as ?? is wrong should be ¿? to be politically correct.

Ok

@imp should I submit a PR for this?

:)

Reply to Edits

Reply to comment

Jenkins link gives a 404 Error?

In D3363#74436, @wblock wrote:

If this is done, it should be done in the external stylesheet, not hard-coded in the HTML. However, there is only a single paragraph in that text on the main page, so it does not seem necessary to help the user identify paragraph breaks.

Our other text uses increased line spacing between paragraphs. Indents might be better there, I have not considered it before.

Done

Update as per bcr

Thank you.

Thank you

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206765

i will submit a pr then thanks

add in new patch as per wblock so I learn to do it right.

Is the dir depth correct ? or should I do an diff on en_* instead of htdocs?

That works

lets just add in a ascii groff and call it a day.

This is the same as saying "please contact us for any furthers issues you may have.." would it not? its basically being polite

Nice to see this is finally getting some love, thank you :)

@wblock can I use that image ?

You may do as you wish, as stated in msg have stopped working on this. I only updated the patch to include a screenshot in my original patch as requested.

Using the links in lynx, w3m, links will work with just www. no need for https://. Clicking on a link using most terminals such as xfce, gnome will still click and goto the www. no need for https://. Most browsers these days don't even show the http:// on the url bar. which kinda makes your point irrelevant. Also removing the https:// allows the last line to be indented and properly formatted like the rest.

Remove indications of https:// the site will auto goto https:// only if this is to indicate the site is secure? Also testing this on gnome/xfce terminal the www.* are still linkable. This will now allow the first patch to be below the 80char limit.

Also makes no sense to add in "FreeBSD *" and then for the list not have it. Changing it to FreeBSD List would allow my patch "work" and make it perdy.

Simplify patch just add a few spaces to the lists link

link to test is here:
http://bsdjunk.com/~chris/d3363/

Working diff

link to why I decided to invest time and change this.
http://webdesign.about.com/od/csstutorials/qt/indent-paragraphs-css.htm