Readd irc/smuxi

[chris_bsdjunk.com]

Summary

• Update port to 1.0.3
• Add maintainer to [e-mail]
• Add in front end options
• Add in pkg-plist PLIST_SUBS (%% %%) for GNOME/STFL
• portlint -A passes

Test Plan

svn co http://svn.freebsd.org/ports/head/irc/smuxi@323759
As base
And update to suite new version.

Poudriere:
Gnome:
http://pkgs.bsdjunk.com/build.html?mastername=10amd64-cpet&build=2016-03-07_16h37m16s
SFTL:
http://pkgs.bsdjunk.com/build.html?mastername=10amd64-cpet&build=2016-03-07_16h37m16s

Now it just needs a few refinements

[mat]

irc/smuxi/Makefile

23

What does that do ?

25

why += ?

45

?

irc/smuxi/pkg-plist

2

Please remove that.

[chris_bsdjunk.com]

• Update patch remove @comment from pkg-plist
• svn diff from home port rather than testing port
• svn diff using pdiff alias for ports which does diff -x -U9999

[chris_bsdjunk.com]

This comment was removed by chris_bsdjunk.com.

[mat]

irc/smuxi/Makefile

23

Should be LOCALBASE, not PREFIX.

40–42

This should be done by USES=pathfix.

44

?

[chris_bsdjunk.com]

Fixes in formatting and suggestions from mat

[mat]

Also, I have to ask, are you using code reviews in place of bugzilla ? Do you assume a committer will commit this when it's ok ?

irc/smuxi/pkg-plist

342

What tool did you use to generate the plist ? This line should never have been in it.

[chris_bsdjunk.com]

In D5575#119189, @mat wrote:

Also, I have to ask, are you using code reviews in place of bugzilla ? Do you assume a committer will commit this when it's ok ?

Basically that is correct.

irc/smuxi/pkg-plist

342

Well poudriere never complained about it so I never touched it.

[chris_bsdjunk.com]

PR opened for this 207822
Stop using reviews as it's getting confusing reviews -> pr's and vice versa so submit PRs instead.