Page MenuHomeFreeBSD

Readd irc/smuxi
AbandonedPublic

Authored by chris_bsdjunk.com on Mar 7 2016, 11:54 PM.
Tags
None
Referenced Files
F89171020: D5575.diff
Wed, Jul 24, 8:38 AM
Unknown Object (File)
Jun 17 2024, 11:11 PM
Unknown Object (File)
May 14 2024, 3:55 PM
Unknown Object (File)
May 14 2024, 3:26 PM
Unknown Object (File)
Apr 6 2024, 2:49 AM
Unknown Object (File)
Apr 6 2024, 2:30 AM
Unknown Object (File)
Apr 5 2024, 8:28 PM
Unknown Object (File)
Feb 15 2024, 8:36 PM

Details

Reviewers
None
Summary
  • Update port to 1.0.3
  • Add maintainer to freebsd@smuxi.im
  • Add in front end options
  • Add in pkg-plist PLIST_SUBS (%% %%) for GNOME/STFL
  • portlint -A passes
Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chris_bsdjunk.com retitled this revision from to Readd irc/smuxi.
chris_bsdjunk.com updated this object.
chris_bsdjunk.com edited the test plan for this revision. (Show Details)
chris_bsdjunk.com set the repository for this revision to rP FreeBSD ports repository.
irc/smuxi/Makefile
22

What does that do ?

24

why += ?

44

?

irc/smuxi/pkg-plist
1

Please remove that.

chris_bsdjunk.com removed rP FreeBSD ports repository as the repository for this revision.
chris_bsdjunk.com marked 4 inline comments as done.
  • Update patch remove @comment from pkg-plist
  • svn diff from home port rather than testing port
  • svn diff using pdiff alias for ports which does diff -x -U9999
irc/smuxi/Makefile
23

Should be LOCALBASE, not PREFIX.

40–42

This should be done by USES=pathfix.

44

?

chris_bsdjunk.com marked 3 inline comments as done.

Fixes in formatting and suggestions from mat

Also, I have to ask, are you using code reviews in place of bugzilla ? Do you assume a committer will commit this when it's ok ?

irc/smuxi/pkg-plist
343

What tool did you use to generate the plist ? This line should never have been in it.

In D5575#119189, @mat wrote:

Also, I have to ask, are you using code reviews in place of bugzilla ? Do you assume a committer will commit this when it's ok ?

Basically that is correct.

irc/smuxi/pkg-plist
343

Well poudriere never complained about it so I never touched it.

PR opened for this 207822
Stop using reviews as it's getting confusing reviews -> pr's and vice versa so submit PRs instead.