Page MenuHomeFreeBSD

irc/scrollz: Update to Github and fix SSL
AbandonedPublic

Authored by brnrd on Jan 10 2016, 10:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 13, 8:15 AM
Unknown Object (File)
Wed, Jun 5, 9:42 AM
Unknown Object (File)
Mon, Jun 3, 11:08 AM
Unknown Object (File)
Sun, Jun 2, 11:27 AM
Unknown Object (File)
Thu, May 30, 5:14 AM
Unknown Object (File)
May 13 2024, 3:47 PM
Unknown Object (File)
May 13 2024, 10:42 AM
Unknown Object (File)
May 13 2024, 7:08 AM
Subscribers
None

Details

Reviewers
koobs
feld
Summary

Proposed commit log

irc/scrollz: Update to 2.3

  - Update to 2.3 including No-SSLv3 fix [1]
  - Update pkg-descr www URL (Project website moved)
  - Use GitHub for DISTFILES (Sources moved to GitHub)
  - Force manpage to install in ${MANDIR}/man1
  - Options-ify ipv6, regex, utf-8

PR:		203698 [1]
Reviewed_by:	feld (mentor), koobs (mentor)
Approved by:	(mentor)
Differential_Revision:	D4847
Test Plan
  • portlint -AC (minus warning for reworked Makefile.in patch)
  • poudriere testport OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2472
Build 2489: arc lint + arc unit

Event Timeline

brnrd retitled this revision from to irc/scrollz: Update to Github and fix SSL.
brnrd updated this object.
brnrd edited the test plan for this revision. (Show Details)
brnrd added reviewers: koobs, feld.
brnrd edited the test plan for this revision. (Show Details)
koobs requested changes to this revision.Jan 10 2016, 11:17 AM
koobs edited edge metadata.
koobs added inline comments.
irc/scrollz/files/patch-Makefile.in
50

Why was this change necessary?

81

Can you use the CONFIGURE_ARGS --mandir for this?

This revision now requires changes to proceed.Jan 10 2016, 11:17 AM
brnrd added inline comments.
irc/scrollz/files/patch-Makefile.in
50

Fixed. Typo when re-rolling the patch.

81

Added --mandir=${MANDIR}/man1 only to find out that ports framework adds another --mandir=${MANDIR} to the ARGS and the last one is used by configure.

irc/scrollz/Makefile
16–19

I propose OPTIONS for these

20

Use version repository tags where they exist, with DISTVERSION{PREFIX,SUFFIX} if necessary

https://github.com/ScrollZ/ScrollZ/tree/sz2.2.3

irc/scrollz/files/patch-Makefile.in
81

So, this change is not needed anymore?

81

So this change is not needed then?

brnrd edited edge metadata.
brnrd marked 6 inline comments as done.

Update patches

  • CONFIGURE_ON to CONFIGURE_WITH
  • Fix typo in Makefile.in
irc/scrollz/Makefile
20

The whole objective was to go beyond the released version 2.2.3 as 'master' can actually connect with TLS, verify cert and fixes the No-SSLv3 issue. Requested project to roll a release
https://github.com/ScrollZ/ScrollZ/issues/17
Diff between 2.2.3 and master is too large to backport. Chose this tag as to mark current state of master.

irc/scrollz/files/patch-Makefile.in
81

Still required, otherwise man-page is installed in /usr/local/man/scrollz.1

irc/scrollz/Makefile
36–37

This will add --without-openssl=${OPENSSL} in the OFF case, instead of just --without-openssl.

In most cases this wont work.

Probably better to use OPENSSL_CONFIGURE_{ON,OFF} here

koobs requested changes to this revision.Jan 10 2016, 2:21 PM
koobs edited edge metadata.
koobs added inline comments.
irc/scrollz/Makefile
20

Then it's not really 2.2.3 any more as users would/should expect.

I'm not comfortable with inaccurate PORTVERSIONS.

Perhaps we should consider a DISTVERSION=2.2.3-<tag> ?

This revision now requires changes to proceed.Jan 10 2016, 2:21 PM
brnrd edited edge metadata.

Revert SSL configure changes and add date version suffix

brnrd edited edge metadata.

Fix references to PORTVERSION

brnrd added inline comments.
irc/scrollz/Makefile
20

Agreed. Fixed by suffixing the commit date.

36–38

Good catch, hadn't thought of that! Fixed.