irc/scrollz: Update to Github and fix SSL

[brnrd]

Summary

Proposed commit log

irc/scrollz: Update to 2.3

  - Update to 2.3 including No-SSLv3 fix [1]
  - Update pkg-descr www URL (Project website moved)
  - Use GitHub for DISTFILES (Sources moved to GitHub)
  - Force manpage to install in ${MANDIR}/man1
  - Options-ify ipv6, regex, utf-8

PR:		203698 [1]
Reviewed_by:	feld (mentor), koobs (mentor)
Approved by:	(mentor)
Differential_Revision:	D4847

Test Plan

• portlint -AC (minus warning for reworked Makefile.in patch)
• poudriere testport OK

[koobs]

irc/scrollz/files/patch-Makefile.in

50

Why was this change necessary?

81

Can you use the CONFIGURE_ARGS --mandir for this?

[brnrd]

irc/scrollz/files/patch-Makefile.in

50

Fixed. Typo when re-rolling the patch.

81

Added --mandir=${MANDIR}/man1 only to find out that ports framework adds another --mandir=${MANDIR} to the ARGS and the last one is used by configure.

[koobs]

irc/scrollz/Makefile

16–20

I propose OPTIONS for these

20

Use version repository tags where they exist, with DISTVERSION{PREFIX,SUFFIX} if necessary

https://github.com/ScrollZ/ScrollZ/tree/sz2.2.3

irc/scrollz/files/patch-Makefile.in

81

So, this change is not needed anymore?

81

So this change is not needed then?

[brnrd]

Update patches

• CONFIGURE_ON to CONFIGURE_WITH
• Fix typo in Makefile.in

irc/scrollz/Makefile

20

The whole objective was to go beyond the released version 2.2.3 as 'master' can actually connect with TLS, verify cert and fixes the No-SSLv3 issue. Requested project to roll a release
https://github.com/ScrollZ/ScrollZ/issues/17
Diff between 2.2.3 and master is too large to backport. Chose this tag as to mark current state of master.

irc/scrollz/files/patch-Makefile.in

81

Still required, otherwise man-page is installed in /usr/local/man/scrollz.1

[koobs]

irc/scrollz/Makefile

37–38

This will add --without-openssl=${OPENSSL} in the OFF case, instead of just --without-openssl.

In most cases this wont work.

Probably better to use OPENSSL_CONFIGURE_{ON,OFF} here

[koobs]

irc/scrollz/Makefile

20

Then it's not really 2.2.3 any more as users would/should expect.

I'm not comfortable with inaccurate PORTVERSIONS.

Perhaps we should consider a DISTVERSION=2.2.3-<tag> ?

[brnrd]

Revert SSL configure changes and add date version suffix

[brnrd]

Fix references to PORTVERSION

[brnrd]

irc/scrollz/Makefile

20

Agreed. Fixed by suffixing the commit date.

37–39

Good catch, hadn't thought of that! Fixed.

[brnrd]

Update to version 2.3

[brnrd]

Has been updated in D5262