In D54657#1262977, @dave_freedave.net wrote:

Thanks Adam! I think its ready for commit now.

This looks great, Dave! Are you ready for me to commit it?

In D54657#1262354, @dave_freedave.net wrote:

Actually I just hit the same test failure pkg-fallout had emailed me about. bee has a test here that I don't believe is correct.

sleep(3) does not promise to return within 1 seconds (or indeed any amount) of time after your requested sleep amount has elapsed. I'm sure it usually is going to be within 1 second, but I think this is a bad test.

In D54657#1253184, @dave_freedave.net wrote:

Here is what you are going to need if you want lua-language-server to pick up symbols when editing your neovim config:
[...]

So, here's the deal. This patch looks great, it tests perfectly for me, and I'm happy to commit it. Just give me a sign when you're ready and I'll make it happen.

So, here's the deal. This patch looks great, it tests perfectly for me, and I'm happy to commit it. Just give me a sign when you're ready and I'll make it happen.

Updated a comment to be correcter.

Thank you for all your patience. 2026 has been.... difficult.

In D54260#1240189, @dave_freedave.net wrote:

I think we can safely go NO_ARCH= yes. Is that urgent or can it wait for (ideally both of):

I've committed this, but I noticed something in the build logs:

It looks good to me, Dave, so let me know when your testing is done and you’re ready to get it committed.

Great work on this! I made two [edit: counting is hard] small changes:

In D54104#1238865, @fuz wrote:

In D54104#1238790, @adamw wrote:

One question: should go:1.24 just mean go:1.24+? Do we foresee any reason that go:1.24 should bring in 1.24 when GO_VERSION == 1.25? Or would that lead to confusion?

You two have completely flipped me on the correct approach, and I'm now all-in on go.mk bringing in the right version for FreeBSD.org, not go.dev. I'm now wondering whether + should be more than just an optional feature. What do you two think?

There can be rare cases where the newer toolchain doesn't work, so it seems sensible to keep the syntax without a + around as an exact version match. That said, users should be encouraged to use lower bounds if at all possible.

One question: should go:1.24 just mean go:1.24+? Do we foresee any reason that go:1.24 should bring in 1.24 when GO_VERSION == 1.25? Or would that lead to confusion?

In D54116#1238484, @diizzy wrote:

How many ports does this actually affect as in does it make sense to add yet another USES helper? Ahh... about a hundred temporarily, I'm not sure if it's worth the effort then and handbook entry is missing too.

Just on inspection, this looks good. I'll get it committed this evening.

Good test plan! I also find :checkhealth to be helpful, if you bring up a buffer with lua_ls attached.

In D54117#1236469, @des wrote:

The manual page already has two entire paragraphs about the past and present differences between shutdown and reboot, and they are not equivalent.

Some ideas for next steps:

In D54055#1236570, @dave_freedave.net wrote:

In D54055#1236567, @adamw wrote:

There it is! It's looking great, Dave. I'm just doing some final tests and--barring anything wacky--I'll get it committed shortly.

I feel like I just got the "Sensei Ishikawa" treatment. Where you look up at the hill with footholds while I start climbing... only to find you on the top of the hill that you walked around to the gentle path up the hill. But you know, it worked: I'm sold. I will be using poudriere going forward.