Just on inspection, this looks good. I'll get it committed this evening.

Good test plan! I also find :checkhealth to be helpful, if you bring up a buffer with lua_ls attached.

In D54117#1236469, @des wrote:

The manual page already has two entire paragraphs about the past and present differences between shutdown and reboot, and they are not equivalent.

Some ideas for next steps:

In D54055#1236570, @dave_freedave.net wrote:

In D54055#1236567, @adamw wrote:

There it is! It's looking great, Dave. I'm just doing some final tests and--barring anything wacky--I'll get it committed shortly.

I feel like I just got the "Sensei Ishikawa" treatment. Where you look up at the hill with footholds while I start climbing... only to find you on the top of the hill that you walked around to the gentle path up the hill. But you know, it worked: I'm sold. I will be using poudriere going forward.

There it is! It's looking great, Dave. I'm just doing some final tests and--barring anything wacky--I'll get it committed shortly.

A request: for clarity, can reboot(8) explicitly say something to the effect of "reboot is equivalent to shutdown -r now"?

Dave, we're getting there, I promise!

@portmgr: I've not submitted one of these before. Could you please take a gander and let me know if I'm on the right path and should continue putting work into this? Or is there a better approach that I overlooked?

In D54055#1236307, @dave_freedave.net wrote:

If only I'd been slower. I prefer the file check but can add comment. Before I do though, is the check in 2 places acceptable?

In D54055#1236298, @dave_freedave.net wrote:

I only ran portclippy before. I'll go find portlint and track down the other errors too.

Totally forgot, I also have this guy:

Yikes! Thanks for bringing this port back to life.

Big 👍 from me

Dave: I did the following:

In D54055#1236171, @diizzy wrote:

Why not use https://github.com/LuaLS/lua-language-server/releases/download/3.16.0/lua-language-server-3.16.0-submodules.zip ?

For instance, setting USES=go:1.26+ will select lang/go-devel right now, and lang/go126 once it is created and GO_VALID_VERSIONS is updated accordingly.

In D54055#1235414, @dave_freedave.net wrote:

Oh relying upon the header file would also help in case inotify gets backported to stable/14 in the future.

So, what you have at the end there (the .if ${OSVERSION} < 15 block) feels like an antipattern, but I can't think of any better way to do it. I've tried out a couple alternatives and they just made it more complicated. At the end of the day, it's a valid approach and it works, and also it only needs to be in there until 14 goes EOL (now that 15 is out, 14 has a defined death day).

In D53824#1231777, @mat wrote:

You can advise people to not put a variable, but variables may need to happen from time to time.

In D53824#1229914, @portmaster_BSDforge.com wrote:

I'd like to suggest the use of the terms:
"string literal" and "string variable" as opposed to "literal text". As both a variable AND a literal are still after all,
"literally text". :-)

In D53800#1229686, @cperciva wrote:

In D53800#1228896, @adamw wrote:

@cperciva If you add vim and emacs, I'd happily give an approval from the ports side of things. (I'm no longer on portmgr, so not sure how much my +1 is worth to you.)

I don't think anyone else has suggested adding anything, so I'm happy to do this. Which ports exactly do you want added?

In D53800#1228881, @cperciva wrote:

KDE + freebsd-doc is already too big even if we remove everything else on the list.

In D53800#1228878, @mark_freebsdfoundation.org wrote:

Apologies for asking what might be a daft question then — but removing www/firefox, x11/gnome and x11-wm/sway doesn't make KDE fit, does it? (the question might be daft as I'm guessing you've tried umpteen permutations to make this work).

This was good info, everyone. Thank you, I learned a lot about the context here!

In D53800#1228648, @mark_freebsdfoundation.org wrote:

Colin, although I wouldn't pick KDE myself, I can't help but think since it's the desktop of choice in the upcoming addition to the installer (Alfonso's work) wouldn't it be more prudent to remove *all other* DEs/WMs from the DVD image (since they're all smaller anyway) and have just KDE on the DVD image? "You can't keep all the people happy all the time", but if we've settled on one DE [for starters] for the installer add on, I can't help thinking it would be useful for that desktop to be in the DVD image :)

I'm a big fan of being able to provide both KDE and gnome. How much would switching from gnome to gnome-lite save us?

They're the same toolchains. They're hashed and downloaded as part of do-fetch, from the same servers that Go itself is distributed, so theoretically they should carry the same risk as the Go ports.

Does this option also prevent it from behaving like an older version of the toolchain, or does it only affect forward behaviour?