In D54260#1240189, @dave_freedave.net wrote:

I think we can safely go NO_ARCH= yes. Is that urgent or can it wait for (ideally both of):

I've committed this, but I noticed something in the build logs:

It looks good to me, Dave, so let me know when your testing is done and you’re ready to get it committed.

Great work on this! I made two [edit: counting is hard] small changes:

In D54104#1238865, @fuz wrote:

In D54104#1238790, @adamw wrote:

One question: should go:1.24 just mean go:1.24+? Do we foresee any reason that go:1.24 should bring in 1.24 when GO_VERSION == 1.25? Or would that lead to confusion?

You two have completely flipped me on the correct approach, and I'm now all-in on go.mk bringing in the right version for FreeBSD.org, not go.dev. I'm now wondering whether + should be more than just an optional feature. What do you two think?

There can be rare cases where the newer toolchain doesn't work, so it seems sensible to keep the syntax without a + around as an exact version match. That said, users should be encouraged to use lower bounds if at all possible.

One question: should go:1.24 just mean go:1.24+? Do we foresee any reason that go:1.24 should bring in 1.24 when GO_VERSION == 1.25? Or would that lead to confusion?

In D54116#1238484, @diizzy wrote:

How many ports does this actually affect as in does it make sense to add yet another USES helper? Ahh... about a hundred temporarily, I'm not sure if it's worth the effort then and handbook entry is missing too.

Just on inspection, this looks good. I'll get it committed this evening.

Good test plan! I also find :checkhealth to be helpful, if you bring up a buffer with lua_ls attached.

In D54117#1236469, @des wrote:

The manual page already has two entire paragraphs about the past and present differences between shutdown and reboot, and they are not equivalent.

Some ideas for next steps:

In D54055#1236570, @dave_freedave.net wrote:

In D54055#1236567, @adamw wrote:

There it is! It's looking great, Dave. I'm just doing some final tests and--barring anything wacky--I'll get it committed shortly.

I feel like I just got the "Sensei Ishikawa" treatment. Where you look up at the hill with footholds while I start climbing... only to find you on the top of the hill that you walked around to the gentle path up the hill. But you know, it worked: I'm sold. I will be using poudriere going forward.

There it is! It's looking great, Dave. I'm just doing some final tests and--barring anything wacky--I'll get it committed shortly.

A request: for clarity, can reboot(8) explicitly say something to the effect of "reboot is equivalent to shutdown -r now"?

Dave, we're getting there, I promise!

@portmgr: I've not submitted one of these before. Could you please take a gander and let me know if I'm on the right path and should continue putting work into this? Or is there a better approach that I overlooked?

In D54055#1236307, @dave_freedave.net wrote:

If only I'd been slower. I prefer the file check but can add comment. Before I do though, is the check in 2 places acceptable?

In D54055#1236298, @dave_freedave.net wrote:

I only ran portclippy before. I'll go find portlint and track down the other errors too.

Totally forgot, I also have this guy:

Yikes! Thanks for bringing this port back to life.

Big 👍 from me

Dave: I did the following:

In D54055#1236171, @diizzy wrote:

Why not use https://github.com/LuaLS/lua-language-server/releases/download/3.16.0/lua-language-server-3.16.0-submodules.zip ?

For instance, setting USES=go:1.26+ will select lang/go-devel right now, and lang/go126 once it is created and GO_VALID_VERSIONS is updated accordingly.

In D54055#1235414, @dave_freedave.net wrote:

Oh relying upon the header file would also help in case inotify gets backported to stable/14 in the future.

So, what you have at the end there (the .if ${OSVERSION} < 15 block) feels like an antipattern, but I can't think of any better way to do it. I've tried out a couple alternatives and they just made it more complicated. At the end of the day, it's a valid approach and it works, and also it only needs to be in there until 14 goes EOL (now that 15 is out, 14 has a defined death day).