zine-ssg is a static site generator similar to www/gohugo. There is a companion port, devel/superhtml with review available at D55878.
Details
- Reviewers
adamw - Group Reviewers
Contributor Reviewers (ports)
In addition to make test, also ran poudriere testport -j FreeBSD15 -p local www/zine-ssg and will be attaching output.
/!\ zine-ssg-0.11.2: Makefile warnings, please consider fixing /!\ MASTER_SITES contains https://github.com/AFLplusplus/AFLplusplus/archive/:AFLplusplus https://github.com/allyourcodebase/AFLplusplus/archive/:AFLplusplus ... https://github.com/kristoff-it/ziggy/archive/:ziggy, please use USE_GITHUB instead.
I'm assuming that is harmless.
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
I think I got the CONFLICTS_INSTALL right (misc/zine also wants to install /usr/local/bin/zine).
Is it possible to fix the warning? If not that's fine.
| www/zine-ssg/Makefile | ||
|---|---|---|
| 21 | This should be DISTVERSIONPREFIX= v not GH_TAGNAME. | |
| 49 | If you wanted, this could also be written as cd ${BUILD_WRKSRC} && ${DO_MAKE_BUILD_TEST:N-d*:N--release=*} and avoid DO_MAKE_BUILD_TEST entirely. YMMV | |
| www/zine-ssg/pkg-descr | ||
| 9 | Is superhtml just to ease development? Or is it also of runtime benefit? If the former, I'd word that a little more clearly, and if the latter than maybe consider a SUPERHTML option? | |
| www/zine-ssg/pkg-descr | ||
|---|---|---|
| 9 | It just makes development easier. You don't have to have an LSP for zine. | |
Use DISTVERSIONPREFIX not GH_TAGNAME=v${...}.
remove DO_MAKE_BUILD_TEST for test-target.
I don't know how to get rid of the warning. I did a testbuild of zls to see if it had the issue too (it does). At that point I decided the issue is somewhere in Uses/zig.mk and I haven't had a chance to investigate.
| www/zine-ssg/Makefile | ||
|---|---|---|
| 49 | it was a little more involved. But I totally agree this is a better way that is less brittle to changes in Uses/zig.mk. | |
I had a foo target I was using to quickly check the modified DO_MAKE_BUILD for do-test. That needed to be removed!
| www/zine-ssg/Makefile | ||
|---|---|---|
| 14 | If that's the case it's not a BUILD_DEPENDS, | |
| www/zine-ssg/Makefile | ||
|---|---|---|
| 14 | Thank you! Now that you pointed it out, of course its TEST_DEPENDS. updated. | |