Page MenuHomeFreeBSD
Differential D55443

ports.7: Document DEFAULT_VERSIONS
ClosedPublic
Actions

Authored by ziaee on Sun, Feb 22, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 18, 4:34 AM
Unknown Object (File)
Tue, Mar 17, 3:06 AM
Unknown Object (File)
Fri, Mar 13, 5:34 PM
Unknown Object (File)
Wed, Mar 11, 1:22 PM
Unknown Object (File)
Wed, Mar 11, 9:47 AM
Unknown Object (File)
Mon, Mar 9, 3:59 PM
Unknown Object (File)
Sun, Mar 8, 3:25 AM
Unknown Object (File)
Sat, Mar 7, 4:26 PM
View All 21 Files
Subscribers
imp

Details

Reviewers
adamw
rene
kevans
arrowd
Commits
rG74aec9f02d9d: ports.7: Document DEFAULT_VERSIONS
Summary

MFC after: 3 days
Reported by: adamw

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ziaee created this revision.Sun, Feb 22, 6:42 PM
Herald added a subscriber: imp. · View Herald TranscriptSun, Feb 22, 6:42 PM
ziaee requested review of this revision.Sun, Feb 22, 6:42 PM
Harbormaster completed remote builds in B70883: Diff 172457.Sun, Feb 22, 6:42 PM
ziaee mentioned this in D55441: ports.7/FILES: Expand and refactor into 3 tables.Mon, Feb 23, 4:09 AM
adamw added a comment.EditedMon, Feb 23, 11:12 PM

I like this, but version … version reads a little oddly.

What about using “variant” for one of them? (Gotta credit my wife for that idea; I drew a blank lol)

ziaee updated this revision to Diff 172754.Thu, Feb 26, 7:04 AM

wordsmith

Harbormaster completed remote builds in B71021: Diff 172754.Thu, Feb 26, 7:04 AM
adamw added a comment.Sat, Feb 28, 9:53 PM

I spent a looooong time with ChatGPT working on phrasing. Why is this one so tough?!

What I came up with was: "Override the defaults for ports with selectable variants."?

Depending on length target, we could really clear it up for users by adding "such as database and compiler versions."

I dunno, folks. Maybe we should just say "DEFAULT_VERSIONS: Sets default versions" 🙄

ziaee updated this revision to Diff 172946.Sat, Feb 28, 10:05 PM

use database or compiler versions, i like that.
i like the text we've come up with so far otherwise.

Harbormaster completed remote builds in B71100: Diff 172946.Sat, Feb 28, 10:05 PM
adamw accepted this revision.Tue, Mar 3, 6:57 PM
In D55443#1272019, @ziaee wrote:

use database or compiler versions, i like that.
i like the text we've come up with so far otherwise.

"Variant ... variant" didn't feel good, but with the rest of the sentence, it now reads well. I like this change and I say go for it!

This revision is now accepted and ready to land.Tue, Mar 3, 6:57 PM
ziaee updated this revision to Diff 173267.Fri, Mar 6, 2:46 PM

Oops, the multiple variants was a typo. I actually want to use version
for the second one. Thanks for your attention to detail here!

This revision now requires review to proceed.Fri, Mar 6, 2:46 PM
Harbormaster completed remote builds in B71231: Diff 173267.Fri, Mar 6, 2:46 PM
adamw accepted this revision.Fri, Mar 6, 3:01 PM

Oh yeah, this is the one. 100% 👍 from me.

This revision is now accepted and ready to land.Fri, Mar 6, 3:01 PM
Closed by commit rG74aec9f02d9d: ports.7: Document DEFAULT_VERSIONS (authored by ziaee). · Explain WhyFri, Mar 6, 11:48 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rG74aec9f02d9d: ports.7: Document DEFAULT_VERSIONS.

Revision Contents
Changeset List

PathSize
share/
man/
man7/
4 lines

Diff 173282

View Options

share/man/man7/ports.7

Loading...