devel/lua-language-server: Update 3.16.1 => 3.17.1

[dave_freedave.net]

Summary

updating to latest version.

This uses a bee.lua based on lua 5.5 (not yet in ports). This means I've been wrong all along that this required lua:build in USES. I verified that in poudriere(8).

Test Plan

passes make test on stable/14, stable/15, main.
Also verified it from neovim against my config for all of the above versions.
That is where I discovered I now need a ~/.config/nvim/.luarc.json for latest version to get symbols.

[dave_freedave.net]

Removed files from patch that didn't actually change (just date change from when I ran make makepatch).

[dave_freedave.net]

Confirmed via poudriere testport that USES does not need lua:build as it only uses its own modified bee.lua which is now based on lua 5.5.

[dave_freedave.net]

{F141925403} is output from poudriere testport ... devel/lua-language-server.

[dave_freedave.net]

I decided to change a variable name to match the Uses/inotify.mk coming in D54116. That really just meant changing LINK_INOTIFY to INOTIFY_LIB. But while at it I wanted a better variable name for what I had set as INOTIFY, so it is now LM_INOTIFY_LINK.

If D54116 arrives first I have already tested the patch to switch to it (and will update this review):

--- Makefile    2026-01-12 06:21:43.155262000 -0300
+++ M   2026-01-12 06:37:51.898022000 -0300
@@ -10,7 +10,7 @@
 LICENSE=       MIT
 LICENSE_FILE=  ${WRKSRC}/LICENSE

-USES=          dos2unix ninja:make
+USES=          dos2unix inotify ninja:make
 DOS2UNIX_REGEX=        .*\.(cpp|h|lua|md|obj|json)
 USE_GITHUB=    yes
 GH_ACCOUNT=    LuaLS
@@ -82,12 +82,9 @@
 do-test:
        cd ${WRKSRC} && 3rd/luamake/luamake unit-test

-.include <bsd.port.options.mk>
+.include <bsd.port.mk>

-.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1500050
-LIB_DEPENDS+=  libinotify.so:devel/libinotify
+# `luamake' has its own syntax for linking of inotify library
+.if !empty(INOTIFY_PORT)
 LM_INOTIFY_LINK=       links = "inotify",
-INOTIFY_LIB=   -linotify
 .endif
-
-.include <bsd.port.mk>

[dave_freedave.net]

lua-language-server has updated before this could be committed. skipping ahead to latest release 3.17.1

NOTE: I can't tell if its nvim-lspconfig that changed or if its lua-language-server but there I now require a ..luarc.json in my ~/.config/nvim to correctly pick up symbols. It took me a while to track down which delayed me putting this up.

As LuaCATS did *not* change, I think it was an nvim-lspconfig update. Here is what you are going to need if you want lua-language-server to pick up symbols when editing your neovim config:

{
  "schema": "https://raw.githubusercontent.com/LuaLS/vscode-lua/master/setting/schema.json",
  "runtime": {
    "version": "LuaJIT",
     "path": [
       "?.lua",
       "?/init.lua"
     ],
    //"pathStrict": true
  },
  "workspace": {
    "library": [
      "$VIMRUNTIME",
      "${3rd}/luv/library",
    ],
    "checkThirdParty": false
  }
}

[dave_freedave.net]

re-ran poudriere testport -j FreeBSD15 -p local devel/lua-language-server

{F142736553}

[adamw]

devel/lua-language-server/Makefile

14

Everything else in DOS2UNIX_REGEX is alphabetized. It's a nothing thing, but you sure you want to break that pattern?

88

I love what you did here! You clearly read the Uses/inotify.mk patch I'd submitted, and you're using the appropriate variable name that that patch will export, If that was unintentional then don't tell me—I want to continue believing that you simply nailed it.

[adamw]

So, here's the deal. This patch looks great, it tests perfectly for me, and I'm happy to commit it. Just give me a sign when you're ready and I'll make it happen.

[adamw]

In D54657#1253184, @dave_freedave.net wrote:

Here is what you are going to need if you want lua-language-server to pick up symbols when editing your neovim config:
[...]

Yeah, LuaLS has gotten really picky about needing its environment set correctly. I'm really not sure why lspconfig doesn't have an option to set LuaLS up for neovim config editing.

I'd suggest putting the luarc into ${EXAMPLESDIR} (and adding an EXAMPLES option). You could even put a note about it in pkg-message. I do see your luarc has a comment in it though; does LuaLS handle JSONC?