I can't see any obvious problems, apart from the trivially repeated PORTREVISION thing, but I haven't had a chance to test properly just yet.

In D16716#357694, @koobs wrote:

@matthew Syntactical change looks fine, but I'd want to test dependents for compatibility given the major version bump. I'd expect to find some that pinned pbr to < 4

Adding a 'dummy-run' mode -- so it will report on what would be changed without modifying anything on disk -- would be useful.
Bonus points if you run that as a one of the daily periodic jobs.

Committed in r51962

This looks ready to commit now.

Looks good, except for the bit about listing jhb under alumni for 2016--2018 -- he's still an active core member.

Actually, here's the new key signed by the old core-secretary key and by my own personal key:

-----BEGIN PGP PUBLIC KEY BLOCK-----

What mat said. Always use PY_FLAVOR for python dependencies.

Approved, subject to addressing my latest comments.

Test builds with the USER option selected are failing when trying to create the tcpdump group due to a malformed GIDs line.
Fixing that locally means everything builds OK, although there is this warning at the end of the configure phase:

This is good, but you need to add the last bit that will create the special user when the package is installed.

Can you add a VuXML entry (will need yet another review...) /before/ you commit here -- add the VuXML Id under the Security: tag in the commit message for this.
Also, don't forget to add MFH: 2018Q2. Once ports-secteam approves, you're approved for the merge to the quarterly branch too.

I can't reproduce whatever pkg-fallout was unhappy about.

Yes, everything builds just fine on 10.4 and 11.1, which are the currently supported versions.

In D15271#322013, @leres wrote:

In D15271#322012, @matthew wrote:

Test builds I ran overnight all failed on 10.3-RELEASE due to 'bad C++ code' in many of the dependencies. Of course, since yesterday I should be testing on 10.4-RELEASE...

I spent the last few weeks upgrading ~50 systems from 10.3 to 11.1-RELEASE (starting with my build servers), should I create a 10.4-RELEASE jail to test with?

Test builds I ran overnight all failed on 10.3-RELEASE due to 'bad C++ code' in many of the dependencies. Of course, since yesterday I should be testing on 10.4-RELEASE...

Yes, you need a COMMENT line -- it's required in all ports. What you have is fine.