In D19960#429029, @jtl wrote:I agree with @bz about ideal process. I also agree with @kristof about the practical implications of this feature. :-)
Might a valid way forward be to write a draft, propose it, and see if anyone complains by the next IETF (July) before purging this?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 19 2019
Apr 19 2019
Apr 18 2019
Apr 18 2019
Apr 14 2019
Apr 14 2019
When sending a routing message, don't allow the user to set the
Apr 13 2019
Apr 13 2019
tuexen committed rS346182: When sending IPv4 packets on a SOCK_RAW socket using the IP_HDRINCL option,.
When sending IPv4 packets on a SOCK_RAW socket using the IP_HDRINCL option,
Apr 11 2019
Apr 11 2019
Fix an SCTP related locking issue. Don't report that the TCB_SEND_LOCK
Mar 26 2019
Mar 26 2019
Fix a double free of an SCTP association in an error path.
Mar 25 2019
Mar 25 2019
Initialize scheduler specific data for the FCFS scheduler.
Improve locking when tearing down an SCTP association.
tuexen committed rS345494: Fix the handling of fragmented unordered messages when using DATA chunks.
Fix the handling of fragmented unordered messages when using DATA chunks
Mar 24 2019
Mar 24 2019
Fix build issue for the userland stack.
Fox more signed unsigned issues. This time on the send path.
Fix a signed/unsigned bug when receiving SCTP messages.
Mar 23 2019
Mar 23 2019
tuexen committed rS345461: Limit the size of messages sent on 1-to-many style SCTP sockets with the.
Limit the size of messages sent on 1-to-many style SCTP sockets with the
Limit the number of bytes which can be queued for SCTP sockets.
Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial
Fix a KASSERT() in tcp_output().
Mar 8 2019
Mar 8 2019
Some cleanup and consistency improvements.
Mar 7 2019
Mar 7 2019
tuexen committed rS344872: After removing an entry from the stream scheduler list, set the pointers.
After removing an entry from the stream scheduler list, set the pointers
Mar 3 2019
Mar 3 2019
Allocate an assocition id and register the stcb with holding the lock.
Mar 2 2019
Mar 2 2019
Allow SCTP stream reconfiguration operations only in ESTABLISHED
Handle the case when calling the IPPROTO_SCTP level socket option
Use correct buffer sizes in sctp_get[lp]addrs().
Report the correct length when using the IPPROTO_SCTP level
Mar 1 2019
Mar 1 2019
Honor the memory limits provided when processing the IPPROTO_SCTP
Improve consistency, not functional change.
Feb 27 2019
Feb 27 2019
Looks good to me.
The unit would be milli seconds, not seconds for the sysctl-variable. In general, I agree that it would be good to give at least the unit for sysctl variables, but
Feb 25 2019
Feb 25 2019
In D18960#413211, @rscheff_gmx.at wrote:Quick comment: DSACKs are not working in HEAD. Potentially, the tlenp is set to zero for the duplicate segment, so that tcp_update_sack_list is not called to build the DSACK entry to the next ACK. If this is the reason, this patch may break DSACK in BSD11
This is not to be a shipstopper, but a heads-up as the DSACK not working may be related hereto...
Backport the new TCP reassembly code from head to stable/11.
Feb 23 2019
Feb 23 2019
In D18960#413211, @rscheff_gmx.at wrote:Quick comment: DSACKs are not working in HEAD. Potentially, the tlenp is set to zero for the duplicate segment, so that tcp_update_sack_list is not called to build the DSACK entry to the next ACK. If this is the reason, this patch may break DSACK in BSD11
This is not to be a shipstopper, but a heads-up as the DSACK not working may be related hereto...
Can you open a PR for this against head? Is it also broken in stable/12?
Feb 21 2019
Feb 21 2019
tuexen added inline comments to D19181: Improve input validation when when using IP_HDRINCL socket option on SOCK_RAW sockets.
tuexen updated the diff for D19181: Improve input validation when when using IP_HDRINCL socket option on SOCK_RAW sockets.
Integrate jtl@'s suggestion.
tuexen committed rS344433: The receive buffer autoscaling for TCP is based on a linear growth, which.
The receive buffer autoscaling for TCP is based on a linear growth, which
Merge r344428.
This patch addresses an issue brought up by bz@ in D18968:
Feb 20 2019
Feb 20 2019
Latest version tested again with running kcovtrace /usr/bin/uptime in a loop and in addition with running syzkaller. Both work fine.
tuexen added inline comments to D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
tuexen updated the diff for D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Address bz@'s comment.
tuexen retitled D19254: Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled from Avoid dereferencing a NULL point when TCP_REASS_LOGGING is enabled to Avoid dereferencing a NULL pointer when TCP_REASS_LOGGING is enabled.
Reduce the TCP initial retransmission timeout from 3 seconds to
Use exponential backoff for retransmitting SYN segments as specified
Using this version, the memory lockup observed does not occur anymore. Tested with running kcovtrace /usr/bin/uptime in a loop.
Feb 19 2019
Feb 19 2019
Feb 17 2019
Feb 17 2019
Hi Richard,
Feb 15 2019
Feb 15 2019
Fix a byte ordering issue for the advertised receiver window in ACK
Feb 13 2019
Feb 13 2019
Feb 12 2019
Feb 12 2019
Improve input validation for raw IPv4 socket using the IP_HDRINCL
Feb 11 2019
Feb 11 2019
Fix flags used when compiling kern_kcov.c and subr_coverage.c.
Follow Andrew's advice.
Feb 10 2019
Feb 10 2019
Use underscores instead of hyphens as suggested by Ed.
I tested this patch on a kernel build with clang in base and with the amd64-xtoolchain-gcc cross toolchain.
Fix a locking issue when reporing outbount messages.
tuexen committed rS343960: Fix a locking issue in the IPPROTO_SCTP level SCTP_PEER_ADDR_THLDS socket.
Fix a locking issue in the IPPROTO_SCTP level SCTP_PEER_ADDR_THLDS socket
Fix a locking bug in the IPPROTO_SCTP level SCTP_EVENT socket option.
Fix locking for IPPROTO_SCTP level SCTP_DEFAULT_PRINFO socket option.
Feb 9 2019
Feb 9 2019
Feb 8 2019
Feb 8 2019
Ensure that when using the TCP CDG congestion control and setting the
Feb 5 2019
Feb 5 2019
tuexen added a comment to D19071: Get TCP CDG CC working if net.inet.tcp.cc.cdg.smoothing_factor = 0 .
In D19071#408094, @lstewart wrote:Suggest moving stailq flush loops out of cdg_cb_destroy() into an inline function, changing smoothing_factor sysctl to a SYSCTL_PROC with custom handler similar to the exp_backoff_scale sysctl, and calling flush function from both cdg_cb_destroy() and sysctl handler when smoothing_factor is set to zero
tuexen committed rS343770: Only reduce the PMTU after the send call. The only way to increase it, is.
Only reduce the PMTU after the send call. The only way to increase it, is
tuexen committed rS343769: Fix an off-by-one error in the input validation of the SCTP_RESET_STREAMS.
Fix an off-by-one error in the input validation of the SCTP_RESET_STREAMS
Feb 4 2019
Feb 4 2019
Add missing SCTP_EOR entry.
Feb 3 2019
Feb 3 2019
Feb 1 2019
Feb 1 2019
When handling SYN-ACK segments in the SYN-RCVD state, set tp->snd_wnd
tuexen updated the diff for D19033: Initialise snd_wnd on the server side always before processing the ack.
Simplification of the fix within the RACK code.
Jan 31 2019
Jan 31 2019
tuexen added a comment to D19033: Initialise snd_wnd on the server side always before processing the ack.
In D19033#407072, @rscheff_gmx.at wrote:RACK seems to have a similar code in rack_do_syn_recv.
tuexen updated the diff for D19033: Initialise snd_wnd on the server side always before processing the ack.
Also fix the issue in the RACK stack.
Jan 30 2019
Jan 30 2019
Jan 28 2019
Jan 28 2019
Fix the detection of ECN-setup SYN-ACK packets.
Please apply the same fix to tcp_stacks/rack.c.