Thanks @koobs. :-)

Test files are missing in CHEESESHOP sdist xmodem-0.4.5.tar.gz, and GitHub is used for this port.

Thanks @koobs.

Thanks @koobs.

Should I add these ports maintainers to reviewers?
garga,romain,ultima,wg

These ports remain unchanged:

Here's a list of the ports that have the same description in bsd.options.desc.mk (changes are included in this diff):

Add {BZR,CVS,RSYNC}_DESC and a few ports changes

Change OPTION name MERCURIAL to HG

In D17459#388221, @koobs wrote:

Please also include the updates to any ports that use these OPTIONS in their Makefile's already (thereby leveraging the new shared descriptions)

In D16863#372727, @mat wrote:

In D16863#372445, @loader wrote:

In D16863#372358, @koobs wrote:

• "Why isn't USE_PYTHON=concurrent sufficient to not warrant these?"

The post-patch: target is to change tests.py to run subprocess of bin/bumpversion${UNIQUE_SUFFIX}
from the ${STAGEDIR} instead of ${PREFIX}/bin/bumpversion${UNIQUE_SUFFIX}, this allows running
tests without installing the ports.

Tests are always run after having installed the port.

In D16863#372358, @koobs wrote:

Missing responses to: https://reviews.freebsd.org/D16863?id=47167#369395 - In particular:

• "While we're here, maybe add shared descriptions for these in bsd.options.desc.mk`" onward

sort

remove GIT_DESC and MERCURIAL_DESC

Add new line.

Thanks @koobs. :-)

add a comment for post-patch target, add PYTHONPATH to TEST_ENV

Update ONLY_FOR_ARCHS_REASON message

Thanks @koobs :-)

Should I add LEGAL_TEXT= Redistribution is not permitted to pass the /usr/ports/Tools/scripts/LEGALlint check?

OPTIONS_DEFINE=DOCS EXAMPLES, files/LICENSE, LICENSE_PERMS=none, S|${LN}|${RLN}|, ONLY_FOR_ARCHS= order, delete RESTRICTED=

In D17255#367921, @koobs wrote:

We must be able to QA ports with poudriere, even when they're RESTRICTED, whilst also retaining the ability for the 'package building for distribution' use-case to no violate license terms.

A quick search shows:

poudriere's pkgclean command supports this argument:

-R -- Clean RESTRICTED packages after building,

poudriere.conf has the following options:

# Cleanout the restricted packages # NO_RESTRICTED=yes

This feels like RESTRICTED ports are build/packages like any other, though I don't know if/how this works with IGNORE set or coupled with the conditional check for the non-existence of the distfile

See Also:

https://github.com/freebsd/poudriere/commit/ecd4df93e8383341a2909c6dd72018de124ff945
https://github.com/freebsd/poudriere/commit/fe70c5eeb63fc837cc4f86455ce805f3b2817d39
https://github.com/freebsd/poudriere/commit/0539ddf95d9dd59cbd3355dc80d27b6e7e9f8252

Pinging @bdrewery who may be able to provide more insight on what the default poudriere state (allowances) are and how to, if we cant already, best achieve the goal of ports QA as a maintainer , whilst RESTRICTED = true with as little fiddling as possible.

PORTVERSION=5.04.07, s|http|https|, s|${DISTNAME}${EXTRACT_SUFX}|${DISTFILES}|, USES=shebangfix

Thanks, @koobs.

mercurial => hg

Add OPTIONS: GIT and MERCURIAL as RUN_DEPENDS

Thanks @koobs.

Delete LICENSE_FILE, delete PREFIX=/usr/local, replace install with $(BSD_INSTALL_PROGRAM), $(BSD_INSTALL_SCRIPT) and $(BSD_INSTALL_MAN).

replace ${LOCALBASE} with ${PREFIX}

In D16699#354871, @koobs wrote:

Accepted with port ordering change (it should go below USES)

Move NO_ARCH to the section after USE and USE_x

Thanks so much for your help @koobs. :-)

Update COMMENT and replace ${PYSETUP} with ${PYDISTUTILS_SETUP}

Sure, thanks @koobs. :-)

Thanks @koobs.