Page MenuHomeFreeBSD

mail/managesieve3: Implements an RFC-5804 Manage Sieve client
ClosedPublic

Authored by loader on Aug 13 2018, 7:56 AM.

Details

Summary

Proposed commit log message:

[NEW PORT]: mail/managesieve3: Implements an RFC-5804 Manage Sieve client

A pure Python client implementation of "A Protocol for Remotely
Managing Sieve Scripts", as defined in RFC-5804.

WWW: https://bitbucket.org/ericvsmith/managesieve3

Reviewed_by: koobs, mat
Approved by: koobs (mentor)
Differential_Revision: D16699
Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere: 1200075, [armv7, aarch64], 'BUILD_ALL_PYTHON_FLAVORS=1', [py27, py34, py35, py36, py37] tested)
  • unittest: OK (

Python2.7: pytest: Ran 13 tests in 0.015s OK
Python3.4: pytest: Ran 13 tests in 0.017s OK
Python3.5: pytest: Ran 13 tests in 0.017s OK
Python3.6: pytest: Ran 13 tests in 0.018s OK
Python3.7: pytest: Ran 13 tests in 0.017s OK
)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Accepted, with two minor review items that while aren't 'strictly' necessary, are good for consistency (both for individual ports, and against other similar ports)

Don't blame me for nit picking, your reviews are almost always perfect. :)

mail/py-managesieve3/Makefile
10 ↗(On Diff #46611)

Try to match setup.py (pypi) metadata exactly where possible:

This projects (short description) 'description' field is

Implements an RFC-5804 Manage Sieve client

If a projects metadata can/should be improved (especially for pkg-descr), send suggestions for improvements upstream

21 ↗(On Diff #46611)

Not a major issue/requirement, but use the ${PYDISTUTILS_SETUP} variable wherever possible. It is the explicitly setuptools-wrapped version of 'py.setup' that the framework implements.

This revision is now accepted and ready to land.Aug 13 2018, 9:30 AM

Update COMMENT and replace ${PYSETUP} with ${PYDISTUTILS_SETUP}

This revision now requires review to proceed.Aug 13 2018, 9:57 AM
loader retitled this revision from mail/managesieve3: Pure Python client for managing Sieve scripts to mail/managesieve3: Implements an RFC-5804 Manage Sieve client.EditedAug 13 2018, 9:59 AM
loader edited the summary of this revision. (Show Details)
loader marked 2 inline comments as done.

Thanks so much for your help @koobs. :-)

mail/py-managesieve3/Makefile
15 ↗(On Diff #46612)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

Accepted with port ordering change (it should go below USES)

This revision is now accepted and ready to land.Aug 13 2018, 1:23 PM

Move NO_ARCH to the section after USE and USE_x

This revision now requires review to proceed.Aug 13 2018, 1:28 PM
loader added inline comments.
mail/py-managesieve3/Makefile
15 ↗(On Diff #46612)

Thanks mat@.

I just submitted a patch for portlint:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230594

Accepted with port ordering change (it should go below USES)

Thanks @koobs.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 14 2018, 1:19 AM
This revision was automatically updated to reflect the committed changes.