Page MenuHomeFreeBSD

mail/mblaze: Unix utilities to deal with Maildir
ClosedPublic

Authored by loader on Aug 17 2018, 8:19 AM.

Details

Summary

Proposed commit log message:

[NEW PORT]: mail/mblaze: Unix utilities to deal with Maildir

The mblaze message system is a set of Unix utilities for processing and
interacting with mail messages which are stored in maildir folders.

WWW: https://github.com/chneukirchen/mblaze

Reviewed_by: koobs, mat
Approved by: koobs (mentor)
Differential_Revision: D16759
Test Plan
  • portlint: OK (looks fine.)
  • testport: OK (poudriere: 1200075, [armv7, aarch64, amd64], '', '' tested)
  • unittest: OK (

armv7: All tests successful.
aarch64: All tests successful.
amd64: All tests successful.
)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

loader created this revision.Aug 17 2018, 8:19 AM
loader edited the summary of this revision. (Show Details)Aug 17 2018, 8:21 AM
loader retitled this revision from mail/mblaze: Unix utilities to deal with Maildir<<Replace this line with your revision title> to mail/mblaze: Unix utilities to deal with Maildir.
mat added inline comments.Aug 17 2018, 9:17 AM
mail/mblaze/Makefile
13 ↗(On Diff #46822)

With multiple licenses, LICENSE_FILE gets applied to all licenses. It is best to always set LICENSE_FILE_<license>.

mail/mblaze/files/patch-GNUmakefile
8 ↗(On Diff #46822)

This is so wrong.

  • PREFIX is where the port installs itself
  • LOCALBASE is where the port dependencies are installed.
loader updated this revision to Diff 46827.Aug 17 2018, 10:01 AM

replace ${LOCALBASE} with ${PREFIX}

loader marked an inline comment as done.Aug 17 2018, 10:08 AM
loader added inline comments.
mail/mblaze/Makefile
13 ↗(On Diff #46822)

Actually, those licenses are just mentioned in this file,
should I delete the LICENSE_FILE line?
https://github.com/chneukirchen/mblaze/blob/master/COPYING

mail/mblaze/files/patch-GNUmakefile
8 ↗(On Diff #46822)

Okay, thanks @mat.

loader marked an inline comment as done.Aug 17 2018, 10:11 AM
mat added inline comments.Aug 17 2018, 10:43 AM
mail/mblaze/Makefile
13 ↗(On Diff #46822)

LICENSE_FILE(_*) should point to a file actually containing the licenses, so, yes, removing it would probably be better.

mail/mblaze/files/patch-GNUmakefile
20–21 ↗(On Diff #46827)

It would be better to use ${BSD_INSTALL_PROGRAM} and ${BSD_INSTALL_SCRIPT} so that this respects debug and strip flags.

loader updated this revision to Diff 46833.Aug 17 2018, 12:18 PM

Delete LICENSE_FILE, delete PREFIX=/usr/local, replace install with $(BSD_INSTALL_PROGRAM), $(BSD_INSTALL_SCRIPT) and $(BSD_INSTALL_MAN).

loader marked 2 inline comments as done.Aug 17 2018, 12:20 PM
loader added inline comments.
mail/mblaze/Makefile
13 ↗(On Diff #46822)

Thanks @mat.

loader marked an inline comment as done.Aug 17 2018, 12:21 PM
loader edited the summary of this revision. (Show Details)Aug 17 2018, 12:43 PM
koobs accepted this revision.Aug 20 2018, 1:19 AM
This revision is now accepted and ready to land.Aug 20 2018, 1:19 AM
This revision was automatically updated to reflect the committed changes.