@mw is there anything else that I need to do for this?

I have no idea on the internals, but some quick comments as I tried to read the code as-is.

In D19036#417431, @mw wrote:

In D19036#417396, @manu wrote:

It looks ok for me now but could you please separate the change for drivers and GENERIC kernel config ?
Thanks.

I'll do this when commiting, no need to resubmit. I need to only check if clearfog continues to work with this.

Latest code review comments. Added a newline before a return, and removed the extra boot verbose output.

Updated the diff to correctly set the cpu mask if the port is connected to an ethernet device.

I can confirm that the changes made to if_mvneta.c for doing switch detection work, and it correctly detects the switch. The switch ports and fixed-link speeds are also configured correctly. I missed part of the changes I need to make though, and that is if there is an ethernet device on the port, then we need to set the CPUPORT flag.

Removed the ESPRESSO kernel config and placed the appropriate devices in the arm64 GENERIC config.

I have not yet had a chance to verify this all works on my ESPRESSObin.

Thanks for the feedback! Will work on this shortly, travel and work have kept me busy.

I also have these changes up on Github at: https://github.com/freebsd/freebsd/compare/master...theasylum:fix/e6000sw-fdt if it is easier to review there due to more context. I did re-create the diff as requested by @manu with -U999, so hopefully that helps.

Updated to match style(9) thanks to @dteske's comment.