Committed in r518779

Sorry for the delay. Approved!

Thanks for noticing this. It clearly was an oversight on my part!

I forgot, there is also no need to bump geany PORTREVISION, since you're only adding a non default option. No need to force rebuilding the package/reinstalling.

Thanks for the patch. I'll commit it later, only changing the RUN_DEPENDS line.

In D22378#492040, @james.wright_digital-chaos.com wrote:

I don't much like having to add a slave port, so inverting the dependency sounds like best option.

In D22378#491515, @james.wright_digital-chaos.com wrote:

Hi again,

   Now that the port is avialable via the pkg repo, I noticed that
trying to install the new "geany-themes" package ignores the
"geany-gtk2" package if already installed and tries to install "geany"
(the gtk3 version) instead?

   Is there anything I can change in the port to depend on either
"geany" or "geany-gtk2" packages?

A quick test in a VM with XFCE shows no evident problem.

A quick test in a VM with XFCE shows no evident problem.

A quick test in a VM with XFCE shows no evident problem.

Fix CONFLICTS.

Update patch to apply cleanly to present tree.

In D22378#489434, @james.wright_digital-chaos.com wrote:

In D22378#489403, @madpilot wrote:

Thanks for this port, it looks like a good addition to the ports tree.

The port looks fine by reading it.

I'll test it and commit it once done with tests.

Thanks, that would be great!

I'm not precious over the maintainership of this port, would it make sense for you to take this one alongside all the other geany related ports which you maintain?

Thanks for this port, it looks like a good addition to the ports tree.

Sorry for the delay.

In D21919#482777, @madpilot wrote:

So, with XFCE 4.16, when it will come out, GTK2 support will have to die and ports depending on XFCE not being adapted will need to be marked broken and removed, I don't see any other option.

In D21919#482764, @woodsb02 wrote:

Hi madpilot,

It looks like the latest release of Xfce4-panel 4.15 has dropped support for Gtk2 plugins:
https://mail.xfce.org/pipermail/xfce-announce/2019-October/000794.html

Looks good to me.

In D21918#479005, @woodsb02 wrote:

No rush to this, just a thought that we should strive to:

1. Minimise footprint where it doesn’t sacrifice daily use functionality - rather not install GTK twice. To that end, I was going through an exercise to see if I could have Xfce and goodies installed without GTK2 - it wasn’t easy.
2. Those programs/plugins which have not moved to GTK3 yet tend to be stale/unmaintained, and should probably therefore be off by default, unless they are fundamental. Users can still elect to pkg install them manually.

In practice, this change doesn’t achieve #1 on its own, as GTK2 will need to be a run time dependency of the panel and garcon anyway, to allow users to manually elect to install these GTK2 programs/plugins.

Happy to take your direction on this.

This change would prevent any panel built with gtk2 from working, and, I am almost sure, would cause them to also fail to compile, so breaking the built of such components present in the tree.

Since this change is only about what the metaport depends on I have no "strong feelings" and don't see too much harm.

In D21723#477720, @bcr wrote:

Looks good to me, thanks. Do you want to commit that yourself or should a docs person do it (with the proper attributions, of course)?

Looks fine!