Page MenuHomeFreeBSD
Feed Advanced Search

Aug 5 2023

takahiro.kurosawa_gmail.com requested review of D41330: netlink: fix adding an interface route.
Aug 5 2023, 5:23 AM

Jun 21 2022

takahiro.kurosawa_gmail.com updated the test plan for D35536: arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF) etc..
Jun 21 2022, 12:34 PM
takahiro.kurosawa_gmail.com requested review of D35536: arp(8): use getifaddrs(3) instead of ioctl(SIOCGIFCONF) etc..
Jun 21 2022, 12:31 PM

Jun 11 2022

takahiro.kurosawa_gmail.com added a comment to D35456: ping6: fix "connect() ssend: Network is unreachable" errors.

@kp Thanks for the comment.
I don't know the detail, but the "NOTES" in ping.c states:

Jun 11 2022, 9:06 PM
takahiro.kurosawa_gmail.com added reviewers for D35456: ping6: fix "connect() ssend: Network is unreachable" errors: asomers, network.
Jun 11 2022, 7:28 AM
takahiro.kurosawa_gmail.com requested review of D35456: ping6: fix "connect() ssend: Network is unreachable" errors.
Jun 11 2022, 7:27 AM

May 28 2022

takahiro.kurosawa_gmail.com added inline comments to D35307: netinet6: fix proxy NDP.
May 28 2022, 10:41 AM
takahiro.kurosawa_gmail.com updated the diff for D35307: netinet6: fix proxy NDP.
  • Add lltable_delete_conditional() instead of lltable_flags_free().
  • Use lltable_delete_conditional() for purging in6_multi for solicited node multicast addresses.
  • Move out the sockaddr_dl setup code from nd6_ns_input() to a new function.
May 28 2022, 10:35 AM

May 27 2022

takahiro.kurosawa_gmail.com added inline comments to D35307: netinet6: fix proxy NDP.
May 27 2022, 11:17 AM
takahiro.kurosawa_gmail.com updated the diff for D35307: netinet6: fix proxy NDP.
  • Add the lltable.llt_flags member and LLT_ADDEDPROXY flag in it
  • Add lltable_flags_free() that frees LLEs with specified la_flags
  • Use lltable_flags_free() for freeing in6_multis in if_detach path
  • Add the test script
May 27 2022, 11:04 AM

May 26 2022

takahiro.kurosawa_gmail.com added inline comments to D35323: lltable: use sa_family_t instead of int for lltable.llt_af.
May 26 2022, 10:14 AM
takahiro.kurosawa_gmail.com updated the diff for D35323: lltable: use sa_family_t instead of int for lltable.llt_af.

Add the spare member to indicate explicit alignment.

May 26 2022, 10:13 AM
takahiro.kurosawa_gmail.com added inline comments to D35307: netinet6: fix proxy NDP.
May 26 2022, 9:59 AM
takahiro.kurosawa_gmail.com added reviewers for D35323: lltable: use sa_family_t instead of int for lltable.llt_af: melifaro, network.
May 26 2022, 9:45 AM
takahiro.kurosawa_gmail.com requested review of D35323: lltable: use sa_family_t instead of int for lltable.llt_af.
May 26 2022, 9:43 AM
takahiro.kurosawa_gmail.com added reviewers for D35322: lltable: introduce the llt_post_resolved callback: melifaro, network.
May 26 2022, 3:48 AM
takahiro.kurosawa_gmail.com requested review of D35322: lltable: introduce the llt_post_resolved callback.
May 26 2022, 3:48 AM
takahiro.kurosawa_gmail.com added a reviewer for D35307: netinet6: fix proxy NDP: melifaro.

Could you also add a test, verifying the actual behaviour? It should be relatively straight-forwarded, based on tests/sys/netinet6/forward6.sh (2 VNETs) && tests/sys/netinet6/ndp.sh (general NDP checks),

May 26 2022, 12:14 AM

May 24 2022

takahiro.kurosawa_gmail.com updated the diff for D35307: netinet6: fix proxy NDP.

Fix spell check warnings

May 24 2022, 11:41 AM
takahiro.kurosawa_gmail.com added reviewers for D35307: netinet6: fix proxy NDP: markj, network.
May 24 2022, 11:10 AM
takahiro.kurosawa_gmail.com requested review of D35307: netinet6: fix proxy NDP.
May 24 2022, 11:09 AM

May 12 2022

takahiro.kurosawa_gmail.com added reviewers for D35188: rtsock: fix buffer overrun (sockaddr misuse): melifaro, network.
May 12 2022, 11:29 PM
takahiro.kurosawa_gmail.com requested review of D35188: rtsock: fix buffer overrun (sockaddr misuse).
May 12 2022, 11:25 PM

Apr 13 2021

takahiro.kurosawa_gmail.com updated the diff for D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
  • changed the "mape" nvlist structure
  • updated the test for the review comments
Apr 13 2021, 1:15 AM

Apr 12 2021

takahiro.kurosawa_gmail.com added inline comments to D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
Apr 12 2021, 8:41 PM
takahiro.kurosawa_gmail.com updated the diff for D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
  • moved to the new nvlist-based implementation
  • removed timeout in the test
  • changed the manual page that map-e-portset is for MAP-E CE (avoid confusion with MAP-E BR)
Apr 12 2021, 9:29 AM
takahiro.kurosawa_gmail.com added reviewers for D29721: pfctl, libpfctl: introduce pfctl_pool to keep the user/kernel ABI: kp, network.
Apr 12 2021, 9:15 AM
takahiro.kurosawa_gmail.com requested review of D29721: pfctl, libpfctl: introduce pfctl_pool to keep the user/kernel ABI.
Apr 12 2021, 9:13 AM
takahiro.kurosawa_gmail.com added a comment to D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
In D29468#665332, @kp wrote:

Thinking about this some more, I think that what we want to do here is to introduce a pfctl_pool, for use in libpfctl / pfctl. Similar to how we already have struct pfctl_rule and struct pfctl_anchor.

Apr 12 2021, 4:10 AM

Apr 9 2021

takahiro.kurosawa_gmail.com added a comment to D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.

@kp thanks for notifying the changes.
I'd like to hear your idea for the following points to rebase the code to the nvlist-based implementation.

Apr 9 2021, 2:31 AM

Apr 7 2021

takahiro.kurosawa_gmail.com added a reviewer for D29622: pf tests: make synproxy and nat work correctly even if inetd is running: kp.
Apr 7 2021, 7:27 AM
takahiro.kurosawa_gmail.com requested review of D29622: pf tests: make synproxy and nat work correctly even if inetd is running.
Apr 7 2021, 7:24 AM

Mar 30 2021

takahiro.kurosawa_gmail.com updated the diff for D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
  • rebased the patch from 12-STABLE to -current
  • added the test script
  • fixed 2 issues
Mar 30 2021, 12:22 AM
takahiro.kurosawa_gmail.com commandeered D29468: pf: Implement the NAT source port selection of MAP-E Customer Edge.
Mar 30 2021, 12:13 AM