lltable: use sa_family_t instead of int for lltable.llt_af
ClosedPublic
Actions

Authored by takahiro.kurosawa_gmail.com on May 26 2022, 9:43 AM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rG3719dedb91eb: lltable: use sa_family_t instead of int for lltable.llt_af

Summary

Use proper type for address family instead of int.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

takahiro.kurosawa_gmail.com created this revision.May 26 2022, 9:43 AM

Herald added subscribers: Contributor Reviews (base), glebius, melifaro and 2 others. · View Herald TranscriptMay 26 2022, 9:43 AM

takahiro.kurosawa_gmail.com requested review of this revision.May 26 2022, 9:43 AM

Harbormaster completed remote builds in B45717: Diff 106384.May 26 2022, 9:43 AM

takahiro.kurosawa_gmail.com added reviewers: melifaro, network.May 26 2022, 9:44 AM

takahiro.kurosawa_gmail.com mentioned this in D35307: netinet6: fix proxy NDP.May 26 2022, 9:59 AM

melifaro accepted this revision.May 26 2022, 9:59 AM

melifaro added inline comments.

sys/net/if_llatbl.h
169–170	Nit: I'd add explicit `uint8_t llt_spare[3]` to indicate the spare field that arises due to alignment.

This revision is now accepted and ready to land.May 26 2022, 9:59 AM

Add the spare member to indicate explicit alignment.

This revision now requires review to proceed.May 26 2022, 10:13 AM

Harbormaster completed remote builds in B45718: Diff 106385.May 26 2022, 10:13 AM

takahiro.kurosawa_gmail.com added inline comments.May 26 2022, 10:14 AM

sys/net/if_llatbl.h
169–170	I've added the llt_spare member.

takahiro.kurosawa_gmail.com added a child revision: D35307: netinet6: fix proxy NDP.May 27 2022, 11:06 AM

This revision was not accepted when it landed; it landed in state Needs Review.May 30 2022, 10:54 AM

Closed by commit rG3719dedb91eb: lltable: use sa_family_t instead of int for lltable.llt_af (authored by takahiro.kurosawa_gmail.com, committed by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG3719dedb91eb: lltable: use sa_family_t instead of int for lltable.llt_af.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_llatbl.h

3 lines

Diff 106464

View Options

lltable: use sa_family_t instead of int for lltable.llt_afClosedPublicActions