Page MenuHomeFreeBSD
Differential D35323

lltable: use sa_family_t instead of int for lltable.llt_af
ClosedPublic
Actions

Authored by takahiro.kurosawa_gmail.com on May 26 2022, 9:43 AM.
Tags
None
Referenced Files
F166406109: D35323.id106384.diff
Thu, Aug 13, 10:55 AM
F166406032: D35323.id106464.diff
Thu, Aug 13, 10:55 AM
F166405646: D35323.diff
Thu, Aug 13, 10:51 AM
Unknown Object (File)
Wed, Aug 5, 2:12 PM
Unknown Object (File)
Sun, Aug 2, 6:06 AM
Unknown Object (File)
Sun, Aug 2, 5:14 AM
Unknown Object (File)
Sun, Aug 2, 1:51 AM
Unknown Object (File)
Sat, Aug 1, 6:35 AM
View All Files
Subscribers
ae
glebius
imp
melifaro
Contributor Reviews (src)

Details

Reviewers
melifaro
Group Reviewers
network
Commits
rG3719dedb91eb: lltable: use sa_family_t instead of int for lltable.llt_af
Summary

Use proper type for address family instead of int.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45718
Build 42606: arc lint + arc unit

Event Timeline

takahiro.kurosawa_gmail.com created this revision.May 26 2022, 9:43 AM
Herald added subscribers: Contributor Reviews (src), glebius, melifaro and 2 others. · View Herald TranscriptMay 26 2022, 9:43 AM
takahiro.kurosawa_gmail.com requested review of this revision.May 26 2022, 9:43 AM
Harbormaster completed remote builds in B45717: Diff 106384.May 26 2022, 9:43 AM
takahiro.kurosawa_gmail.com added reviewers: melifaro, network.May 26 2022, 9:44 AM
takahiro.kurosawa_gmail.com mentioned this in D35307: netinet6: fix proxy NDP.May 26 2022, 9:59 AM
melifaro accepted this revision.May 26 2022, 9:59 AM
melifaro added inline comments.
sys/net/if_llatbl.h
170–171

Nit: I'd add explicit uint8_t llt_spare[3] to indicate the spare field that arises due to alignment.

This revision is now accepted and ready to land.May 26 2022, 9:59 AM
takahiro.kurosawa_gmail.com updated this revision to Diff 106385.May 26 2022, 10:13 AM

Add the spare member to indicate explicit alignment.

This revision now requires review to proceed.May 26 2022, 10:13 AM
Harbormaster completed remote builds in B45718: Diff 106385.May 26 2022, 10:13 AM
takahiro.kurosawa_gmail.com added inline comments.May 26 2022, 10:14 AM
sys/net/if_llatbl.h
170–171

I've added the llt_spare member.

takahiro.kurosawa_gmail.com added a child revision: D35307: netinet6: fix proxy NDP.May 27 2022, 11:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 30 2022, 10:54 AM
Closed by commit rG3719dedb91eb: lltable: use sa_family_t instead of int for lltable.llt_af (authored by takahiro.kurosawa_gmail.com, committed by melifaro). · Explain Why
This revision was automatically updated to reflect the committed changes.
melifaro added a commit: rG3719dedb91eb: lltable: use sa_family_t instead of int for lltable.llt_af.

Revision Contents
Changeset List

PathSize
sys/
net/
3 lines

Diff 106385

View Options

sys/net/if_llatbl.h

Loading...