In D32157#725775, @tobik wrote:

LGTM.

Do we need to keep this after @rene commits D32008? If not we could remove it earlier than 1.56.

In D32155#725720, @arrowd wrote:

Looks good, thanks for upstreaming the patch!

Did you upload bootstraps somewhere?

In D31872#721168, @tobik wrote:

@mikael Should I update the armv7 bootstrap with the new ones from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257419#c25 ?

Can you change the armv6/7 target triple to this please:

--- a/lang/rust-bootstrap/Makefile
+++ b/lang/rust-bootstrap/Makefile
@@ -112,8 +112,8 @@ _RUST_LLVM_TARGET_powerpc64_elfv2=  PowerPC
 _RUST_LLVM_TARGET_powerpc64le=         PowerPC
 _RUST_LLVM_TARGET_powerpc=             PowerPC
 _RUST_LLVM_TRIPLE=                     ${_RUST_LLVM_TRIPLE_${FLAVOR}:U${_RUST_TARGET}}
-_RUST_LLVM_TRIPLE_armv6=               armv6-gnueabihf-freebsd
-_RUST_LLVM_TRIPLE_armv7=               armv7-gnueabihf-freebsd
+_RUST_LLVM_TRIPLE_armv6=               armv6-unknown-freebsd12.2-gnueabihf
+_RUST_LLVM_TRIPLE_armv7=               armv7-unknown-freebsd12.2-gnueabihf
 _RUST_LLVM_TRIPLE_powerpc=             powerpc-unknown-freebsd13.0 # secure-plt

Can you update patch-src_llvm-project_compiler-rt_lib_builtins_cpu__model.c with what will probably be committed upstream : https://reviews.llvm.org/D109330 . I've put the updated file on freefall.
In lang/rust-bootstrap: we can remove the llvm90 dep for aarch64 with the following patch:

--- a/lang/rust-bootstrap/Makefile
+++ b/lang/rust-bootstrap/Makefile
@@ -34,7 +35,6 @@ FLAVORS=      aarch64 amd64 armv6 armv7 i386 powerpc64_elfv1 powerpc64_elfv2 \
 FLAVOR?=       ${FLAVORS:[1]}

regen

In D31617#713919, @tobik wrote:

Thanks for doing the update.

• I've ran some ref machine builds a couple of weeks ago and they were all fine.

Thanks.

• Do we still need an exp-run? It looks like you already ran your own.

Not sure, I've only tried on 14amd64

• There is an updated LibreSSL patch on the ref machines at ref13-ppc64.freebsd.org:/home/tobik/staging/3995d76b-f848-11eb-abb0-c80aa94ee693/lang/rust/files/patch-vendor_openssl-sys_build_main.rs. Can you add it?

done

Address tobik's comments

Can someone commit this please?
Thanks in advance!

In D28520#675239, @tobik wrote:

@mikael, wondering why you abandoned? I am curious if adding build-stage=2 was already enough.

It's ok on armv7, aarch64

Can you also bump rust version in Mk/bsd.gecko.mk ?

In D28520#657426, @tobik wrote:

Do you know what the underlying issue with x.py build and x.py install is? It has never really been clear to me.

Honestly I don't know, it seems to only be an issue on low core machine (or at -j1). How many cpus do you have on your VM?

In D28906#647151, @arrowd wrote:

In D28906#647143, @mikael wrote:

In D28906#647082, @arrowd wrote:

When preparing a bootstrap it is advised to build with all OPTIONS set to OFF to save space and build time. Would you mind rerolling it again? If you don't want to do this, let's just commit it.

Only the GMP option is set.

This will make math/gmp a build dependency for lang/ghc, so it is better to turn it OFF too.

In D28906#647082, @arrowd wrote:

When preparing a bootstrap it is advised to build with all OPTIONS set to OFF to save space and build time. Would you mind rerolling it again? If you don't want to do this, let's just commit it.

the bootstraps are on freefall:/home/mikael/ghc

It's still a problem

gecko, jbeich : Mk/bsd.gecko.mk still mentions rust 1.43.0, should I bump this along rust update or do you prefer to do it?

fix plist

Address comments

committed in https://svnweb.freebsd.org/ports?view=revision&revision=557880