Differential D29425
lang/rust: Update to 1.51.0 Authored by tobik on Mar 26 2021, 10:14 AM. Tags None Referenced Files
Details
https://blog.rust-lang.org/2021/03/25/Rust-1.51.0.html Bootstraps are currently pre rP569007, so do not have the RUST_BACKTRACE fix, except for the aarch64 which was built with rP569245. I've added the simple patch from D28520. Not sure which direction is actually the faster one or if they are the same, but this should be safe to make for now without causing extra work. ref13-aarch64 ok powerpc64le does not have a reference machine AFAICT. @pkubaj Can you test it? Exp-run: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254578
Diff Detail
Event TimelineComment Actions
Comment Actions RUST_BACKTRACE seems to be broken (as in PR 253557) on ppc64 elfv1. No idea why but it also does not seem worth fixing to me. It works fine on the other tested systems. Comment Actions I have compilation issues on powerpc64le (related to the spec file) and am investigating this. If powerpc64 elfv1 is the troublesome, I'd say it would be fine to ditch it, especially since 13.0 is going out soon anyway. Firefox doesn't work on elfv1 anyway. Comment Actions lang/rust/files/powerpc64le/patch-compiler_rustc__target_src_spec_powerpc64le__unknown__freebsd.rs needs to be changed to: --- compiler/rustc_target/src/spec/powerpc64le_unknown_freebsd.rs.orig 2021-01-07 03:05:53 UTC +++ compiler/rustc_target/src/spec/powerpc64le_unknown_freebsd.rs @@ -0,0 +1,16 @@ +use crate::spec::{LinkerFlavor, Target, TargetOptions}; + +pub fn target() -> Target { + let mut base = super::freebsd_base::opts(); + base.cpu = "ppc64le".to_string(); + base.pre_link_args.get_mut(&LinkerFlavor::Gcc).unwrap().push("-m64".to_string()); + base.max_atomic_width = Some(64); + + Target { + llvm_target: "powerpc64le-unknown-freebsd".to_string(), + pointer_width: 64, + data_layout: "e-m:e-i64:64-n32:64".to_string(), + arch: "powerpc64".to_string(), + options: TargetOptions { mcount: "_mcount".to_string(), ..base }, + } +} Comment Actions
Comment Actions Well it is working now, so no reason to remove it just yet. There are more ports that use Rust too. For example librsvg2-rust which desktop ports depend on. We could switch elfv1 to use legacy librsvg if it ever came down to it though. In the end as long as ports still support elfv1 I think we should keep elfv1 support in Rust on a best effort basis anyway.
Done, but can somebody actually upstream the powerpc64le spec? I see that it was not done yet. You or maybe @bdragon? Comment Actions
The right description must have either been lost sometime ago or was never updated after the LLVM DESTDIR fix was pruned from it. |