@ pkubaj
Would you check this patch on your power pc machine?
If it's OK, please apply to Ports tree.

• change val argument of SYSCTL_INT macro to 0.

• Revert usbd_transfer_start macro change. As a result, nothing changed from original.
• Use CTLFLAG_RW flag for sysctl node.

Thanks for the comments.
I updated my patch that includes following fixes.

This review is obsoleted. Now valgrind in ports works fine.
Please close this review.
I can't see close menu or button in the web UI.

Should this be MFH'd to 2021Q4 for availability in /quarterly packages?

Would you please check this patch on your powerpc64 machine?
If it's OK, please apply to Ports tree.

Thanks for reviewing.
Please apply my patch to Ports tree.

Please check on your powerpc64 machine.

Could you please check this patch on your PPC machine?
If it's OK, please commit to Ports tree.

I'm glad the issue has been solved.
Thanks everyone for reviewing and testing my code.

In D28933#648397, @grehan wrote:

FYI the cumulative pfsense wireguard changes are in D28962

In D28933#648167, @zarychtam_plan-b.pwste.edu.pl wrote:

The IPv6 endpoint is accepted fine, but the tunnel is still not able to carry the data, at least legacy IP. Is it the complete solution or am I missing anything? At a glance, some outgoing and returning traffic can be dumped on the wg(4) interface, but it doesn't look fully functional since it behaves like a sinkhole with no local exit.

Fix to see sa_family to determine the length of struct sockaddr_in{6}.

In D28933#647903, @grehan wrote:

There's a more complete fix for this in the pfsense repo, that also stores the source address so CARP destination addresses will work:

https://github.com/pfsense/FreeBSD-src/commit/1940e7d3

In D17128#608395, @bdrewery wrote:

In D17128#371823, @des wrote:

I would strongly recommend submitting the sshbuf_{get,put,free}_passwd() part of this patch upstream.

Was this done?

Could you check this patch on your powerpc64?
if it's ok, please commit to ports tree.

If during debugging you want to restore the old behavior try the following:

Thanks for your reply.
I can confirm that ffmpeg can encode both h264_qsv and hevc_qsv.
HandBrake built from master branch of HandBrake repository doesn't encode H.265 QSV, too.
It seems that it is a HandBrake problem and not ports.

OK on 12.1 and head (powerpc64).

My HandBrake 1.3.2 & 1.3.1 fails to encode H.265 video by QSV on my skylake machine.
HandBrake 1.3.2 shows following log.

@pkubaj
Could you please check this patch on your powerpc64?

Sorry for the compile error.

Thanks for the patches, I could make buildworld.
I can confirm this libedit works with /bin/sh and /usr/sbin/sftp under UTF-8 and eucJP locales.
I also confirmed previous /bin/sh (before applying this patch) can work with this libedit.
It looks good to me.

I think bumping shlib is not needed.
It seems that '_el_fn_sh_complete' is the only function that is referenced by base.
It has been already redefined in contrib/libedit to keep compatibility.

@bapt
Never mind. I know updating lib/libedit is a tough job.
I will see your differential D21584.

I referred to following links to pick up the definitions.

Current Status is work in progress.
I'm not sure that all bugs (that is reported in NetBSD bug database) are reproducible on FreeBSD.
I saw that OpenBSD guy said libedit had a serious problem in https://marc.info/?l=openbsd-tech&m=156463894328592&w=2.
It is my motivation for this patch.

re-sync with NetBSD on Wed Aug 21 11:11:48 2019 +0000.
updated FreeBSD base revision.

I forget to submit comments. Sorry.

Update a patch that hrs@ reviewed.

I had review from hrs@ in FreeBSD workshop Tokyo on 21 Nov.
He commented about my patch and update it.
I will update this differential and write down his comments.

merged from NetBSD repository.
https://github.com/NetBSD/src/commit/2c6f49de1818d5230919fe1a8c4edea3d2c84d8f

I've changed my mind to send my patch to Christos and now it is committed to NetBSD source repository. We can see the difference clearly.

I talked with Christos and asked him to merge my patch to NetBSD src tree.
He accepted my request. So I will send my patch to him after it has been committed to FreeBSD src tree.

Update the date in the manual page.
Revert deleting NARROW_HISTORY flag.

This makes perfect sense to me as well, have you try to contact upstream (aka netbsd) with this patch? christos@ might be a good contact overthere.

Fixed editline.3 manual page.
With this fix, libedit supports multibyte charset other than UTF-8.

Fixed code style issues

Fixed commented issues.

Created D17128 for OpenSSH-7.8p1.

I see that r338561 commit updates openssh to 7.8p1.
I'm going to update my patch for this version and create a new differential.

I found one problem that sshd fails to reverse resolve hostname if server is set UseDNS yes .

Fixed code style issues and log messages.
No functional change.

How do we coordinate with upstream on this?

Fixed commented issues.
If you try this code, please be aware that you need to update libprivatessh.so.
Because I fixed buffer.c to implement functions for operating struct passwd.
Buffer related functions are written in 'buffer.c'.

regenerate patch by `diff -U9999```

Hi Conrad.
Thanks for the advice. I regenerated patch file. It seems good differential.