LGTM for security/dsniff and security/openssl, thanks.
Tue, Sep 21
Jul 14 2021
Jun 29 2021
Jun 17 2021
Jun 16 2021
Jun 13 2021
Jun 9 2021
Thanks @loader, just a minor nit in your commit message, it should be (full URL and no underscore for tags):
May 31 2021
May 28 2021
May 27 2021
May 25 2021
We do not need to specify the current branch and remote, as pointed by @uqs by default it uses the tracked upstream
Maybe we can get the current remote and branch using the something like, I'll test that:
May 24 2021
May 22 2021
May 13 2021
Now it's rebased, it should be safe to land. I searched for the usage of _PYTHON_VERSIONS, it's only used in lang/python-doc-html/Makefile
May 12 2021
It should be ready now, ping @ygy
Add new RUN_DEPENDS for listing the requirements, it's more readable and extensible as suggested by @debdrup
May 11 2021
I feel like this change also needs to incorporate https://reviews.freebsd.org/D30176 somehow - maybe check the platform first, then remove the tests that depend on absolute paths?
I think it would be better to check for the individual component parts, as @ygy suggests, and if any of them aren't found, recommend installing ports/textproc/docproj - but only print the error message once, even if multiple dependencies aren't found.
It should be possible to do this via .if and .elif BSD make macros, as documented in make(1) and use of another phony (ie. internal) environment variable.
IMO we could indeed recommend textproc/docproj. If we are going with this minimal approach, maybe try all checks and pop up the recommendations all at once, to avoid people having to run it multiple times to satisfy all dependencies? (and we can even recommend both)
Rewrite using bmake(1) instead of using shell
May 7 2021
After cloning the docs.git repository, I tried to run make run then it ends in lot of errors, so I thought it might be nice if the code prompt the user to install the minimal needed and missing packages to be able to use make run. Afterwards, I see it was mentioned in the fdp primer documentation in Chapter 2.1, but I like when the code prompt for what it's required to do. Alternatively, we could also just recommend to install textproc/docproj, but it's not the minimal way. Let me know what do you think.
May 5 2021
Note for myself:
May 4 2021
Apr 27 2021
Apr 23 2021
Apr 21 2021
Apr 20 2021
Looks good to me, just a re-wording proposal suggested. You might need another pair of eyes from someone with a doc bit.
change bindir from /usr/sbin to /usr/local/sbin to adress bz feedback
reword the commit message
Apr 19 2021
@crees Did you have a chance to look deeper?
Apr 16 2021
Current main at 86046cf55 build errors are the following:
Apr 15 2021
Apr 14 2021
Apr 13 2021
preserve the link to the wiki page in pkg-descr
Apr 12 2021
Apr 7 2021
@crees Just to make it more explicit, I'm all okay for these changes except we have to fixes the glitch that broke the rc script because of the following issue. Here the reproduction steps
Mar 30 2021
@mat What is the status of this? If it's deprecated, would you mind close it? Thanks.
Mar 29 2021
Nice catch! I don't think it requires portmgr for such trivial changes but maybe @crees would like to review it. As $portsdir is also used in line L.183. LGTM