@glebius : if you have time can you review this? you have expressed interest in PF + VIMAGE fixes in the past.

I would have liked to see some test results of ypldap before you hooked it up to the build.
Did you test ypldap on FreeBSD?

Regarding xo_attr(), yes you are right that it applies to XML and not JSON. That part of the patch is from Juniper's original patch,
and Juniper relies more heavily on XML for some of their stuff, so I would rather leave that part of the patch in for them.

TESTS(7) FreeBSD Miscellaneous Information Manual TESTS(7)

They already see it, they just don't know what to do once they are there.

No, I don't want this in `/usr/share/docs`. This is meant to be *newbie* friendly so people can just go in /usr/tests
and figure out what to do relatively quickly by looking at the README.
The way to figure this out right now is confusing enough as it is with info scattered all over the place in different man pages,
wikis, etc. The end result is that newbies can't figure out what to do, and keep asking me.

@araujo : the instructions that @mahrens gave are pretty straightforward. I looked at: https://github.com/openzfs/openzfs/pulls
but did not see you open a pull request. Do you plan to do this?

When you edit a comment, there is an icon *Meme*. If you click on that it allows you to add a funny meme.

@araujo: can you help test rS290931 ? I don't know how to configure an LDAP server to try this
There are some hints here: http://puffysecurity.com/wiki/ypldap.html

@bapt: For now, I need to expose the prototype somehow so that I can use it inside imsg code inside libopenbsd.
I can make a header internal to libopenbsd, or stick: `extern int getdtablecount(void);` in the imsg code to get things to compile.
Adding it to libc is doable, but I want to be conservative about adding a new symbol to libc. I've never done that before, and
am not familiar with all the things that need to be done when adding new stuff to libc in terms of symbol versioning, version bump, ports exp-run, etc.

@bapt: what should I do about the prototype for getdtablecount()? On OpenBSD, they put the prototype in <unistd.h>.
I was thinking of creating a header file libopenbsd.h and making it private to this
library, and putting it in there. Do you think I should do that, or do you have a better suggestion?

Implement getdtablecount() using new sysctl implemented by mjg.

@bapt are you OK with me implementing getdtablecount() in terms of @mjg's new sysctl?

Implement getdtablecount() using sysctl().

@bapt: if I call the same sysctl, I will pretty much be duplicating the code in kinfo_getfile(): https://reviews.freebsd.org/diffusion/S/browse/head/lib/libutil/kinfo_getfile.c;290404$13
I can do that. Are you OK with that approach?

Testing arc diff

There were some "svn mv" operations, that didn't show up in the diff:

@mmoll : It would be nice if @glebius could review this patch. He previously committed some patches I committed to FreeBSD which
attempted to fix this problem, so he has an interest in this area.

Use xo_set_version()

@alfred: who owns the http://freesbd.org domain? From the whois record, I couldn't figure out who owned it. Is it going to disappear soon?

There are multiple components to what Claudia did:

1. a redesigned web page, making use of Bootstrap CSS and contemporary web design techniques. This web page is quite clean and nice to look at, looks good on mobile devices, etc. This web page streamlines content, and provides easy links for obtaining FreeBSD, and FreeBSD-derived software such as PC-BSD (desktop), FreeNAS (embedded/storage).
2. a template system that uses Python Flask and Jinja

Note, the patch against the existing Makefile is just a dummy change, that I needed in order to initiate this review,
which is not a patch against existing files.