Page MenuHomeFreeBSD
Differential D2711

gnu/usr.bin/grep/savedir.c: Fix "implicit declaration of function 'isdir' is invalid in C99"
ClosedPublic
Actions

Authored by bofh on Jun 2 2015, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 5, 2:21 PM
Unknown Object (File)
Sun, Jul 5, 2:20 PM
Unknown Object (File)
Fri, Jul 3, 8:09 AM
Unknown Object (File)
Fri, Jul 3, 6:28 AM
Unknown Object (File)
Fri, Jul 3, 3:40 AM
Unknown Object (File)
Wed, Jul 1, 7:49 AM
Unknown Object (File)
May 10 2026, 8:29 AM
Unknown Object (File)
Apr 29 2026, 11:25 AM
View All Files
Subscribers
imp

Details

Reviewers
• rodrigc
bapt
Commits
rS290350: Include "system.h" for isdir() prototype.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bofh updated this revision to Diff 5879.Jun 2 2015, 2:03 PM
bofh retitled this revision from to gnu/usr.bin/grep/savedir.c: Fix "implicit declaration of function 'isdir' is invalid in C99".
bofh updated this object.
bofh edited the test plan for this revision. (Show Details)
bofh added a reviewer: bapt.
bofh set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 2 2015, 2:03 PM
bapt added a reviewer: • rodrigc.Jun 2 2015, 4:41 PM
• rodrigc edited edge metadata.Jun 2 2015, 7:08 PM

Technically this patch is OK.

However, we may want to match the upstream code which
does not include system.h. Instead if forward declares isdir(). See:
http://git.savannah.gnu.org/cgit/grep.git/tree/lib/savedir.c?id=v2.6

the latest version of GNU grep deleted savedir.c, so we would have to match v2.6

bapt edited edge metadata.Jun 2 2015, 7:31 PM

gnu grep will never be updated because of licenses issue, so upstreaming here is not a big issue

bofh added a comment.Jun 2 2015, 7:48 PM

I believe GNU Grep from 2.5.2 and onward changed to GPLv3 which prohibits from upgrading to newer version in base and hence we must stay with 2.5.1. :(

bofh added a comment.Jun 14 2015, 2:48 PM

Any updates ?

• rodrigc accepted this revision.Jul 30 2015, 12:39 PM
• rodrigc edited edge metadata.

I'm OK with this.

This revision is now accepted and ready to land.Jul 30 2015, 12:39 PM
bapt requested changes to this revision.Jul 30 2015, 3:47 PM
bapt edited edge metadata.
bapt added inline comments.
savedir.c
73 ↗(On Diff #5879)

Should be "system.h" not <system.h>

This revision now requires changes to proceed.Jul 30 2015, 3:47 PM
Closed by commit rS290350: Include "system.h" for isdir() prototype. (authored by • rodrigc). · Explain WhyNov 4 2015, 5:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
gnu/
usr.bin/
grep/
1 line

Diff 9939

View Options

head/gnu/usr.bin/grep/savedir.c

Loading...